mbox series

[v2,00/10] iio: adc: ad7606: Improvements

Message ID 20240628-cleanup-ad7606-v2-0-96e02f90256d@baylibre.com
Headers show
Series iio: adc: ad7606: Improvements | expand

Message

Guillaume Stols June 28, 2024, 2:48 p.m. UTC
This series adds the following improvements over the current AD7606's
driver implementation:

- Fix wrong usage of gpio array
- Fix standby that was documented as ACTIVE_LOW but handled in the
  driver as if it was ACTIVE_HIGH
- Improve dt-bindings documentation
- Switch mutex lock to scoped guard

Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
Changes in v2:
- Change scoped guard to guard(mutex)(&st->lock). This was tested with
  Rob's bot condition, and seems not to generate warning anymore.
- Reorder the commits for avoiding bisection issues and respect commit
  priority rules.
- Add vdrive-supply to required properties.
- Separate cosmetic changes from content ones in dt-binding
  descriptions.
- Move maxItems changes (and plural in descriptions) to the commit that
  adds conditions.
- Link to v1: https://lore.kernel.org/r/20240618-cleanup-ad7606-v1-0-f1854d5c779d@baylibre.com

---
Guillaume Stols (10):
      dt-bindings: iio: adc: adi,ad7606: add missing datasheet link
      dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names
      dt-bindings: iio: adc: adi,ad7606: normalize textwidth
      dt-bindings: iio: adc: adi,ad7606: improve descriptions
      dt-bindings: iio: adc: adi,ad7606: add supply properties
      dt-bindings: iio: adc: adi,ad7606: fix example
      dt-bindings: iio: adc: adi,ad7606: add conditions
      iio: adc: ad7606: fix oversampling gpio array
      iio: adc: ad7606: fix standby gpio state to match the documentation
      iio: adc: ad7606: switch mutexes to scoped_guard

 .../devicetree/bindings/iio/adc/adi,ad7606.yaml    | 129 ++++++++++++++++-----
 drivers/iio/adc/ad7606.c                           |  68 +++++------
 drivers/iio/adc/ad7606_spi.c                       |   5 +-
 3 files changed, 131 insertions(+), 71 deletions(-)
---
base-commit: 07d4d0bb4a8ddcc463ed599b22f510d5926c2495
change-id: 20240416-cleanup-ad7606-161e2ed9818b

Best regards,

Comments

Jonathan Cameron June 29, 2024, 3:38 p.m. UTC | #1
On Fri, 28 Jun 2024 16:55:37 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Fri, Jun 28, 2024 at 04:53:50PM +0100, Conor Dooley wrote:
> > On Fri, Jun 28, 2024 at 02:48:18PM +0000, Guillaume Stols wrote:  
> > > This series adds the following improvements over the current AD7606's
> > > driver implementation:
> > > 
> > > - Fix wrong usage of gpio array
> > > - Fix standby that was documented as ACTIVE_LOW but handled in the
> > >   driver as if it was ACTIVE_HIGH
> > > - Improve dt-bindings documentation
> > > - Switch mutex lock to scoped guard
> > > 
> > > Signed-off-by: Guillaume Stols <gstols@baylibre.com>  
> > 
> > You missed Acks from Rob on several patches that he gave yesterday:
> > https://lore.kernel.org/all/171952025424.477297.14698127361119381011.robh@kernel.org/  
> 
> You also seem to be missing acks from me..
> 

I picked up the first 2 with the acks scraped from v1.
There are enough minor changes that I've requested in the other patches
that I'd like a v3 fixing those.  Obviously make sure to gather up appropriate
acks.  You may want to wait a few days first though as there are a couple
of DT patches in here that need tags.

Jonathan