diff mbox series

[v2,08/28] video: fbdev: sis: Fix defined but not used warning of SiS_TVDelay

Message ID 20201128224114.1033617-9-sam@ravnborg.org
State Superseded
Headers show
Series drivers/video: W=1 warning fixes | expand

Commit Message

Sam Ravnborg Nov. 28, 2020, 10:40 p.m. UTC
Fix W=1 warning by commenting unused SiS_TVDelay* variables.

The SiS_TVDelay* variables seem to contain some magic numbers
so looks like data worth keeping around but not as code we build.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/sis/oem310.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Zimmermann Nov. 30, 2020, 9:13 a.m. UTC | #1
Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix W=1 warning by commenting unused SiS_TVDelay* variables.
> 
> The SiS_TVDelay* variables seem to contain some magic numbers
> so looks like data worth keeping around but not as code we build.

I would remove it. sisfb is broken beyond repair and no one's going to 
try to use it anyway. In any case

Acked-by: Thomas Zimemrmann <tzimmermann@suse.de>

> 
> v2:
>    - Update subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Winischhofer <thomas@winischhofer.net>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
>   drivers/video/fbdev/sis/oem310.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h
> index 8fce56e4482c..ed28755715ce 100644
> --- a/drivers/video/fbdev/sis/oem310.h
> +++ b/drivers/video/fbdev/sis/oem310.h
> @@ -200,6 +200,7 @@ static const unsigned char SiS310_TVDelayCompensation_651302LV[] =	/* M650, 651,
>   	0x33,0x33
>   };
>   
> +#if 0 /* Not used */
>   static const unsigned char SiS_TVDelay661_301[] =			/* 661, 301 */
>   {
>   	0x44,0x44,
> @@ -219,6 +220,7 @@ static const unsigned char SiS_TVDelay661_301B[] =			/* 661, 301B et al */
>   	0x44,0x44,
>   	0x44,0x44
>   };
> +#endif
>   
>   static const unsigned char SiS310_TVDelayCompensation_LVDS[] =		/* LVDS */
>   {
>
Thomas Zimmermann Dec. 1, 2020, 9:58 a.m. UTC | #2
Hi

Am 30.11.20 um 20:01 schrieb Sam Ravnborg:
> Hi Thomas.
> 
> On Mon, Nov 30, 2020 at 10:13:05AM +0100, Thomas Zimmermann wrote:
>>
>>
>> Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
>>> Fix W=1 warning by commenting unused SiS_TVDelay* variables.
>>>
>>> The SiS_TVDelay* variables seem to contain some magic numbers
>>> so looks like data worth keeping around but not as code we build.
>>
>> I would remove it. sisfb is broken beyond repair and no one's going to try
>> to use it anyway. In any case
>>
>> Acked-by: Thomas Zimemrmann <tzimmermann@suse.de>
> 
> Thanks for your patience pointing out all my spelling and grammar errors.
> I once had codespell set up to catch some of this, will need to do so
> again.
> 
> Ironically I copied the above "Acked-by:" line to most of the commits
> and just noticed it had a spelling error :-)

Perfect! :D

> 
> I have applied everything that you acked and will push when
> I have fixed the above and verified I did not break anything.
> Will post a v3 with the remaining patches later.
> 
> 	Sam
>
diff mbox series

Patch

diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h
index 8fce56e4482c..ed28755715ce 100644
--- a/drivers/video/fbdev/sis/oem310.h
+++ b/drivers/video/fbdev/sis/oem310.h
@@ -200,6 +200,7 @@  static const unsigned char SiS310_TVDelayCompensation_651302LV[] =	/* M650, 651,
 	0x33,0x33
 };
 
+#if 0 /* Not used */
 static const unsigned char SiS_TVDelay661_301[] =			/* 661, 301 */
 {
 	0x44,0x44,
@@ -219,6 +220,7 @@  static const unsigned char SiS_TVDelay661_301B[] =			/* 661, 301B et al */
 	0x44,0x44,
 	0x44,0x44
 };
+#endif
 
 static const unsigned char SiS310_TVDelayCompensation_LVDS[] =		/* LVDS */
 {