| Message ID | 20240114152759.1040563-3-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | backlight: hx8357: Clean up and make OF-independent | expand |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > Move OF table near to the user. > > While at it, drop comma at terminator entry. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/video/backlight/hx8357.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c > index c7fd10d55c5d..8709d9141cfb 100644 > --- a/drivers/video/backlight/hx8357.c > +++ b/drivers/video/backlight/hx8357.c > @@ -566,19 +566,6 @@ static struct lcd_ops hx8357_ops = { > > typedef int (*hx8357_init)(struct lcd_device *); > > -static const struct of_device_id hx8357_dt_ids[] = { > - { > - .compatible = "himax,hx8357", > - .data = hx8357_lcd_init, > - }, > - { > - .compatible = "himax,hx8369", > - .data = hx8369_lcd_init, > - }, > - {}, > -}; > -MODULE_DEVICE_TABLE(of, hx8357_dt_ids); > - > static int hx8357_probe(struct spi_device *spi) > { > struct device *dev = &spi->dev; > @@ -640,6 +627,19 @@ static int hx8357_probe(struct spi_device *spi) > return 0; > } > > +static const struct of_device_id hx8357_dt_ids[] = { > + { > + .compatible = "himax,hx8357", > + .data = hx8357_lcd_init, > + }, > + { > + .compatible = "himax,hx8369", > + .data = hx8369_lcd_init, > + }, > + {} While at it, maybe add the { /* sentinel */ } convention to the last entry ? Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote: > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: ... > > + {} > > While at it, maybe add the { /* sentinel */ } convention to the last entry ? Maybe. Is it a common for this subsystem? ... > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Thank you for the review!
diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c index c7fd10d55c5d..8709d9141cfb 100644 --- a/drivers/video/backlight/hx8357.c +++ b/drivers/video/backlight/hx8357.c @@ -566,19 +566,6 @@ static struct lcd_ops hx8357_ops = { typedef int (*hx8357_init)(struct lcd_device *); -static const struct of_device_id hx8357_dt_ids[] = { - { - .compatible = "himax,hx8357", - .data = hx8357_lcd_init, - }, - { - .compatible = "himax,hx8369", - .data = hx8369_lcd_init, - }, - {}, -}; -MODULE_DEVICE_TABLE(of, hx8357_dt_ids); - static int hx8357_probe(struct spi_device *spi) { struct device *dev = &spi->dev; @@ -640,6 +627,19 @@ static int hx8357_probe(struct spi_device *spi) return 0; } +static const struct of_device_id hx8357_dt_ids[] = { + { + .compatible = "himax,hx8357", + .data = hx8357_lcd_init, + }, + { + .compatible = "himax,hx8369", + .data = hx8369_lcd_init, + }, + {} +}; +MODULE_DEVICE_TABLE(of, hx8357_dt_ids); + static struct spi_driver hx8357_driver = { .probe = hx8357_probe, .driver = {
Move OF table near to the user. While at it, drop comma at terminator entry. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/video/backlight/hx8357.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)