mbox series

[0/4] gpio: visoconti: Add Toshiba Visconti GPIO support

Message ID 20201111172553.1369282-1-nobuhiro1.iwamatsu@toshiba.co.jp
Headers show
Series gpio: visoconti: Add Toshiba Visconti GPIO support | expand

Message

Nobuhiro Iwamatsu Nov. 11, 2020, 5:25 p.m. UTC 
Hi,

This series is the GPIO driver for Toshiba's ARM SoC, Visconti[0].
This includes DT binding documentation, device driver, MAINTAINER files, and updates to DT files.

Best regards,
  Nobuhiro

[0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html

Nobuhiro Iwamatsu (4):
  dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
  gpio: visoconti: Add Toshiba Visconti GPIO support
  MAINTAINERS: Add entries for Toshiba Visconti GPIO controller
  arm: dts: visconti: Add DT support for Toshiba Visconti5 GPIO driver

 .../bindings/gpio/toshiba,gpio-visconti.yaml  |  85 ++++++
 MAINTAINERS                                   |   2 +
 .../boot/dts/toshiba/tmpv7708-rm-mbrc.dts     |   4 +
 arch/arm64/boot/dts/toshiba/tmpv7708.dtsi     |  27 ++
 drivers/gpio/Kconfig                          |   8 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-visconti.c                  | 287 ++++++++++++++++++
 drivers/pinctrl/visconti/pinctrl-common.c     |  23 ++
 8 files changed, 437 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
 create mode 100644 drivers/gpio/gpio-visconti.c

Comments

Rob Herring (Arm) Nov. 11, 2020, 7:18 p.m. UTC | #1 
On Thu, 12 Nov 2020 02:25:50 +0900, Nobuhiro Iwamatsu wrote:
> Add bindings for the Toshiba Visconti GPIO Controller.

> 

> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

> ---

>  .../bindings/gpio/toshiba,gpio-visconti.yaml  | 85 +++++++++++++++++++

>  1 file changed, 85 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml

> 



My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml: properties:gpio-ranges: 'truei' is not of type 'object', 'boolean'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml: ignoring, error in schema: properties: gpio-ranges
warning: no schema found in file: ./Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml


See https://patchwork.ozlabs.org/patch/1398028

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.
Nobuhiro Iwamatsu Nov. 11, 2020, 11:31 p.m. UTC | #2 
Hi,

On Wed, Nov 11, 2020 at 01:18:38PM -0600, Rob Herring wrote:
> On Thu, 12 Nov 2020 02:25:50 +0900, Nobuhiro Iwamatsu wrote:

> > Add bindings for the Toshiba Visconti GPIO Controller.

> > 

> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

> > ---

> >  .../bindings/gpio/toshiba,gpio-visconti.yaml  | 85 +++++++++++++++++++

> >  1 file changed, 85 insertions(+)

> >  create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml

> > 

> 

> 

> My bot found errors running 'make dt_binding_check' on your patch:

> 

> yamllint warnings/errors:

> 

> dtschema/dtc warnings/errors:

> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml: properties:gpio-ranges: 'truei' is not of type 'object', 'boolean'

> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml: ignoring, error in schema: properties: gpio-ranges

> warning: no schema found in file: ./Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml

> 


Oh, this was typo...
I will fix this, thanks.

> 

> See https://patchwork.ozlabs.org/patch/1398028

> 

> The base for the patch is generally the last rc1. Any dependencies

> should be noted.

> 

> If you already ran 'make dt_binding_check' and didn't see the above

> error(s), then make sure 'yamllint' is installed and dt-schema is up to

> date:

> 

> pip3 install dtschema --upgrade

> 

> Please check and re-submit.

> 


Best regards,
  Nobuhiro