mbox series

[v6,0/6] Enhancements to AMD pinctrl and implementation of AMD pinmux

Message ID 20220601152900.1012813-1-Basavaraj.Natikar@amd.com
Headers show
Series Enhancements to AMD pinctrl and implementation of AMD pinmux | expand

Message

Basavaraj Natikar June 1, 2022, 3:28 p.m. UTC
Changes include enhancements to pinctrl-amd and implementing
AMD pinmux functionalities.

v6:
	- avoid nested conditionals.

v5:
        - removed parentheses around compound literals.
        - change platform_get_resource and devm_ioremap to
          devm_platform_ioremap_resource.
        - change dev_warn to dev_err wherever returns invalid or error.

v4:
        - Fix kernel doc issue
        - change PINCTRL_GRP to PINCTRL_PINGROUP
        - change fwnode_property_match_string to
          device_property_match_string.
        - make slightly better indentation and code few lines shorter.

v3:
        - change amd_pingroup to pingroup and moved to pinctrl.h.
        - Add prefix AMD_ at appropriate places.
        - use _DSD property to get iomux resource.

v2:
        - Fix for initializer element is not a compile-time constant
          on riscv architecture reported by kernel test robot
          <lkp@intel.com>.

Link: https://lore.kernel.org/all/202205240107.bryIFhOh-lkp@intel.com/

Basavaraj Natikar (6):
  pinctrl: Add pingroup and define PINCTRL_PINGROUP
  pinctrl: amd: Remove amd_pingroup and use pingroup
  pinctrl: amd: Use PINCTRL_PINGROUP to manage pingroups
  pinctrl: amd: Define and use AMD_PINS macro
  pinctrl: amd: Add amd_get_iomux_res function
  pinctrl: amd: Implement pinmux functionality

 drivers/pinctrl/pinctrl-amd.c   |  103 +++
 drivers/pinctrl/pinctrl-amd.h   | 1376 ++++++++++++++++++++++++++++++-
 include/linux/pinctrl/pinctrl.h |   20 +
 3 files changed, 1455 insertions(+), 44 deletions(-)

Comments

Linus Walleij June 3, 2022, 10:12 p.m. UTC | #1
On Wed, Jun 1, 2022 at 5:29 PM Basavaraj Natikar
<Basavaraj.Natikar@amd.com> wrote:

> Changes include enhancements to pinctrl-amd and implementing
> AMD pinmux functionalities.
>
> v6:
>         - avoid nested conditionals.

Patches applied for the next kernel cycle (v5.20).

Special thanks to Andy for reviewing and guiding!

Yours,
Linus Walleij
Andy Shevchenko June 6, 2022, 10:07 a.m. UTC | #2
On Sat, Jun 04, 2022 at 12:12:31AM +0200, Linus Walleij wrote:
> On Wed, Jun 1, 2022 at 5:29 PM Basavaraj Natikar
> <Basavaraj.Natikar@amd.com> wrote:
> 
> > Changes include enhancements to pinctrl-amd and implementing
> > AMD pinmux functionalities.
> >
> > v6:
> >         - avoid nested conditionals.
> 
> Patches applied for the next kernel cycle (v5.20).

Can you provide an immutable tag / branch, so I can pick it up to my tree and
develop patches for Intel drivers based on patch 1 from this series?

> Special thanks to Andy for reviewing and guiding!

You're welcome!
Linus Walleij June 15, 2022, 1:55 p.m. UTC | #3
On Mon, Jun 6, 2022 at 12:07 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Sat, Jun 04, 2022 at 12:12:31AM +0200, Linus Walleij wrote:
> > On Wed, Jun 1, 2022 at 5:29 PM Basavaraj Natikar
> > <Basavaraj.Natikar@amd.com> wrote:
> >
> > > Changes include enhancements to pinctrl-amd and implementing
> > > AMD pinmux functionalities.
> > >
> > > v6:
> > >         - avoid nested conditionals.
> >
> > Patches applied for the next kernel cycle (v5.20).
>
> Can you provide an immutable tag / branch, so I can pick it up to my tree and
> develop patches for Intel drivers based on patch 1 from this series?

Sorry for slowness.
Created ib-v5.20-amd-pinctrl as a branch in the pinctrl
tree and merged to devel. Pushing it out soon!

Yours,
Linus Walleij