[v2,RESEND,0/2] rockchip pinctrl for acpi

These patch fixes to support acpi by:
1. populate gpio platform before pinctrl to probe
2. get gpiochip by finding from gpiochip list
3. get match data by device api

Jianqun Xu (2):
  pinctrl: rockchip: find gpiochip by name from gpio module
  pinctrl: rockchip: get match data by device_get_match_data

 drivers/pinctrl/pinctrl-rockchip.c | 62 +++++++++++++++++++++---------
 drivers/pinctrl/pinctrl-rockchip.h |  2 +-
 2 files changed, 45 insertions(+), 19 deletions(-)

On Sat, Sep 17, 2022 at 8:09 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> These patch fixes to support acpi by:
> 1. populate gpio platform before pinctrl to probe
> 2. get gpiochip by finding from gpiochip list
> 3. get match data by device api
>
> Jianqun Xu (2):
>   pinctrl: rockchip: find gpiochip by name from gpio module
>   pinctrl: rockchip: get match data by device_get_match_data

These look OK to me but I would feel better if Heiko or Andy ACK:ed
them so I give them a few more days to comment.

Yours,
Linus Walleij

Am Dienstag, 20. September 2022, 11:26:26 CEST schrieb Linus Walleij:
> On Sat, Sep 17, 2022 at 8:09 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> 
> > These patch fixes to support acpi by:
> > 1. populate gpio platform before pinctrl to probe
> > 2. get gpiochip by finding from gpiochip list
> > 3. get match data by device api
> >
> > Jianqun Xu (2):
> >   pinctrl: rockchip: find gpiochip by name from gpio module
> >   pinctrl: rockchip: get match data by device_get_match_data
> 
> These look OK to me but I would feel better if Heiko or Andy ACK:ed
> them so I give them a few more days to comment.

Right now I'm actually quite confused as I seem to have a bunch
of pinctrl/gpio-acpi patchsets of varying lengths in my inbox.

There is a "v2", a "v8", a 20-patchset without version.
It's all quite confusing.


Heiko

On Fri, Sep 23, 2022 at 12:26:06PM +0200, Heiko Stuebner wrote:
> Am Dienstag, 20. September 2022, 11:26:26 CEST schrieb Linus Walleij:
> > On Sat, Sep 17, 2022 at 8:09 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> > 
> > > These patch fixes to support acpi by:
> > > 1. populate gpio platform before pinctrl to probe
> > > 2. get gpiochip by finding from gpiochip list
> > > 3. get match data by device api
> > >
> > > Jianqun Xu (2):
> > >   pinctrl: rockchip: find gpiochip by name from gpio module
> > >   pinctrl: rockchip: get match data by device_get_match_data
> > 
> > These look OK to me but I would feel better if Heiko or Andy ACK:ed
> > them so I give them a few more days to comment.
> 
> Right now I'm actually quite confused as I seem to have a bunch
> of pinctrl/gpio-acpi patchsets of varying lengths in my inbox.
> 
> There is a "v2", a "v8", a 20-patchset without version.
> It's all quite confusing.

With the LKP complains on top of almost each series...

That's why I stopped considering them seriously (like some RFC is going on)
and no more reviewing.

I can suggest the author to create a branch on a public tree and collect all
series together (like topic branches that are merged one-by-one to the main
topic branch) and start again.

Hi Jay,

Am Freitag, 23. September 2022, 12:35:36 CEST schrieb jay.xu@rock-chips.com:
> Hi heiko
> 
> --------------
> jay.xu@rock-chips.com
> >Am Dienstag, 20. September 2022, 11:26:26 CEST schrieb Linus Walleij:
> >> On Sat, Sep 17, 2022 at 8:09 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> >>
> >> > These patch fixes to support acpi by:
> >> > 1. populate gpio platform before pinctrl to probe
> >> > 2. get gpiochip by finding from gpiochip list
> >> > 3. get match data by device api
> >> >
> >> > Jianqun Xu (2):
> >> >   pinctrl: rockchip: find gpiochip by name from gpio module
> >> >   pinctrl: rockchip: get match data by device_get_match_data
> >>
> >> These look OK to me but I would feel better if Heiko or Andy ACK:ed
> >> them so I give them a few more days to comment.
> >
> >Right now I'm actually quite confused as I seem to have a bunch
> >of pinctrl/gpio-acpi patchsets of varying lengths in my inbox.
> >
> >There is a "v2", a "v8", a 20-patchset without version.
> >It's all quite confusing.
> > 
> From v2 to v8, I summit fixes in one patch, and them sugguested by Andy, I try to separate them
> into small patches 20-patchset.
> 
> The heart change is 
> 
> current
> 1. pinctrl register first
> 2. gpiochip register and find pinctrl device to add pin range
> 
> this patch fix to
> 1. gpiochip register itself
> 2. pinctrl register and find all gpiochips and add pin range
> 
> Please help to review directly to 20-patchset, I will add some suggested-by and acked-by later

ok, I'll drop all the other acpi/pinctrl/gpio sets and move to the 20-patch-series.

Thanks for the clarification
Heiko