mbox series

[v3,00/17] pinctrl: intel: Use NOIRQ PM helper

Message ID 20231030120734.2831419-1-andriy.shevchenko@linux.intel.com
Headers show
Series pinctrl: intel: Use NOIRQ PM helper | expand

Message

Andy Shevchenko Oct. 30, 2023, 12:07 p.m. UTC
Intel pin control drivers use NOIRQ variant of the PM callbacks.
To make them smaller and less error prone against different
kernel configurations (with possible defined but not used variables)
switch to use NOIRQ PM helper.

Changelog v3:
- dropped applied patches
- dropped MediaTek patch for now
- split Intel patch to the series using suggection by Paul

Changelog v2:
- rewritten commit message in patch 1 (Rafael)
- converted non-Intel pin control drivers as well
- added couple of kinda related patches to use pm_ptr()

Andy Shevchenko (17):
  pinctrl: intel: Provide Intel pin control wide PM ops structure
  pinctrl: alderlake: Switch to use Intel pin control PM ops
  pinctrl: broxton: Switch to use Intel pin control PM ops
  pinctrl: cannonlake: Switch to use Intel pin control PM ops
  pinctrl: cedarfork: Switch to use Intel pin control PM ops
  pinctrl: denverton: Switch to use Intel pin control PM ops
  pinctrl: elkhartlake: Switch to use Intel pin control PM ops
  pinctrl: emmitsburg: Switch to use Intel pin control PM ops
  pinctrl: geminilake: Switch to use Intel pin control PM ops
  pinctrl: icelake: Switch to use Intel pin control PM ops
  pinctrl: jasperlake: Switch to use Intel pin control PM ops
  pinctrl: lakefield: Switch to use Intel pin control PM ops
  pinctrl: lewisburg: Switch to use Intel pin control PM ops
  pinctrl: meteorlake: Switch to use Intel pin control PM ops
  pinctrl: sunrisepoint: Switch to use Intel pin control PM ops
  pinctrl: tigerlake: Switch to use Intel pin control PM ops
  pinctrl: intel: Make PM ops functions static

 drivers/pinctrl/intel/pinctrl-alderlake.c    |  5 ++---
 drivers/pinctrl/intel/pinctrl-broxton.c      |  5 ++---
 drivers/pinctrl/intel/pinctrl-cannonlake.c   |  5 ++---
 drivers/pinctrl/intel/pinctrl-cedarfork.c    |  5 ++---
 drivers/pinctrl/intel/pinctrl-denverton.c    |  5 ++---
 drivers/pinctrl/intel/pinctrl-elkhartlake.c  |  5 ++---
 drivers/pinctrl/intel/pinctrl-emmitsburg.c   |  5 ++---
 drivers/pinctrl/intel/pinctrl-geminilake.c   |  5 ++---
 drivers/pinctrl/intel/pinctrl-icelake.c      |  5 ++---
 drivers/pinctrl/intel/pinctrl-intel.c        | 14 +++++++-------
 drivers/pinctrl/intel/pinctrl-intel.h        | 11 +----------
 drivers/pinctrl/intel/pinctrl-jasperlake.c   |  5 ++---
 drivers/pinctrl/intel/pinctrl-lakefield.c    |  5 ++---
 drivers/pinctrl/intel/pinctrl-lewisburg.c    |  5 ++---
 drivers/pinctrl/intel/pinctrl-meteorlake.c   |  5 ++---
 drivers/pinctrl/intel/pinctrl-sunrisepoint.c |  5 ++---
 drivers/pinctrl/intel/pinctrl-tigerlake.c    |  5 ++---
 17 files changed, 38 insertions(+), 62 deletions(-)

Comments

Linus Walleij Nov. 2, 2023, 12:57 p.m. UTC | #1
On Mon, Oct 30, 2023 at 1:07 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Intel pin control drivers use NOIRQ variant of the PM callbacks.
> To make them smaller and less error prone against different
> kernel configurations (with possible defined but not used variables)
> switch to use NOIRQ PM helper.

Makes sense. The series:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Mika Westerberg Nov. 10, 2023, 6:14 a.m. UTC | #2
Hi Andy,

On Mon, Oct 30, 2023 at 02:07:17PM +0200, Andy Shevchenko wrote:
> Intel pin control drivers use NOIRQ variant of the PM callbacks.
> To make them smaller and less error prone against different
> kernel configurations (with possible defined but not used variables)
> switch to use NOIRQ PM helper.
> 
> Changelog v3:
> - dropped applied patches
> - dropped MediaTek patch for now
> - split Intel patch to the series using suggection by Paul
> 
> Changelog v2:
> - rewritten commit message in patch 1 (Rafael)
> - converted non-Intel pin control drivers as well
> - added couple of kinda related patches to use pm_ptr()
> 
> Andy Shevchenko (17):
>   pinctrl: intel: Provide Intel pin control wide PM ops structure
>   pinctrl: alderlake: Switch to use Intel pin control PM ops
>   pinctrl: broxton: Switch to use Intel pin control PM ops
>   pinctrl: cannonlake: Switch to use Intel pin control PM ops
>   pinctrl: cedarfork: Switch to use Intel pin control PM ops
>   pinctrl: denverton: Switch to use Intel pin control PM ops
>   pinctrl: elkhartlake: Switch to use Intel pin control PM ops
>   pinctrl: emmitsburg: Switch to use Intel pin control PM ops
>   pinctrl: geminilake: Switch to use Intel pin control PM ops
>   pinctrl: icelake: Switch to use Intel pin control PM ops
>   pinctrl: jasperlake: Switch to use Intel pin control PM ops
>   pinctrl: lakefield: Switch to use Intel pin control PM ops
>   pinctrl: lewisburg: Switch to use Intel pin control PM ops
>   pinctrl: meteorlake: Switch to use Intel pin control PM ops
>   pinctrl: sunrisepoint: Switch to use Intel pin control PM ops
>   pinctrl: tigerlake: Switch to use Intel pin control PM ops
>   pinctrl: intel: Make PM ops functions static
> 
>  drivers/pinctrl/intel/pinctrl-alderlake.c    |  5 ++---
>  drivers/pinctrl/intel/pinctrl-broxton.c      |  5 ++---
>  drivers/pinctrl/intel/pinctrl-cannonlake.c   |  5 ++---
>  drivers/pinctrl/intel/pinctrl-cedarfork.c    |  5 ++---
>  drivers/pinctrl/intel/pinctrl-denverton.c    |  5 ++---
>  drivers/pinctrl/intel/pinctrl-elkhartlake.c  |  5 ++---
>  drivers/pinctrl/intel/pinctrl-emmitsburg.c   |  5 ++---
>  drivers/pinctrl/intel/pinctrl-geminilake.c   |  5 ++---
>  drivers/pinctrl/intel/pinctrl-icelake.c      |  5 ++---
>  drivers/pinctrl/intel/pinctrl-intel.c        | 14 +++++++-------
>  drivers/pinctrl/intel/pinctrl-intel.h        | 11 +----------
>  drivers/pinctrl/intel/pinctrl-jasperlake.c   |  5 ++---
>  drivers/pinctrl/intel/pinctrl-lakefield.c    |  5 ++---
>  drivers/pinctrl/intel/pinctrl-lewisburg.c    |  5 ++---
>  drivers/pinctrl/intel/pinctrl-meteorlake.c   |  5 ++---
>  drivers/pinctrl/intel/pinctrl-sunrisepoint.c |  5 ++---
>  drivers/pinctrl/intel/pinctrl-tigerlake.c    |  5 ++---
>  17 files changed, 38 insertions(+), 62 deletions(-)

Nice! For the series,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Andy Shevchenko Nov. 13, 2023, 11:35 a.m. UTC | #3
On Fri, Nov 10, 2023 at 08:14:22AM +0200, Mika Westerberg wrote:
> On Mon, Oct 30, 2023 at 02:07:17PM +0200, Andy Shevchenko wrote:
> > Intel pin control drivers use NOIRQ variant of the PM callbacks.
> > To make them smaller and less error prone against different
> > kernel configurations (with possible defined but not used variables)
> > switch to use NOIRQ PM helper.

...

> Nice! For the series,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!