From patchwork Fri Oct 24 14:29:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 39480 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id AF65F20341 for ; Fri, 24 Oct 2014 14:30:16 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id d49sf239625eek.7 for ; Fri, 24 Oct 2014 07:30:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=MuG2bGTVlP7HwtFMkuq0ezjTREJ0g4jaJz0UAF0tWXE=; b=jZAyfrD5i6ol1HvAcUPqWN76CxLmmQVtWaI5yDlBpE61Ew9BvOvgNWzuHu/wfYYQ3j FpGrcNUhRtXaZGLEQi7xfIlD1rX3jLC5KIFdL1vUsNwZb/lKe5PF5MD9IrzlkxZoENjY vBU/RQ/e05FskeD/F+ZVCNzm6K1SGK9m4rF7UstkVIJR1fs9ERGSHAx9RPWbRzBS5Uel eheCr/E2bu00C2sdbVjzWdQpkvBOZLEQ3aeQ5zd4QImFVxpxtEB1Br9rlxPHHOB3WfFX VZZDI7rKSLwA82L5mSCtTlBNdhwO4zmJtPMgsoHmZFac6R8z0+7/TrHcHs4P3T5IQiTM +coQ== X-Gm-Message-State: ALoCoQmNAKEn0UYBp7taD+5NmyxYwggfEOi089zRv1BX0fCCv1kHxt1p7dEWN3IFlLIkXW4dJyZF X-Received: by 10.180.72.141 with SMTP id d13mr910825wiv.6.1414161015325; Fri, 24 Oct 2014 07:30:15 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.4.225 with SMTP id n1ls435262lan.34.gmail; Fri, 24 Oct 2014 07:30:15 -0700 (PDT) X-Received: by 10.112.36.197 with SMTP id s5mr5050762lbj.30.1414161015166; Fri, 24 Oct 2014 07:30:15 -0700 (PDT) Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com. [209.85.217.176]) by mx.google.com with ESMTPS id lk6si7267622lac.74.2014.10.24.07.30.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Oct 2014 07:30:15 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.176 as permitted sender) client-ip=209.85.217.176; Received: by mail-lb0-f176.google.com with SMTP id p9so2707936lbv.35 for ; Fri, 24 Oct 2014 07:30:15 -0700 (PDT) X-Received: by 10.153.8.164 with SMTP id dl4mr4907004lad.29.1414161014921; Fri, 24 Oct 2014 07:30:14 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.84.229 with SMTP id c5csp440594lbz; Fri, 24 Oct 2014 07:30:14 -0700 (PDT) X-Received: by 10.194.206.36 with SMTP id ll4mr5233153wjc.21.1414161014327; Fri, 24 Oct 2014 07:30:14 -0700 (PDT) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com. [74.125.82.44]) by mx.google.com with ESMTPS id uw9si5530902wjc.37.2014.10.24.07.30.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Oct 2014 07:30:14 -0700 (PDT) Received-SPF: pass (google.com: domain of daniel.thompson@linaro.org designates 74.125.82.44 as permitted sender) client-ip=74.125.82.44; Received: by mail-wg0-f44.google.com with SMTP id y10so1201008wgg.3 for ; Fri, 24 Oct 2014 07:30:14 -0700 (PDT) X-Received: by 10.194.221.105 with SMTP id qd9mr5142022wjc.51.1414161014033; Fri, 24 Oct 2014 07:30:14 -0700 (PDT) Received: from sundance.lan (cpc4-aztw19-0-0-cust157.18-1.cable.virginm.net. [82.33.25.158]) by mx.google.com with ESMTPSA id u2sm5836837wjz.11.2014.10.24.07.30.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Oct 2014 07:30:13 -0700 (PDT) From: Daniel Thompson To: Jiri Kosina Cc: Daniel Thompson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal , Linus Walleij , Alexandre Courbot Subject: [PATCH] gpio: msm-v1: Fix typo in function argument Date: Fri, 24 Oct 2014 15:29:57 +0100 Message-Id: <1414160997-30575-1-git-send-email-daniel.thompson@linaro.org> X-Mailer: git-send-email 1.9.3 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: daniel.thompson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.176 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , irq_set_irq_wake() treats its second argument as a boolean. It is much easier to read code when constant booleans are either 0 or 1! This particular line of code distracted me somewhat when I was doing a bit of work in a code browser since it (spuriously) got me worried that I had misunderstood how irq_set_irq_wake() worked. Signed-off-by: Daniel Thompson Cc: Linus Walleij Cc: Alexandre Courbot Reviewed-by: Alexandre Courbot --- drivers/gpio/gpio-msm-v1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.3 diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c index 73b7396..997e61e 100644 --- a/drivers/gpio/gpio-msm-v1.c +++ b/drivers/gpio/gpio-msm-v1.c @@ -686,7 +686,7 @@ static int gpio_msm_v1_probe(struct platform_device *pdev) irq_set_chained_handler(irq1, msm_gpio_irq_handler); irq_set_chained_handler(irq2, msm_gpio_irq_handler); irq_set_irq_wake(irq1, 1); - irq_set_irq_wake(irq2, 2); + irq_set_irq_wake(irq2, 1); return 0; }