From patchwork Sun Jun 17 23:00:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 138842 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3317122lji; Sun, 17 Jun 2018 16:02:57 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJTzL7BQdIXrpOwrx23XlKeD+Vv2/Ksp3jMR5b8zPKe9P+/u9M5ledIKRk49D+XjRsSesbo X-Received: by 2002:a17:902:b7c4:: with SMTP id v4-v6mr11423033plz.188.1529276577094; Sun, 17 Jun 2018 16:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529276577; cv=none; d=google.com; s=arc-20160816; b=CYjXx9t8NdoA77KYw0IUb+xrrB5gGQ62CrzzhuMUfkeXjEuAb+YZMcMFmVVy78Z60g rTgRA+tr5FhLG+Qt2kJ8PIBk+fpwVLE2hHkVolimltLI1oNgieHOr1fyZ45Wdh+Z+y2P 5cLjUo8dTS3Jt51Bz3xjhP4hmFuV5f4nf0GgQkTOHGHmyXXQP6McBaUoWGpYVueMtZgz qtzvnCdHRmloWoQFzH7s81TnGmuG28T7G/dIprw03aqRv+uAjUpAdKVGT1esSXM3Jynz nYx0MAt0EYTNkaD5v+iTieNTEjmknBmPLZ7GxlmGPFtW1dwN6eeTO2cDqtIh0vvdeXAw k1UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=0sSuuMY/AIiH/LyByH8mq9FFwvLcmdzASDh2oDC8XmQ=; b=M6UahFsfsgLi2Og9Nei+tT3CjT6s5nWYHrvjmeW4G/310bzAmdCKXSHDdwefi4GSZv Zux4A7OY/Jo3WhrdiBbL9wibITiAnd+GB/QKm6L1Xl/nzEIpbf1CCb20dIV07X6a99cX SJpP7i+0Ea8/n82nusJr/ubLiZROVCjuU1yV4L0+ppQJ3S1WcsiRtwVY/SZhc0kmXcoU lrFX9F+L5v3ML/1aFuqT5QTpTza2jLL0gHRzmUtvUewMo9OggCEdvW8TQoEEdU0Xbr2s oKKxdnUw2gdECevhXkwZVKGAkUgY+sgZedp5jSwsgW7uBwua1adbp8MidJrADs4RE8FX asGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=jhfpSJRP; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f13-v6si10651317pgv.374.2018.06.17.16.02.56; Sun, 17 Jun 2018 16:02:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=jhfpSJRP; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753970AbeFQXC4 (ORCPT + 5 others); Sun, 17 Jun 2018 19:02:56 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35290 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbeFQXCz (ORCPT ); Sun, 17 Jun 2018 19:02:55 -0400 Received: by mail-lf0-f67.google.com with SMTP id i15-v6so21862332lfc.2 for ; Sun, 17 Jun 2018 16:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=iADSlPVo/EnEYTTfOi95VUJ1MWLK9GBH5zc84vzdg5w=; b=jhfpSJRPVfpXu1a/SIgTXwUt4ysrxsWGZlaPq1Elc/1AcKjyMC3KzKVvI+t8PH9qA2 bwencL+EFET0IQeRkWYvDSxvgMuaAqUxvNugW1vSnWm6bJFjb6uHInX469CkISD0f93t DK9G41dgL7qik1zEWGEbZM9AvqEsk9wE+VxZI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iADSlPVo/EnEYTTfOi95VUJ1MWLK9GBH5zc84vzdg5w=; b=MgGFLk+2hoc9c60TpZnROYz0BHQ3hwH22BsgJIy+WoowyMmohfG2iADifT2118Wm+f Du1NVdMKCuWxQYgbBQxpKDxJ7+78Aslva9XCsqdBstozOF+WVDXQTwFMPNR8ir3Jg/9/ 5GoJZnmOoGH6SNdr7zAzS7TWysDm9g3LeKq4hkH7ZetYZqau+qNMQRKhV3VS3Uy2QgDn wRba0QEOxMDWHiZEdT5KRYg4MtiM8gLtpU1IYwu8nQeNTOKMkupeOtgMLGUdjkkSFOIL NcNjx4NVYkKDr11YK4EkI5cY3nFZcyIDRx8/P3DlUge4nJa4pZA/QlfZy6d0FbUsTMwx dc3Q== X-Gm-Message-State: APt69E2e+KDIoFOaty8oBGePuhWmkPRIP3CKag7QUbd+E5uTWpO+3EyK Pzi1nwTWT8QcOy1+2GOJXgZpUne0Q7o= X-Received: by 2002:a19:c454:: with SMTP id u81-v6mr1701189lff.24.1529276574060; Sun, 17 Jun 2018 16:02:54 -0700 (PDT) Received: from localhost.localdomain (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id f8-v6sm2513197lfc.29.2018.06.17.16.02.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Jun 2018 16:02:52 -0700 (PDT) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Linus Walleij Subject: [PATCH] pinctrl: gemini: Mask properly Date: Mon, 18 Jun 2018 01:00:48 +0200 Message-Id: <20180617230048.32669-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Some logical error in the gemini pin control driver made it not mask and write properly for the GMAC. Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-gemini.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/pinctrl-gemini.c b/drivers/pinctrl/pinctrl-gemini.c index 8c9970ae8505..fa7d998e1d5a 100644 --- a/drivers/pinctrl/pinctrl-gemini.c +++ b/drivers/pinctrl/pinctrl-gemini.c @@ -1696,6 +1696,7 @@ static const struct gemini_pin_group gemini_3516_pin_groups[] = { .name = "gmii_gmac0_grp", .pins = gmii_gmac0_3516_pins, .num_pins = ARRAY_SIZE(gmii_gmac0_3516_pins), + .mask = GEMINI_GMAC_IOSEL_MASK, .driving_mask = GENMASK(17, 16), }, { @@ -1703,6 +1704,7 @@ static const struct gemini_pin_group gemini_3516_pin_groups[] = { .pins = gmii_gmac1_3516_pins, .num_pins = ARRAY_SIZE(gmii_gmac1_3516_pins), /* Bring out RGMII on the GMAC1 pins */ + .mask = GEMINI_GMAC_IOSEL_MASK, .value = GEMINI_GMAC_IOSEL_GMAC0_GMAC1_RGMII, .driving_mask = GENMASK(19, 18), },