From patchwork Wed Jan 30 20:31:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 157086 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp6381635jaa; Wed, 30 Jan 2019 12:32:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN5MJli1at/uhiQ1S4DPnH/8ntHdbcRWBp4pZR/ki+BVuVpU0hvZhyPErENgEwRqwWRm2Z2s X-Received: by 2002:a63:da45:: with SMTP id l5mr29167660pgj.111.1548880334336; Wed, 30 Jan 2019 12:32:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548880334; cv=none; d=google.com; s=arc-20160816; b=tmEEsvg48O8GA1Up0kFeIVzBZL+j922iMkJPnalUUPgVJbi3G/qOX5drfKoOYfK8cV Zdb40pV6pDKrZX/KeRETSY3hITsmJ6Doz2xTYVR36JaP+xaS4ULbv8rt7xoti/k6w/Ab L/RTAknm2xVB6eCRj8YYemmt89ZrrIcKVYs1LyBEtM62bZ1CgknmdY5QS/6IB2Q+H0PE suM/ANDE3zE1DX9GrelGEOTJz1Xo1rwkPUeVjIzhslkEWrmchHByB+eruvgRA/aUElhZ KHX/rLEI3BPg0GCCH6h0ULD+yOHbjFRgDjtXpZGCKhuptqqoQoEkcqCV6GqUpcHEzkhI nvJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2DsvyMUobXFwqbjvbGHQLMfuQ/hrbWP5HekhEu8WOzc=; b=mSvCNDHCVzaYbDgjZtKdIcnhoEsAY7qutrG/406kgrrCRtMMmJtnjBG89qoDx+SIsP e6WfUVi3HGya/GAKOPxy+sIJd4zAyRY4v/wC1/uxWrrIghSfjmzTA/1ikMfxg37SBEUM 0mI9Yn8trCmcIj0f6WJhJzKKv6iVkGSd9Bb9ySOExf6Ako8Lah7q2OVFk5n9537mHjG+ zJ9oyAaLU1TUMdgNihbyZXI+Lwj53mlsIqKOFgtOSXBwQ0A+lBqXX2NgnU/5rlcP9JxL CvAwKjQiWvIKKnJjR5KGeQCP/KjMZGgKAtOyM3UjLzkLGYA3Ge5wCcZHo1cpq/tXi5mz y+qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NE8r6n01; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si2504673pfb.178.2019.01.30.12.32.14; Wed, 30 Jan 2019 12:32:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NE8r6n01; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387618AbfA3UcN (ORCPT + 5 others); Wed, 30 Jan 2019 15:32:13 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:43675 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387609AbfA3UcN (ORCPT ); Wed, 30 Jan 2019 15:32:13 -0500 Received: by mail-lf1-f65.google.com with SMTP id u18so626936lff.10 for ; Wed, 30 Jan 2019 12:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2DsvyMUobXFwqbjvbGHQLMfuQ/hrbWP5HekhEu8WOzc=; b=NE8r6n01AsK7uCOcLXQlVUuL2oxV8vILqMQzY4oTWqCKrhWLSJ4B9m0uTQQEm58zsQ tYIJSt64OmWKeSG8wQDR8SBFuedvb8zWczK6bduaT9+sdLoB+g7y9I8es2IAFXDSj5Jh dTwI57gUdtfuOBDuenEJpgtqqnvdylFXos9RE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2DsvyMUobXFwqbjvbGHQLMfuQ/hrbWP5HekhEu8WOzc=; b=jVxwg+Yz0x5yQsz5DZZz2O6cATPqXRyzAkAXzwtYcmGT09W8SIFLHqNfV2bf+PirqP jMfqn6+KchUCH20jIPLHNAGZyPBMHYatFSSGgGOOH2SEkUcsY3ZgeQwBvKqCtlQkOMLk xashQLcuzxaXz+VTu5LQCtJlMViaoyQ2t8+tadXLOzyT940nl/JMI8DxVxWX8psrkp3b z9h0rH5GrxpbKPMjMYx4eaeaLmaiyay4YmM+OXJJUFHs6ntpY/VCjfLoygQSVw0XXZzI yVaQ+RS6tGDdeJIdgME1gWlKhmNF+jRw+8qfhzerK5L6Tozp9A+ENNMUoVjlsszLA4or MecQ== X-Gm-Message-State: AJcUukdC8b0o2uWtUS3BjuWffNEA49UScEnRBG36b1euEiOpAI5a3Afm 6vomkMXOkOx7wIExy1RM9+A0smwU7so= X-Received: by 2002:a19:d619:: with SMTP id n25mr22887003lfg.91.1548880330415; Wed, 30 Jan 2019 12:32:10 -0800 (PST) Received: from linux.local (c-ae7b71d5.014-348-6c756e10.bbcust.telenor.se. [213.113.123.174]) by smtp.gmail.com with ESMTPSA id t144sm459071lff.53.2019.01.30.12.32.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 12:32:09 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Tim Harvey Subject: [PATCH 2/2] gpio: Add a Gateworks PLD GPIO driver Date: Wed, 30 Jan 2019 21:31:56 +0100 Message-Id: <20190130203156.19774-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190130203156.19774-1-linus.walleij@linaro.org> References: <20190130203156.19774-1-linus.walleij@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This adds a driver for Gateworks PLD GPIO, that exist in two instances on the Gateworks Cambria GW2358-4 router platform at least. Cc: Imre Kaloz Cc: Tim Harvey Signed-off-by: Linus Walleij --- drivers/gpio/Kconfig | 7 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-gw-pld.c | 137 +++++++++++++++++++++++++++++++++++++ 3 files changed, 145 insertions(+) create mode 100644 drivers/gpio/gpio-gw-pld.c -- 2.20.1 diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 77785f4b94bb..fe4a47e49a24 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -842,6 +842,13 @@ config GPIO_ADNP enough to represent all pins, but the driver will assume a register layout for 64 pins (8 registers). +config GPIO_GW_PLD + tristate "Gateworks PLD GPIO Expander" + depends on OF_GPIO + help + Say yes here to provide access to the Gateworks I2C PLD GPIO + Expander. This is used at least on the Cambria GW2358-4. + config GPIO_MAX7300 tristate "Maxim MAX7300 GPIO expander" select GPIO_MAX730X diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index 289ad2727bef..cf66523b5eec 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -55,6 +55,7 @@ obj-$(CONFIG_GPIO_FTGPIO010) += gpio-ftgpio010.o obj-$(CONFIG_GPIO_GE_FPGA) += gpio-ge.o obj-$(CONFIG_GPIO_GPIO_MM) += gpio-gpio-mm.o obj-$(CONFIG_GPIO_GRGPIO) += gpio-grgpio.o +obj-$(CONFIG_GPIO_GW_PLD) += gpio-gw-pld.o obj-$(CONFIG_GPIO_HLWD) += gpio-hlwd.o obj-$(CONFIG_HTC_EGPIO) += gpio-htc-egpio.o obj-$(CONFIG_GPIO_ICH) += gpio-ich.o diff --git a/drivers/gpio/gpio-gw-pld.c b/drivers/gpio/gpio-gw-pld.c new file mode 100644 index 000000000000..7ba8dd102f5a --- /dev/null +++ b/drivers/gpio/gpio-gw-pld.c @@ -0,0 +1,137 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Gateworks I2C PLD GPIO expander + * + * Copyright (C) 2019 Linus Walleij + * + * Based on code and know-how from the OpenWrt driver: + * Copyright (C) 2009 Gateworks Corporation + * Authors: Chris Lang, Imre Kaloz + */ +#include +#include +#include +#include +#include + +/** + * struct gw_pld - State container for Gateworks PLD + * @chip: GPIO chip instance + * @client: I2C client + * @out: shadow register for the output bute + */ +struct gw_pld { + struct gpio_chip chip; + struct i2c_client *client; + unsigned out; +}; + +/* + * The Gateworks I2C PLD chip only expose one read and one write register. + * Writing a "one" bit (to match the reset state) lets that pin be used as an + * input. It is an open-drain model. + */ +static int gw_pld_input8(struct gpio_chip *gc, unsigned offset) +{ + struct gw_pld *gw = gpiochip_get_data(gc); + + gw->out |= (1 << offset); + + return i2c_smbus_write_byte(gw->client, gw->out); +} + +static int gw_pld_get8(struct gpio_chip *gc, unsigned offset) +{ + struct gw_pld *gw = gpiochip_get_data(gc); + s32 value; + + value = i2c_smbus_read_byte(gw->client); + + return (value < 0) ? 0 : (value & (1 << offset)); +} + +static int gw_pld_output8(struct gpio_chip *gc, unsigned offset, int value) +{ + struct gw_pld *gw = gpiochip_get_data(gc); + unsigned bit = 1 << offset; + + if (value) + gw->out |= bit; + else + gw->out &= ~bit; + + return i2c_smbus_write_byte(gw->client, gw->out); +} + +static void gw_pld_set8(struct gpio_chip *gc, unsigned offset, int value) +{ + gw_pld_output8(gc, offset, value); +} + +static int gw_pld_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct device *dev = &client->dev; + struct device_node *np = dev->of_node; + struct gw_pld *gw; + int ret; + + gw = devm_kzalloc(dev, sizeof(*gw), GFP_KERNEL); + if (!gw) + return -ENOMEM; + + gw->chip.base = -1; + gw->chip.can_sleep = true; + gw->chip.parent = dev; + gw->chip.of_node = np; + gw->chip.owner = THIS_MODULE; + gw->chip.label = dev_name(dev); + gw->chip.ngpio = 8; + gw->chip.direction_input = gw_pld_input8; + gw->chip.get = gw_pld_get8; + gw->chip.direction_output = gw_pld_output8; + gw->chip.set = gw_pld_set8; + gw->client = client; + + /* + * The Gateworks I2C PLD chip does not properly send the acknowledge + * bit at all times, but we can still use the standard i2c_smbus + * functions by simply ignoring this bit. + */ + client->flags |= I2C_M_IGNORE_NAK; + gw->out = 0xFF; + + i2c_set_clientdata(client, gw); + + ret = devm_gpiochip_add_data(dev, &gw->chip, gw); + if (ret) + return ret; + + dev_info(dev, "registered Gateworks PLD GPIO device\n"); + + return 0; +} + +static const struct i2c_device_id gw_pld_id[] = { + { "gw-pld", }, + { } +}; +MODULE_DEVICE_TABLE(i2c, gw_pld_id); + +static const struct of_device_id gw_pld_dt_ids[] = { + { .compatible = "gateworks,pld-gpio", }, +}; +MODULE_DEVICE_TABLE(of, gw_pld_dt_ids); + +static struct i2c_driver gw_pld_driver = { + .driver = { + .name = "gw_pld", + .of_match_table = gw_pld_dt_ids, + }, + .probe = gw_pld_probe, + .id_table = gw_pld_id, +}; +module_i2c_driver(gw_pld_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Linus Walleij ");