From patchwork Mon Jan 9 13:27:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 640753 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 650EBC5479D for ; Mon, 9 Jan 2023 13:26:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233551AbjAIN0y (ORCPT ); Mon, 9 Jan 2023 08:26:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbjAIN0x (ORCPT ); Mon, 9 Jan 2023 08:26:53 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08637CCB; Mon, 9 Jan 2023 05:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673270813; x=1704806813; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bAHPKpx8104LaB0KsPUVZ4UAbNUE0Ufn60pvoDy2m2c=; b=mBccV+RZdD0zR6A7bVbtDWcsqc8K/yL0tOtO+z2yOf3k9BDXmVDhPxZE 53lysMo0KnCYU0tnqPrKKMGd77yo01p/YVNqsPAa/VQxtH8/J2qTg6qvE Et3H+yjRjaV2gDTTOlXykUxgkL7f3aqkYYkwTwV6yGgvlO3Z5ZcjcGbRu QZysofnM5jm8LTpCu6d1Il07zMrBkPUzp+o8tcvUlX/vYgF5OSP/oR5xd 1ioFEoLB8+tE4xWk0EZEOfAJbb/RNSjbKvMEbEVP3fxazDPXm3yfgmLjf uvHIl99Kud8Tjkl2BFRsWL1YcqP4TMQPk9LuaYh4MD5DMWO4iWze40411 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="310663950" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="310663950" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 05:26:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="830597505" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="830597505" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 09 Jan 2023 05:26:51 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9F1F9F4; Mon, 9 Jan 2023 15:27:24 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij Subject: [PATCH v1 1/1] pinctrl: pinmux: Drop duplicate error message in pinmux_select() Date: Mon, 9 Jan 2023 15:27:19 +0200 Message-Id: <20230109132719.86009-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org pinctrl_get_group_selector() prints an error message when group is not found in the list. No need to repeat this in the caller. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinmux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 6bd7ac37a0e0..021382632608 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -744,10 +744,8 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf, } ret = pinctrl_get_group_selector(pctldev, gname); - if (ret < 0) { - dev_err(pctldev->dev, "failed to get group selector for %s", gname); + if (ret < 0) goto exit_free_buf; - } gsel = ret; ret = pmxops->set_mux(pctldev, fsel, gsel);