From patchwork Mon Aug 7 21:30:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 711379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 716DAC001DE for ; Mon, 7 Aug 2023 21:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229441AbjHGVag (ORCPT ); Mon, 7 Aug 2023 17:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbjHGVaf (ORCPT ); Mon, 7 Aug 2023 17:30:35 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87CB2E7F for ; Mon, 7 Aug 2023 14:30:34 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-687087d8ddaso4824358b3a.1 for ; Mon, 07 Aug 2023 14:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1691443834; x=1692048634; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=0d1HkCkkEpN25te5X/k40XEe54K+lFIc6RAWHOOv77w=; b=VMZJpq0b08WVRpwEbpCcthpZ1ttFftGnB/W7RhuFG412RDZmxrX+n0bYl/jmRUpWTk bINkNumMpmhQdIpSWgLDjfBQ9NF/VLoJIeoeucm+lv1KCn1gYp9wmUyVZjlJn1sjK7SP 9y6f12UJBRSMX/2AhJgyjkIQjR52nlOqWJFOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691443834; x=1692048634; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0d1HkCkkEpN25te5X/k40XEe54K+lFIc6RAWHOOv77w=; b=E3D9bCowIONtx58ZDwWGYL7NnsQes4Y7qxH5p5jaxqyheTFyLw6f7hs9Bunvh7YGJW etpHg/C1OFewc/+oGHMUmxODeTQBmV1YbSHdm+hDhtSOTFf81dWhVEbCS0C4mpdIHUC3 t9aWmCZeRGJo9BvjWSiLwOtMuXJ2zHozB0bzQcZnuiDmtdgCfrEhRJ7hauaxAk94JsRa TCnm8zRmmi6zYxx98HBVx6zamZKO3n2U6kfYMggEtNIX1GTmV9xlQI+GoNUqg5+d/mDg xW5K8fEgmxqJ8tnDe/IcxTlLycdi1SvUZKi5h9OiJeJdIHL92SDbZ0fbT7eEV950oVf6 vxkw== X-Gm-Message-State: AOJu0Yz8attQ7gP9WFS1HzQlXeTuN/PW15GwZ3+gpWN/1mjDMRalce2a uwcYqJTGDPX6M2JAyu2Eq/rd/Q== X-Google-Smtp-Source: AGHT+IHGDF9JBdyq8KbbuIF3YTfh+8q+3TYwg4CGMDcVNGpCQKOwqbACjPLo5ORSWORZUO/pPNL7aw== X-Received: by 2002:a05:6a20:3d05:b0:132:a85f:b20c with SMTP id y5-20020a056a203d0500b00132a85fb20cmr14833895pzi.38.1691443833983; Mon, 07 Aug 2023 14:30:33 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id fm13-20020a056a002f8d00b0064fd4a6b306sm6571822pfb.76.2023.08.07.14.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 14:30:32 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , Andy Shevchenko , linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM IPROC ARM ARCHITECTURE) Subject: [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages Date: Mon, 7 Aug 2023 14:30:21 -0700 Message-Id: <20230807213022.1862903-2-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230807213022.1862903-1-florian.fainelli@broadcom.com> References: <20230807213022.1862903-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org We can have gpiochip_add_data() return -EPROBE_DEFER which will make us produce the "unable to add GPIO chip" message which is confusing. Use dev_err_probe() to silence probe deferral messages. Signed-off-by: Florian Fainelli --- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c index cc3eb7409ab3..153bfd3a48a4 100644 --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c @@ -892,7 +892,7 @@ static int iproc_gpio_probe(struct platform_device *pdev) ret = gpiochip_add_data(gc, chip); if (ret < 0) { - dev_err(dev, "unable to add GPIO chip\n"); + dev_err_probe(dev, ret, "unable to add GPIO chip\n"); return ret; }