From patchwork Fri Aug 11 13:14:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 712979 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CFA6C001DB for ; Fri, 11 Aug 2023 13:14:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234758AbjHKNOd (ORCPT ); Fri, 11 Aug 2023 09:14:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232087AbjHKNOc (ORCPT ); Fri, 11 Aug 2023 09:14:32 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 408A526A0 for ; Fri, 11 Aug 2023 06:14:32 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3176a439606so1763558f8f.3 for ; Fri, 11 Aug 2023 06:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1691759671; x=1692364471; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vS6U9ByOuvwpjOWYK9b5NZuGJIMOD+YNxq8azPqe3fQ=; b=IMr+jRP8N25FWJVRdjMffMQQtK3/yI5RHBQJ7cVg1SdZqVwZXwKV9gublQkzhCfsvK t50FLIbVdL5JO9zsrwTPbtzmxox7wMldJVkx+IbLtt8yR9y4LOQPa2X982PqKxd2O9re Zrr2aed8bQ4CwRChrTkAxFR9ZKLBwzFFiAM67sJxSF9lCdMEAVaD+MaoqJ3bR/4+mXK2 w7wWbjfWkqfACSgE7SPKpo7Qfy45UVW1aYISVsGJRp5ViebRk/OSW+iktNk4mrLWI+q/ x7bU7TbHknpEpNy8MNvJ0iT4K6B/id4w6W27ejiPmVAnT0+SMuvPwZDkgkU/XTiXKYXA Ar5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691759671; x=1692364471; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vS6U9ByOuvwpjOWYK9b5NZuGJIMOD+YNxq8azPqe3fQ=; b=XY50lffLPtQImkar9M8QfoUReXAPrj2InDlP1DytUHDN6OkbgEbUsWVuIdv4l0h4WS VEExYwKAsezBCh5NcZ5XcfCsd7qSSxJgF8DRX2bCwHJaJH61ePsHxrIYOug7doOc3/Tz 5JbEoBtRrIbcwu781DMUcjtjIBa3t0T+PbRsFZvEg09+HpA/uO4vP25KJnnuJiMApYW6 N0kqfugy1sEy5eW1pAP5kIk1CGoAWj0gH7t2iIlZC58tB8sZI51t97C95DCeeR9ycST0 Z3xrX9xuFVwYcW1xHUuzLKj7XjWHRQQWqehPU7vuaJgj8hQv5cLScUa3zBbhzoHslNSP R89w== X-Gm-Message-State: AOJu0YxO3znyUz9AliNFazvg3+k8Gnig/0fJMzmV6o1Ec0d5Y1X/bFKV 1eeERETXrcBE/1+YhlUiZ8ZhdA== X-Google-Smtp-Source: AGHT+IEd/H/N8EsyFQrs7K1p6f3J5b3KQas2v727xKUbr2HEDhcCHSJG/ACqw1rF1F+TU68n8OFlnA== X-Received: by 2002:a5d:6ac9:0:b0:319:62ba:5d08 with SMTP id u9-20020a5d6ac9000000b0031962ba5d08mr687203wrw.33.1691759670685; Fri, 11 Aug 2023 06:14:30 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:d0f3:773f:e87a:3b82]) by smtp.gmail.com with ESMTPSA id s2-20020adfecc2000000b0031433443265sm5365969wro.53.2023.08.11.06.14.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 06:14:30 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko , Kent Gibson Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 1/2] gpio: sim: simplify gpio_sim_device_config_live_store() Date: Fri, 11 Aug 2023 15:14:26 +0200 Message-Id: <20230811131427.40466-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Bartosz Golaszewski Simplify the logic when checking the current live value against the user input. Signed-off-by: Bartosz Golaszewski --- This is the same as what Andy suggested for gpio-consumer. Let's save a line. drivers/gpio/gpio-sim.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index dc4097dc0fbc..0177b41e0d72 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -986,8 +986,7 @@ gpio_sim_device_config_live_store(struct config_item *item, mutex_lock(&dev->lock); - if ((!live && !gpio_sim_device_is_live_unlocked(dev)) || - (live && gpio_sim_device_is_live_unlocked(dev))) + if (live == gpio_sim_device_is_live_unlocked(dev)) ret = -EPERM; else if (live) ret = gpio_sim_device_activate_unlocked(dev);