From patchwork Wed Oct 4 14:56:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Duje_Mihanovi=C4=87?= X-Patchwork-Id: 729405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B050CE7C4D4 for ; Wed, 4 Oct 2023 14:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243227AbjJDO5F (ORCPT ); Wed, 4 Oct 2023 10:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243128AbjJDO4w (ORCPT ); Wed, 4 Oct 2023 10:56:52 -0400 Received: from mx.skole.hr (mx1.hosting.skole.hr [161.53.165.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F88011D; Wed, 4 Oct 2023 07:56:48 -0700 (PDT) Received: from mx1.hosting.skole.hr (localhost.localdomain [127.0.0.1]) by mx.skole.hr (mx.skole.hr) with ESMTP id 0B30484AF1; Wed, 4 Oct 2023 16:56:47 +0200 (CEST) From: =?utf-8?q?Duje_Mihanovi=C4=87?= Date: Wed, 04 Oct 2023 16:56:29 +0200 Subject: [PATCH RFC v5 5/6] ARM: pxa: Convert gumstix Bluetooth to GPIO descriptors MIME-Version: 1.0 Message-Id: <20231004-pxa-gpio-v5-5-d99ae6fceea8@skole.hr> References: <20231004-pxa-gpio-v5-0-d99ae6fceea8@skole.hr> In-Reply-To: <20231004-pxa-gpio-v5-0-d99ae6fceea8@skole.hr> To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Alan Stern , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Dmitry Torokhov , Mark Brown Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org, =?utf-8?q?Duje_Miha?= =?utf-8?q?novi=C4=87?= X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2122; i=duje.mihanovic@skole.hr; h=from:subject:message-id; bh=Gv06Li3m6ZDEu/OZu0Z3JoESggoJqQsy9aW/skUnF5Q=; b=owEBbQKS/ZANAwAIAZoRnrBCLZbhAcsmYgBlHX0kwdV5y4zhyP8/zjJd45730lYLJamKkxfxQ N1m4W6WYpqJAjMEAAEIAB0WIQRT351NnD/hEPs2LXiaEZ6wQi2W4QUCZR19JAAKCRCaEZ6wQi2W 4bPsEACkCTkjzk3My/bY4JjnK+trV4GkYqLU8o+sqYfXF95p47zJVS8JbvlEGoCLk8ecB7eMSlj nKfICObaWgIvM8yNgwRiS0t2lKU4QAe37ocphg88uuUNqrT6kgHsLd8JbMXTmwknOvdYRm29E5m eAt/qZkg5rjvIihytRicEj/uayoEuS9IV6e3sQ8rBJQ1i3HmIbZoC14PtQPNn5/ENC0DYWXxYHy 8vEqTWNAOGc5py8ESsa8c908J8MUKCGHo62wn9f2CoUUYtK9GmpAcWThwgZD2Cu4wQb5aGcOgeO VpbaKuz/7g9KrYbYG7UH7z6aZNcSlFgiMlnGfoj33aFV4h0N92iJkX+tVKKDelQmpiLby9BfEfe uhcX+OerBofGMdZGrKyKAfaMsuSmpYM7K+YLkmXnCqPswDCaxMB3mwXuyidvs3EXlOJB44xSD96 f8tDsCyEVCyjTVloL1hI7nTtazouZBc3xSld3ew0fvB7EbDHyqGNgJ26BErXj29MsTv80GYQw8O xNseAyu1mW6Uf+ThqwgjpEfhjTqSlbgpLBX8JZ5Wh+HlSIF72AcC8Ce7rrhGZJYhBqM76FQHUKv 40NvFuMQay9T9MQIA15heVEOisMi1YqDxcyEzcZW82cQTuFezLLHZ2hCpkdnP0sM8G10ZYbmo22 uyF836IrqKgCk6g== X-Developer-Key: i=duje.mihanovic@skole.hr; a=openpgp; fpr=53DF9D4D9C3FE110FB362D789A119EB0422D96E1 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Gumstix still uses the legacy GPIO interface for resetting the Bluetooth device. Convert it to use the GPIO descriptor interface. Reviewed-by: Linus Walleij Signed-off-by: Duje Mihanović Reviewed-by: Bartosz Golaszewski --- arch/arm/mach-pxa/gumstix.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-pxa/gumstix.c b/arch/arm/mach-pxa/gumstix.c index c9f0f62187bd..0bca6e2c80a9 100644 --- a/arch/arm/mach-pxa/gumstix.c +++ b/arch/arm/mach-pxa/gumstix.c @@ -20,8 +20,8 @@ #include #include #include +#include #include -#include #include #include @@ -129,6 +129,11 @@ static void gumstix_udc_init(void) #endif #ifdef CONFIG_BT +GPIO_LOOKUP_SINGLE(gumstix_bt_gpio_table, "pxa2xx-uart.1", "pxa-gpio", + GPIO_GUMSTIX_BTRESET, "BTRST", GPIO_ACTIVE_LOW); + +static struct gpio_desc *bt_reset; + /* Normally, the bootloader would have enabled this 32kHz clock but many ** boards still have u-boot 1.1.4 so we check if it has been turned on and ** if not, we turn it on with a warning message. */ @@ -153,24 +158,19 @@ static void gumstix_setup_bt_clock(void) static void __init gumstix_bluetooth_init(void) { - int err; + gpiod_add_lookup_table(&gumstix_bt_gpio_table); gumstix_setup_bt_clock(); - err = gpio_request(GPIO_GUMSTIX_BTRESET, "BTRST"); - if (err) { + bt_reset = gpiod_get(&pxa_device_btuart.dev, "BTRST", GPIOD_OUT_HIGH); + if (IS_ERR(bt_reset)) { pr_err("gumstix: failed request gpio for bluetooth reset\n"); return; } - err = gpio_direction_output(GPIO_GUMSTIX_BTRESET, 1); - if (err) { - pr_err("gumstix: can't reset bluetooth\n"); - return; - } - gpio_set_value(GPIO_GUMSTIX_BTRESET, 0); + gpiod_set_value(bt_reset, 1); udelay(100); - gpio_set_value(GPIO_GUMSTIX_BTRESET, 1); + gpiod_set_value(bt_reset, 0); } #else static void gumstix_bluetooth_init(void)