From patchwork Tue Oct 10 15:17:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 732298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83474CD8CA7 for ; Tue, 10 Oct 2023 15:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232957AbjJJPRS (ORCPT ); Tue, 10 Oct 2023 11:17:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbjJJPRR (ORCPT ); Tue, 10 Oct 2023 11:17:17 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F7A8C9; Tue, 10 Oct 2023 08:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696951036; x=1728487036; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cfi2ScUuQ38Rjpas5/iU2szLV7W2WROp/dyzeK87y4E=; b=csOEtFfhoWAPmG3pgKhLABa0dAjecUwK8QWP7LbERrL+bidKI7hA4YgE tEgyBc3Y0xpSKND4DcLlz/tJpdqDxxIdRsXuMX7JvqpjPGOLqh2FKfsPB rUVAe+mP4bzDa6b9jQdSAi4nVdSVZO4iCXOeoD4ZckSIJJMgWiSMaN9Be KxXro7+IaF3U3CwE7P/pr2skxcpF8LMaA0QdYwIB3z1YYJzF7tN77gVB4 GJvqREEGfacXijwQPNM+JUjU6UiYfTei/nWpbaGUUTUPJrDgOPWfz01ff cOsKtPmVq1a5Wlyo069zQIa4vhOzOFAw5wY/GxLn1StgvAEmiGnNoWYhi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="363771593" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="363771593" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2023 08:17:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="823812776" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="823812776" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Oct 2023 08:17:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 484EE6DA; Tue, 10 Oct 2023 18:17:10 +0300 (EEST) From: Andy Shevchenko To: Bartosz Golaszewski , Andy Shevchenko , Dipen Patel , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, timestamp@lists.linux.dev, linux-tegra@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Thierry Reding , Jonathan Hunter Subject: [PATCH v1 3/4] hte: tegra194: Remove redundant dev_err() Date: Tue, 10 Oct 2023 18:17:08 +0300 Message-Id: <20231010151709.4104747-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com> References: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There is no need to call the dev_err() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Andy Shevchenko --- drivers/hte/hte-tegra194.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c index 339ff5921ec8..30ef1750a9fa 100644 --- a/drivers/hte/hte-tegra194.c +++ b/drivers/hte/hte-tegra194.c @@ -731,10 +731,8 @@ static int tegra_hte_probe(struct platform_device *pdev) return -ENOMEM; ret = platform_get_irq(pdev, 0); - if (ret < 0) { - dev_err_probe(dev, ret, "failed to get irq\n"); + if (ret < 0) return ret; - } hte_dev->hte_irq = ret; ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0, dev_name(dev), hte_dev);