diff mbox series

[v2,1/2] dt-bindings: gpio: realtek: Add realtek,rtd-gpio

Message ID 20231116111441.2339-2-tychang@realtek.com
State Superseded
Headers show
Series Add gpio driver support for Realtek DHC SoCs | expand

Commit Message

TY_Chang[張子逸] Nov. 16, 2023, 11:14 a.m. UTC
Add the device tree bindings for the Realtek DHC(Digital Home Center)
RTD SoCs GPIO controllers.

Signed-off-by: Tzuyi Chang <tychang@realtek.com>
---
v1 to v2 change:
    1. Add description for DHC RTD SoCs.
    2. Revise the compatible names.
    3. Add descriptions for reg and interrupts properties.
---
 .../bindings/gpio/realtek,rtd-gpio.yaml       | 74 +++++++++++++++++++
 1 file changed, 74 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml

Comments

TY_Chang[張子逸] Nov. 21, 2023, 7:07 a.m. UTC | #1
Hi, Krzysztof

>On 16/11/2023 12:14, Tzuyi Chang wrote:
>> Add the device tree bindings for the Realtek DHC(Digital Home Center)
>> RTD SoCs GPIO controllers.
>>
>> Signed-off-by: Tzuyi Chang <tychang@realtek.com>
>> ---
>> v1 to v2 change:
>>     1. Add description for DHC RTD SoCs.
>>     2. Revise the compatible names.
>>     3. Add descriptions for reg and interrupts properties.
>> ---
>>  .../bindings/gpio/realtek,rtd-gpio.yaml       | 74 +++++++++++++++++++
>>  1 file changed, 74 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
>> b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
>> new file mode 100644
>> index 000000000000..11c8278801c3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
>> @@ -0,0 +1,74 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright 2023
>> +Realtek Semiconductor Corporation %YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/gpio/realtek,rtd-gpio.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Realtek DHC GPIO controller
>> +
>> +maintainers:
>> +  - Tzuyi Chang <tychang@realtek.com>
>> +
>> +description:
>> +  The GPIO controller is designed for the Realtek DHC (Digital Home
>> +Center)
>> +  RTD SoC family, which are high-definition media processor SoCs.
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - items:
>
>Drop items.
>
>> +          - enum:
>> +              - realtek,rtd1295-misc-gpio
>> +              - realtek,rtd1295-iso-gpio
>> +              - realtek,rtd1395-iso-gpio
>> +              - realtek,rtd1619-iso-gpio
>> +      - items:
>> +          - enum:
>> +              - realtek,rtd1319-iso-gpio
>> +              - realtek,rtd1619b-iso-gpio
>> +              - realtek,rtd1319d-iso-gpio
>> +              - realtek,rtd1315e-iso-gpio
>> +          - const: realtek,rtd-gpio
>
>Either you use generic compatible for everything or not. Other variants do not
>use generic compatible, so neither should these. Use SoC-specific compatible as
>fallback.
>
>I asked you to to drop this compatible. I could not be more specific, so you just
>ignored this remark.
>
>So again: what is "rtd"? Why it does not appear anywhere in description or title?
>No, drop it.
>

"rtd" is the product series identifier. I will drop this generic compatible and use SoC-specific compatible instead.

Thanks,
Tzuyi Chang
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
new file mode 100644
index 000000000000..11c8278801c3
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/realtek,rtd-gpio.yaml
@@ -0,0 +1,74 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2023 Realtek Semiconductor Corporation
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/realtek,rtd-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek DHC GPIO controller
+
+maintainers:
+  - Tzuyi Chang <tychang@realtek.com>
+
+description:
+  The GPIO controller is designed for the Realtek DHC (Digital Home Center)
+  RTD SoC family, which are high-definition media processor SoCs.
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - realtek,rtd1295-misc-gpio
+              - realtek,rtd1295-iso-gpio
+              - realtek,rtd1395-iso-gpio
+              - realtek,rtd1619-iso-gpio
+      - items:
+          - enum:
+              - realtek,rtd1319-iso-gpio
+              - realtek,rtd1619b-iso-gpio
+              - realtek,rtd1319d-iso-gpio
+              - realtek,rtd1315e-iso-gpio
+          - const: realtek,rtd-gpio
+
+  reg:
+    items:
+      - description: GPIO controller registers
+      - description: GPIO interrupt registers
+
+  interrupts:
+    items:
+      - description: Interrupt number of the assert GPIO interrupt, which is
+                     triggered when there is a rising edge.
+      - description: Interrupt number of the deassert GPIO interrupt, which is
+                     triggered when there is a falling edge.
+
+  gpio-ranges: true
+
+  gpio-controller: true
+
+  "#gpio-cells":
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - gpio-ranges
+  - gpio-controller
+  - "#gpio-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    gpio@100 {
+      compatible = "realtek,rtd1319d-iso-gpio", "realtek,rtd-gpio";
+      reg = <0x100 0x100>,
+            <0x000 0x0b0>;
+      interrupt-parent = <&iso_irq_mux>;
+      interrupts = <19>, <20>;
+      gpio-ranges = <&pinctrl 0 0 82>;
+      gpio-controller;
+      #gpio-cells = <2>;
+    };