| Message ID | 20240314232201.2102178-12-jan.dakinevich@salutedevices.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce support of audio for Amlogic A1 SoC family | expand |
On Fri, Mar 15, 2024 at 02:21:47AM +0300, Jan Dakinevich wrote: > Add "amlogic,t9015-a1" compatible string. That's obvious from the diff. Perhaps what does 'a1' mean? What the difference from the existing compatible? > > Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> > --- > Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > index 5f5cccdbeb34..ee8bd57dbcf9 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml > @@ -21,7 +21,9 @@ properties: > > compatible: > items: > - - const: amlogic,t9015 > + - enum: > + - amlogic,t9015 > + - amlogic,t9015-a1 > > clocks: > items: > -- > 2.34.1 >
On 3/17/24 22:03, Rob Herring wrote: > On Fri, Mar 15, 2024 at 02:21:47AM +0300, Jan Dakinevich wrote: >> Add "amlogic,t9015-a1" compatible string. > > That's obvious from the diff. Perhaps what does 'a1' mean? What the > difference from the existing compatible? > a1 means A1 SoC family. The difference is described in next commit where this compatible string is added to driver. Should I duplicate here the explanation from that commit? >> >> Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> >> --- >> Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml >> index 5f5cccdbeb34..ee8bd57dbcf9 100644 >> --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml >> +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml >> @@ -21,7 +21,9 @@ properties: >> >> compatible: >> items: >> - - const: amlogic,t9015 >> + - enum: >> + - amlogic,t9015 >> + - amlogic,t9015-a1 >> >> clocks: >> items: >> -- >> 2.34.1 >>
On 18/03/2024 00:39, Jan Dakinevich wrote: > > > On 3/17/24 22:03, Rob Herring wrote: >> On Fri, Mar 15, 2024 at 02:21:47AM +0300, Jan Dakinevich wrote: >>> Add "amlogic,t9015-a1" compatible string. >> >> That's obvious from the diff. Perhaps what does 'a1' mean? What the >> difference from the existing compatible? >> > > a1 means A1 SoC family. The difference is described in next commit where > this compatible string is added to driver. Should I duplicate here the > explanation from that commit? > Bindings, not the driver, describe the hardware. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml index 5f5cccdbeb34..ee8bd57dbcf9 100644 --- a/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml +++ b/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml @@ -21,7 +21,9 @@ properties: compatible: items: - - const: amlogic,t9015 + - enum: + - amlogic,t9015 + - amlogic,t9015-a1 clocks: items:
Add "amlogic,t9015-a1" compatible string. Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com> --- Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)