| Message ID | 20240314232201.2102178-23-jan.dakinevich@salutedevices.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce support of audio for Amlogic A1 SoC family | expand |
On Fri, Mar 15, 2024 at 02:21:58AM +0300, Jan Dakinevich wrote: > From: Dmitry Rokosov <ddrokosov@salutedevices.com> > > The 'link-name' property is an optional DT property that allows for the > customization of the name associated with the DAI link and PCM stream. > This functionality mirrors the approach commonly utilized in Qualcomm > audio cards, providing flexibility in DAI naming conventions for > improved system integration and userspace experience. > > It allows userspace program to easy determine PCM stream purpose, e.g.: > ~ # cat /proc/asound/pcm > 00-00: speaker (*) : : playback 1 > 00-01: mics (*) : : capture 1 > 00-02: loopback (*) : : capture 1 > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> This needs your S-o-b as well.
Hello Rob, On Sun, Mar 17, 2024 at 01:45:34PM -0600, Rob Herring wrote: > On Fri, Mar 15, 2024 at 02:21:58AM +0300, Jan Dakinevich wrote: > > From: Dmitry Rokosov <ddrokosov@salutedevices.com> > > > > The 'link-name' property is an optional DT property that allows for the > > customization of the name associated with the DAI link and PCM stream. > > This functionality mirrors the approach commonly utilized in Qualcomm > > audio cards, providing flexibility in DAI naming conventions for > > improved system integration and userspace experience. > > > > It allows userspace program to easy determine PCM stream purpose, e.g.: > > ~ # cat /proc/asound/pcm > > 00-00: speaker (*) : : playback 1 > > 00-01: mics (*) : : capture 1 > > 00-02: loopback (*) : : capture 1 > > > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > This needs your S-o-b as well. I will send this change in the separate patch series, as Neil suggested in the cover letter reply.
diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml index 492b41cc8ccd..46774a3e4b1d 100644 --- a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml @@ -66,6 +66,11 @@ patternProperties: maxItems: 1 description: phandle of the CPU DAI + link-name: + description: Indicates dai-link name and PCM stream name. + $ref: /schemas/types.yaml#/definitions/string + maxItems: 1 + patternProperties: "^dai-tdm-slot-(t|r)x-mask-[0-3]$": $ref: /schemas/types.yaml#/definitions/uint32-array @@ -137,6 +142,7 @@ examples: dai-link-0 { sound-dai = <&frddr_a>; + link-name = "speaker"; }; dai-link-1 { diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml index d4277d342e69..975c148f9712 100644 --- a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml @@ -52,6 +52,11 @@ patternProperties: maxItems: 1 description: phandle of the CPU DAI + link-name: + description: Indicates dai-link name and PCM stream name. + $ref: /schemas/types.yaml#/definitions/string + maxItems: 1 + patternProperties: "^codec(-[0-9]+)?$": type: object @@ -89,6 +94,7 @@ examples: dai-link-0 { sound-dai = <&i2s_fifo>; + link-name = "speaker"; }; dai-link-1 {