From patchwork Sat Dec 30 12:48:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J.A. Bezemer" X-Patchwork-Id: 760075 Received: from wormhole.robuust.nl (leaseweb-ip1.robuust.nl [178.162.147.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 653ED8F52 for ; Sat, 30 Dec 2023 13:08:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=opensourcepartners.nl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=wormhole.robuust.nl Received: from costar (helo=localhost) by wormhole.robuust.nl with local-esmtp (Exim 3.36 #1 (Debian)) id 1rJYlp-0007vQ-00 for ; Sat, 30 Dec 2023 13:48:53 +0100 Date: Sat, 30 Dec 2023 13:48:53 +0100 (CET) From: "J.A. Bezemer" X-X-Sender: costar@wormhole.robuust.nl To: linux-gpio@vger.kernel.org Subject: [libgpiod][PATCH] line-config.c: Fix library enum used for kernel flags bitfield Message-ID: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Library enum was used to sanitize kernel flags. This will probably not have broken any "correct" usage: it would clear GPIO_V2_LINE_FLAG_USED, which is not used on setting, and GPIO_V2_LINE_FLAG_ACTIVE_LOW, which is set correctly later on. Signed-off-by: Anne Bezemer --- lib/line-config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/line-config.c b/lib/line-config.c index 2749a2a..9bf7734 100644 --- a/lib/line-config.c +++ b/lib/line-config.c @@ -381,18 +381,18 @@ static uint64_t make_kernel_flags(struct gpiod_line_settings *settings) case GPIOD_LINE_EDGE_FALLING: flags |= (GPIO_V2_LINE_FLAG_EDGE_FALLING | GPIO_V2_LINE_FLAG_INPUT); - flags &= ~GPIOD_LINE_DIRECTION_OUTPUT; + flags &= ~GPIO_V2_LINE_FLAG_OUTPUT; break; case GPIOD_LINE_EDGE_RISING: flags |= (GPIO_V2_LINE_FLAG_EDGE_RISING | GPIO_V2_LINE_FLAG_INPUT); - flags &= ~GPIOD_LINE_DIRECTION_OUTPUT; + flags &= ~GPIO_V2_LINE_FLAG_OUTPUT; break; case GPIOD_LINE_EDGE_BOTH: flags |= (GPIO_V2_LINE_FLAG_EDGE_FALLING | GPIO_V2_LINE_FLAG_EDGE_RISING | GPIO_V2_LINE_FLAG_INPUT); - flags &= ~GPIOD_LINE_DIRECTION_OUTPUT; + flags &= ~GPIO_V2_LINE_FLAG_OUTPUT; break; default: break;