mbox series

[v2,00/17] Improvements for Tegra I2C driver

Message ID 20200901211102.11072-1-digetx@gmail.com
Headers show
Series Improvements for Tegra I2C driver | expand

Message

Dmitry Osipenko Sept. 1, 2020, 9:10 p.m. UTC
Hello!

This series performs a small refactoring of the Tegra I2C driver code and
hardens the atomic-transfer mode.

Changelog:

v2: - Cleaned more messages in the "Clean up messages in the code" patch.

    - The error code of reset_control_reset() is checked now.

    - Added these new patches to clean up couple more things:

        i2c: tegra: Check errors for both positive and negative values
        i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load()
        i2c: tegra: Remove unnecessary whitespaces and newlines
        i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear()
        i2c: tegra: Improve driver module description

Dmitry Osipenko (17):
  i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer
  i2c: tegra: Add missing newline before returns
  i2c: tegra: Clean up messages in the code
  i2c: tegra: Don't ignore tegra_i2c_flush_fifos() error
  i2c: tegra: Use reset_control_reset()
  i2c: tegra: Improve formatting of function variables
  i2c: tegra: Use dev_err_probe()
  i2c: tegra: Runtime PM always available on Tegra
  i2c: tegra: Clean up probe function
  i2c: tegra: Drop '_timeout' from wait/poll function names
  i2c: tegra: Remove likely/unlikely from the code
  i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg()
  i2c: tegra: Check errors for both positive and negative values
  i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load()
  i2c: tegra: Remove unnecessary whitespaces and newlines
  i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear()
  i2c: tegra: Improve driver module description

 drivers/i2c/busses/i2c-tegra.c | 686 ++++++++++++++++++---------------
 1 file changed, 379 insertions(+), 307 deletions(-)

Comments

Dmitry Osipenko Sept. 1, 2020, 9:37 p.m. UTC | #1
02.09.2020 00:23, Andy Shevchenko пишет:
> 
> 
> On Wednesday, September 2, 2020, Dmitry Osipenko <digetx@gmail.com
> <mailto:digetx@gmail.com>> wrote:
> 
>     Use lowercase and consistent wording for all messages in the code.
> 
> 
> Why? DMA is an abbreviation and reads in capital letters. FWIW, I don’t
> like bending English grammar.

The idea is to make messages to look less "noisy" in a log. Although, I
don't have strong preference in regards to the style and keeping the
capitalization of abbreviations would be okay too. All I really care
about is to make all messages to use one common style.

I'll consider returning the capitalization in the next revision, thank
you for the input!