| Message ID | 20201201092924.112461-1-miaoqinglang@huawei.com |
|---|---|
| Headers | show |
| Series | i2c: fix reference leak when pm_runtime_get_sync fails | expand |
On Tue, Dec 01, 2020 at 05:29:24PM +0800, Qinglang Miao wrote: > pm_runtime_get_sync will increment the PM reference count > even failed. Forgetting to putting operation will result > in a reference leak here. > > Replace it with pm_runtime_resume_and_get to keep usage > counter balanced. > > BTW, pm_runtime_resume_and_get is introduced in v5.10-rc5 as > dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get > to dealwith usage counter") > > Qinglang Miao (8): > i2c: cadence: fix reference leak when pm_runtime_get_sync fails > i2c: img-scb: fix reference leak when pm_runtime_get_sync fails > i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails > i2c: imx: fix reference leak when pm_runtime_get_sync fails > i2c: omap: fix reference leak when pm_runtime_get_sync fails > i2c: sprd: fix reference leak when pm_runtime_get_sync fails > i2c: stm32f7: fix reference leak when pm_runtime_get_sync fails > i2c: xiic: fix reference leak when pm_runtime_get_sync fails I applied this series now to for-next, thanks!
pm_runtime_get_sync will increment the PM reference count even failed. Forgetting to putting operation will result in a reference leak here. Replace it with pm_runtime_resume_and_get to keep usage counter balanced. BTW, pm_runtime_resume_and_get is introduced in v5.10-rc5 as dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to dealwith usage counter") Qinglang Miao (8): i2c: cadence: fix reference leak when pm_runtime_get_sync fails i2c: img-scb: fix reference leak when pm_runtime_get_sync fails i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails i2c: imx: fix reference leak when pm_runtime_get_sync fails i2c: omap: fix reference leak when pm_runtime_get_sync fails i2c: sprd: fix reference leak when pm_runtime_get_sync fails i2c: stm32f7: fix reference leak when pm_runtime_get_sync fails i2c: xiic: fix reference leak when pm_runtime_get_sync fails drivers/i2c/busses/i2c-cadence.c | 4 ++-- drivers/i2c/busses/i2c-img-scb.c | 4 ++-- drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +- drivers/i2c/busses/i2c-imx.c | 4 ++-- drivers/i2c/busses/i2c-omap.c | 8 ++++---- drivers/i2c/busses/i2c-sprd.c | 4 ++-- drivers/i2c/busses/i2c-stm32f7.c | 12 ++++++------ drivers/i2c/busses/i2c-xiic.c | 4 ++-- 8 files changed, 21 insertions(+), 21 deletions(-)