mbox series

[v2,0/2] resolve read hystersis return invalid argument issue for hid sensors

Message ID 20210201054921.18214-1-xiang.ye@intel.com
Headers show
Series resolve read hystersis return invalid argument issue for hid sensors | expand

Message

Ye Xiang Feb. 1, 2021, 5:49 a.m. UTC
This patch series move get sensitivity attribute to common layer and
resolve read hystersis return invalid argument issue for hid sensors als,
incli-3d, rotation, and press on intel ISH Platform.

---
v2:
  - separate the add relative sensitivity patch to the next patch series.

Ye Xiang (2):
  iio: hid-sensors: Move get sensitivity attribute to hid-sensor-common
  hid-sensors: Add more data fields for sensitivity checking

 drivers/iio/accel/hid-sensor-accel-3d.c       | 23 ++++++-------
 .../hid-sensors/hid-sensor-attributes.c       | 17 +++++++++-
 drivers/iio/gyro/hid-sensor-gyro-3d.c         | 19 ++++-------
 drivers/iio/humidity/hid-sensor-humidity.c    | 16 ++++------
 drivers/iio/light/hid-sensor-als.c            | 20 +++++-------
 drivers/iio/light/hid-sensor-prox.c           | 27 +++++-----------
 drivers/iio/magnetometer/hid-sensor-magn-3d.c | 32 ++++++-------------
 drivers/iio/orientation/hid-sensor-incl-3d.c  | 20 +++++-------
 drivers/iio/orientation/hid-sensor-rotation.c | 24 ++++++--------
 .../position/hid-sensor-custom-intel-hinge.c  | 20 ++++--------
 drivers/iio/pressure/hid-sensor-press.c       | 20 +++++-------
 .../iio/temperature/hid-sensor-temperature.c  | 16 ++++------
 drivers/rtc/rtc-hid-sensor-time.c             |  4 ++-
 include/linux/hid-sensor-hub.h                |  4 ++-
 14 files changed, 111 insertions(+), 151 deletions(-)

Comments

Jonathan Cameron Feb. 6, 2021, 4:39 p.m. UTC | #1
On Mon,  1 Feb 2021 13:49:19 +0800
Ye Xiang <xiang.ye@intel.com> wrote:

> This patch series move get sensitivity attribute to common layer and

> resolve read hystersis return invalid argument issue for hid sensors als,

> incli-3d, rotation, and press on intel ISH Platform.

Hi Ye Xiang


Series looks good to me.

Now this series touches a few bits of code outside of IIO so ideally
I'm looking for acks from:
@ Jiri for the header
@ Alessandro / Alexandre (+CC) for RTC

Both changes are trivial but might cause them some noise in other work
going on in their subsystems.

For reference:
https://lore.kernel.org/linux-iio/20210201054921.18214-2-xiang.ye@intel.com/

Thanks,

Jonathan

> 

> ---

> v2:

>   - separate the add relative sensitivity patch to the next patch series.

> 

> Ye Xiang (2):

>   iio: hid-sensors: Move get sensitivity attribute to hid-sensor-common

>   hid-sensors: Add more data fields for sensitivity checking

> 

>  drivers/iio/accel/hid-sensor-accel-3d.c       | 23 ++++++-------

>  .../hid-sensors/hid-sensor-attributes.c       | 17 +++++++++-

>  drivers/iio/gyro/hid-sensor-gyro-3d.c         | 19 ++++-------

>  drivers/iio/humidity/hid-sensor-humidity.c    | 16 ++++------

>  drivers/iio/light/hid-sensor-als.c            | 20 +++++-------

>  drivers/iio/light/hid-sensor-prox.c           | 27 +++++-----------

>  drivers/iio/magnetometer/hid-sensor-magn-3d.c | 32 ++++++-------------

>  drivers/iio/orientation/hid-sensor-incl-3d.c  | 20 +++++-------

>  drivers/iio/orientation/hid-sensor-rotation.c | 24 ++++++--------

>  .../position/hid-sensor-custom-intel-hinge.c  | 20 ++++--------

>  drivers/iio/pressure/hid-sensor-press.c       | 20 +++++-------

>  .../iio/temperature/hid-sensor-temperature.c  | 16 ++++------

>  drivers/rtc/rtc-hid-sensor-time.c             |  4 ++-

>  include/linux/hid-sensor-hub.h                |  4 ++-

>  14 files changed, 111 insertions(+), 151 deletions(-)

>
Jonathan Cameron Feb. 18, 2021, 1:17 p.m. UTC | #2
On Mon,  1 Feb 2021 13:49:19 +0800
Ye Xiang <xiang.ye@intel.com> wrote:

> This patch series move get sensitivity attribute to common layer and

> resolve read hystersis return invalid argument issue for hid sensors als,

> incli-3d, rotation, and press on intel ISH Platform.


Given Jiri was fine with the follow up series, I'm going to guess he
just missed this one and apply it with out his explicit ack.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if they can find anything we missed.

Thanks,

Jonathan

> 

> ---

> v2:

>   - separate the add relative sensitivity patch to the next patch series.

> 

> Ye Xiang (2):

>   iio: hid-sensors: Move get sensitivity attribute to hid-sensor-common

>   hid-sensors: Add more data fields for sensitivity checking

> 

>  drivers/iio/accel/hid-sensor-accel-3d.c       | 23 ++++++-------

>  .../hid-sensors/hid-sensor-attributes.c       | 17 +++++++++-

>  drivers/iio/gyro/hid-sensor-gyro-3d.c         | 19 ++++-------

>  drivers/iio/humidity/hid-sensor-humidity.c    | 16 ++++------

>  drivers/iio/light/hid-sensor-als.c            | 20 +++++-------

>  drivers/iio/light/hid-sensor-prox.c           | 27 +++++-----------

>  drivers/iio/magnetometer/hid-sensor-magn-3d.c | 32 ++++++-------------

>  drivers/iio/orientation/hid-sensor-incl-3d.c  | 20 +++++-------

>  drivers/iio/orientation/hid-sensor-rotation.c | 24 ++++++--------

>  .../position/hid-sensor-custom-intel-hinge.c  | 20 ++++--------

>  drivers/iio/pressure/hid-sensor-press.c       | 20 +++++-------

>  .../iio/temperature/hid-sensor-temperature.c  | 16 ++++------

>  drivers/rtc/rtc-hid-sensor-time.c             |  4 ++-

>  include/linux/hid-sensor-hub.h                |  4 ++-

>  14 files changed, 111 insertions(+), 151 deletions(-)

>