| Message ID | 20210207214908.79573-1-roderick@gaikai.com |
|---|---|
| Headers | show |
| Series | HID: new driver for PS5 'DualSense' controller | expand |
On Sun, Feb 7, 2021 at 10:49 PM Roderick Colenbrander <roderick@gaikai.com> wrote: > > From: Roderick Colenbrander <roderick.colenbrander@sony.com> > > Hi, > > This is an updated version with a few small changes suggested by > by Barnabás and Benjamin. It is mostly a few additional checks and > a few checkpath related changes. > > Changes since v5: > - Fixed a couple of checkpath warnings. > - Renamed firmware_/hardware_version show functions. > - Used DEVICE_ATTR_RO for firmware/hardware_version show functions. > - Changed player_ids array to static const. > - Added error check for power_supply_powers. > - Ensured devm_kasprintf return value is checked. Thanks a lot for the quick resubmission (and for Barnabás final review). I double checked that Baranabás' comments were addressed and added the rev-b to the series. The series is now pushed to for-5.12/playstation. Cheers, Benjamin > > Thanks, > > Roderick Colenbrander > Sony Interactive Entertainment, LLC > > Roderick Colenbrander (13): > HID: playstation: initial DualSense USB support. > HID: playstation: use DualSense MAC address as unique identifier. > HID: playstation: add DualSense battery support. > HID: playstation: add DualSense touchpad support. > HID: playstation: add DualSense accelerometer and gyroscope support. > HID: playstation: track devices in list. > HID: playstation: add DualSense Bluetooth support. > HID: playstation: add DualSense classic rumble support. > HID: playstation: add DualSense lightbar support > HID: playstation: add microphone mute support for DualSense. > HID: playstation: add DualSense player LEDs support. > HID: playstation: DualSense set LEDs to default player id. > HID: playstation: report DualSense hardware and firmware version. > > MAINTAINERS | 6 + > drivers/hid/Kconfig | 21 + > drivers/hid/Makefile | 1 + > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-playstation.c | 1504 +++++++++++++++++++++++++++++++++ > 5 files changed, 1533 insertions(+) > create mode 100644 drivers/hid/hid-playstation.c > > -- > 2.26.2 >
On Thu, Feb 11, 2021 at 8:07 AM Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > > On Sun, Feb 7, 2021 at 10:49 PM Roderick Colenbrander > <roderick@gaikai.com> wrote: > > > > From: Roderick Colenbrander <roderick.colenbrander@sony.com> > > > > Hi, > > > > This is an updated version with a few small changes suggested by > > by Barnabás and Benjamin. It is mostly a few additional checks and > > a few checkpath related changes. > > > > Changes since v5: > > - Fixed a couple of checkpath warnings. > > - Renamed firmware_/hardware_version show functions. > > - Used DEVICE_ATTR_RO for firmware/hardware_version show functions. > > - Changed player_ids array to static const. > > - Added error check for power_supply_powers. > > - Ensured devm_kasprintf return value is checked. > > Thanks a lot for the quick resubmission (and for Barnabás final review). > > I double checked that Baranabás' comments were addressed and added the > rev-b to the series. > > The series is now pushed to for-5.12/playstation. > > Cheers, > Benjamin > Great news! Thanks everyone for their help. Thanks, Roderick
From: Roderick Colenbrander <roderick.colenbrander@sony.com> Hi, This is an updated version with a few small changes suggested by by Barnabás and Benjamin. It is mostly a few additional checks and a few checkpath related changes. Changes since v5: - Fixed a couple of checkpath warnings. - Renamed firmware_/hardware_version show functions. - Used DEVICE_ATTR_RO for firmware/hardware_version show functions. - Changed player_ids array to static const. - Added error check for power_supply_powers. - Ensured devm_kasprintf return value is checked. Thanks, Roderick Colenbrander Sony Interactive Entertainment, LLC Roderick Colenbrander (13): HID: playstation: initial DualSense USB support. HID: playstation: use DualSense MAC address as unique identifier. HID: playstation: add DualSense battery support. HID: playstation: add DualSense touchpad support. HID: playstation: add DualSense accelerometer and gyroscope support. HID: playstation: track devices in list. HID: playstation: add DualSense Bluetooth support. HID: playstation: add DualSense classic rumble support. HID: playstation: add DualSense lightbar support HID: playstation: add microphone mute support for DualSense. HID: playstation: add DualSense player LEDs support. HID: playstation: DualSense set LEDs to default player id. HID: playstation: report DualSense hardware and firmware version. MAINTAINERS | 6 + drivers/hid/Kconfig | 21 + drivers/hid/Makefile | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-playstation.c | 1504 +++++++++++++++++++++++++++++++++ 5 files changed, 1533 insertions(+) create mode 100644 drivers/hid/hid-playstation.c