From patchwork Sat Oct 15 17:30:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 615339 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0387EC43217 for ; Sat, 15 Oct 2022 17:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbiJORac (ORCPT ); Sat, 15 Oct 2022 13:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiJORab (ORCPT ); Sat, 15 Oct 2022 13:30:31 -0400 Received: from mail-4317.proton.ch (mail-4317.proton.ch [185.70.43.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62E09252A7; Sat, 15 Oct 2022 10:30:27 -0700 (PDT) Date: Sat, 15 Oct 2022 17:30:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1665855025; x=1666114225; bh=DkDUqYsIo4WD6IeoCvcUlhuchiJ68MTUFWYeBqoljY4=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID; b=Sw/PwmuQCDhWwZXq8NvwyUot9fBwp5Y6usJuOMs9v147/fLo+mUb1xDf1TCPusCv2 ruD9+xzlnNAgyXJOE+ubRWXf5jB6ujp1ZkvC7p/y0u458hgs19v/L3q4am7/A9aZPR JCbfowjoJSzw8uOZwJUuEIFZ26EWbUpffIgs1U3I= To: caleb@connolly.tech From: Caleb Connolly Cc: krzysztof.kozlowski@linaro.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Andy Gross , Bjorn Andersson , devicetree@vger.kernel.org, Dmitry Torokhov , Jeff LaBundy , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Rob Herring , Tom Rix Subject: [PATCH v7 0/2] input: introduce support for Qualcomm SPMI haptics Message-ID: <20221015172915.1436236-1-caleb@connolly.tech> Feedback-ID: 10753939:user:proton MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This series introduces a driver for the SPMI haptics hardware block found in Qualcomm PMICs. SPMI haptics support LRA (Linear Resonant Actuator) style haptics, as well as ERM (Eccentric Rotating Mass). It also supports several modes of driving the haptics, e.g. by loading the pattern to play into an internal buffer, or using PWM. More information about the hardware can be found here: https://gitlab.com/sdm845-mainline/linux/-/wikis/PMI8998-QPNP-Haptics This driver has been written based on downstream sources as no public documentation is available. It includes initial support for LRA haptics in buffer mode, this combination seems to be the most common and will enable haptics on the OnePlus 6 and 6T, PocoPhone F1, OnePlus 5 and several other Qualcomm devices with mainline kernel support. The driver is implemented using the ff-memless (forcefeedback) input framework and makes an attempt to control the strength of vibration relative to the magnitude set from userspace. Changes since v6: - Apply Krzysztof's dt-bindings suggestions - Rename qcom,wave-play-rate-us to qcom,wave-play-duration-us and add a comment explaining the name change compared to downstream. - Add COMPILE_TEST to kconfig Changes since v5: - Fix dt schema errors - Fix typo (thanks Vincent) Changes since v4: - Significant rewrite and cleanup - switch to dev_err_probe() - Run through clang-format Changes since v3: - Adjust example DTS to avoid creating new warnings in dt_binding_check - Address warnings from kernel test robot. Changes since v2: - Addressed Rob's comments on dt-bindings (I'm not sure what to do about the pmic compatible?) - Fixed some typos Changes since v1: - Replace old QPNP naming with SPMI - Address Bjorn's comments on the driver, various style and code cleanups - Address Bjorn's comments on the DT bindings and DTS - Pickup patches from Joel and Jami to enable haptics on the OnePlus 5 and Poco F1. Caleb Connolly (2): dt-bindings: input: document Qualcomm PMI8998 haptics driver input: add Qualcomm SPMI haptics driver .../bindings/input/qcom,pmi8998-haptics.yaml | 73 ++ drivers/input/misc/Kconfig | 15 + drivers/input/misc/Makefile | 1 + drivers/input/misc/qcom-pmi8998-haptics.c | 690 ++++++++++++++++++ 4 files changed, 779 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/qcom,pmi8998-haptics.yaml create mode 100644 drivers/input/misc/qcom-pmi8998-haptics.c Reviewed-by: Krzysztof Kozlowski --- 2.38.0