mbox series

[0/2] HID-BPF: Kconfig fix

Message ID 20221130101021.1868764-1-benjamin.tissoires@redhat.com
Headers show
Series HID-BPF: Kconfig fix | expand

Message

Benjamin Tissoires Nov. 30, 2022, 10:10 a.m. UTC 
Hi,

As discussed in [1], we need to add some more dependencies to HID-BPF in
the Kconfig. This way, when fmod_ret will be available on arm64, HID-BPF
will get enabled automatically.

Jon, would you mind giving a shot at that patch on your test system and
confirm the error disappeard?

Cheers,
Benjamin



[1] https://lore.kernel.org/r/CABRcYmKyRchQhabi1Vd9RcMQFCcb=EtWyEbFDFRTc-L-U8WhgA@mail.gmail.com

Benjamin Tissoires (2):
  HID: bpf: enforce HID_BPF dependencies
  selftests: hid: ensures we have the proper requirements in config

 drivers/hid/bpf/Kconfig            | 4 +++-
 tools/testing/selftests/hid/config | 2 ++
 2 files changed, 5 insertions(+), 1 deletion(-)

Comments

Florent Revest Nov. 30, 2022, 11:19 a.m. UTC | #1 
On Wed, Nov 30, 2022 at 11:10 AM Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
>
> Hi,
>
> As discussed in [1], we need to add some more dependencies to HID-BPF in
> the Kconfig. This way, when fmod_ret will be available on arm64, HID-BPF
> will get enabled automatically.
>
> Jon, would you mind giving a shot at that patch on your test system and
> confirm the error disappeard?
>
> Cheers,
> Benjamin
>
>
>
> [1] https://lore.kernel.org/r/CABRcYmKyRchQhabi1Vd9RcMQFCcb=EtWyEbFDFRTc-L-U8WhgA@mail.gmail.com
>
> Benjamin Tissoires (2):
>   HID: bpf: enforce HID_BPF dependencies
>   selftests: hid: ensures we have the proper requirements in config
>
>  drivers/hid/bpf/Kconfig            | 4 +++-
>  tools/testing/selftests/hid/config | 2 ++
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.38.1

Reviewed-by: Florent Revest <revest@chromium.org>
Jon Hunter Dec. 1, 2022, 10:08 a.m. UTC | #2 
Hi Benjamin,

On 30/11/2022 10:10, Benjamin Tissoires wrote:
> Hi,
> 
> As discussed in [1], we need to add some more dependencies to HID-BPF in
> the Kconfig. This way, when fmod_ret will be available on arm64, HID-BPF
> will get enabled automatically.
> 
> Jon, would you mind giving a shot at that patch on your test system and
> confirm the error disappeard?

Yes will test today. Thanks!

Jon
Jon Hunter Dec. 1, 2022, 1:13 p.m. UTC | #3 
On 30/11/2022 10:10, Benjamin Tissoires wrote:
> As mentioned in the link below, having JIT and BPF is not enough to
> have fmod_ret and error injection APIs. This resolves the error that
> happens on a system without tracing enabled when hid-bpf tries to
> load itself.
> 
> Link: https://lore.kernel.org/r/CABRcYmKyRchQhabi1Vd9RcMQFCcb=EtWyEbFDFRTc-L-U8WhgA@mail.gmail.com
> Fixes: f5c27da4e3c8 ("HID: initial BPF implementation")
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>   drivers/hid/bpf/Kconfig | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/bpf/Kconfig b/drivers/hid/bpf/Kconfig
> index 298634fc3335..498232f9faa9 100644
> --- a/drivers/hid/bpf/Kconfig
> +++ b/drivers/hid/bpf/Kconfig
> @@ -4,7 +4,9 @@ menu "HID-BPF support"
>   config HID_BPF
>   	bool "HID-BPF support"
>   	default HID_SUPPORT
> -	depends on BPF && BPF_SYSCALL
> +	depends on BPF && BPF_SYSCALL && \
> +		   DYNAMIC_FTRACE_WITH_DIRECT_CALLS && \
> +		   FUNCTION_ERROR_INJECTION
>   	help
>   	This option allows to support eBPF programs on the HID subsystem.
>   	eBPF programs can fix HID devices in a lighter way than a full


This fixes it for me!

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon