| Message ID | 20230201152128.614439-1-manuel.traut@mt.com |
|---|---|
| Headers | show |
| Series | input: pwm-beeper: add feature to set volume level | expand |
On 01/02/2023 16:21, Manuel Traut wrote: > Adds an array of supported volume levels and a default volume level. Adds -> Add > > Signed-off-by: Manuel Traut <manuel.traut@mt.com> > --- > .../devicetree/bindings/input/pwm-beeper.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > Thank you for your patch. There is something to discuss/improve. > diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > index 1ebc3a46d934..6599e28ba5e6 100644 > --- a/Documentation/devicetree/bindings/input/pwm-beeper.yaml > +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml > @@ -25,6 +25,21 @@ properties: > beeper-hz: > description: bell frequency in Hz > > + volume-levels-bp: > + description: > > + Array of PWM duty cycle values that correspond to > + linear volume levels. These need to be in the range of > + 0 to 5000, while 0 means 0% duty cycle (mute) and 5000 > + means 50% duty cycle (max volume). Is range 0-5000 limitation of the device? If so, this should not be free-form text, but "maximum: 5000" (minimum is 0 anyway). > + Please note that the actual volume of most beepers is > + highly non-linear, which means that low volume levels > + are probably somewhere in the range of 10 to 300 (0.1-3% > + duty cycle). Best regards, Krzysztof
This implements volume control for the pwm-beeper via sysfs. The first patch changes the devicetree documentation from txt to yaml. The original author of the volume support patches is Frieder Schrempf. I picked them from this [0] LKML thread from 2017. Since it looks like his email address changed in the meantime I changed it in the Author and Signed-off-by, as well as in the copyright statements. I did some minor changes on the patches that they apply and work with the current kernel. checkpatch still reports warnings regarding the changes: * from txt to yaml of the devicetree documentation: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? WARNING: DT binding docs and includes should be a separate patch. * and the introduction of Documentation/ABI/testing/sysfs-devices-pwm-beeper: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? I am not sure how to fix these warnings. So any suggestion would be helpful. Changes since v9 [1]: * [1/4] dt-bindings: input: pwm-beeper: Convert txt bindings to yaml * added Reviewed-by tag from Rob Herring * [3/4] dt-bindings: input: pwm-beeper: add volume * Added missing unit specifier in examples Changes since v8 [2]: * yaml devicetree doc: * reordered patches to introduce dt-bindings before usage * drop quotes from $id and $schema references * amp-supply: simplify description * examples: remove unneeded amp device node * use -bp suffix for volume-levels and default-volume * specify default-volume as value instead of pointer into volume-array * fixup to work with new dt-binding specification * squash patches as suggested by Frieder Changes since v7 [3]: * yaml devicetree doc: * Use shorter subject * Fix indent * Use units * 'make dt_binding_check' succeeds * 'make dtbs_check' does not report new errors * Reworded commit messages avoiding 'this patch' phrase * Fix wrong indent in [PATCH 5/5 v7] input: pwm-beeper: handle module unloading properly * Use current date in Documentation/ABI/testing/sysfs-devices-pwm-beeper * Hopefully fixed my setup that * mails are CC'ed correctly * patches are sent as replies to the cover letter Changes since v6 [4]: * Convert devicetree binding documentation from txt to yaml * Use DEVICE_ATTR_[RO|RW] properly * Change Frieders Mail address * Added Signed-off and Tested-by statements * Fix module unloading Frieder Schrempf (2): input: pwm-beeper: add feature to set volume via sysfs input: pwm-beeper: set volume levels by devicetree Manuel Traut (2): dt-bindings: input: pwm-beeper: Convert txt bindings to yaml dt-bindings: input: pwm-beeper: add volume .../ABI/testing/sysfs-devices-pwm-beeper | 17 +++ .../devicetree/bindings/input/pwm-beeper.txt | 24 ---- .../devicetree/bindings/input/pwm-beeper.yaml | 56 ++++++++ drivers/input/misc/pwm-beeper.c | 135 +++++++++++++++++- 4 files changed, 206 insertions(+), 26 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-devices-pwm-beeper delete mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.txt create mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.yaml [0] https://lore.kernel.org/all/cover.1487323753.git.frieder.schrempf@exceet.de/ [1] https://lore.kernel.org/lkml/20230130135650.1407156-1-manuel.traut@mt.com/ [2] https://lore.kernel.org/lkml/20230126091825.220646-1-manuel.traut@mt.com/ [3] https://lore.kernel.org/all/Y9AIq3cSNzI9T%2FdU@mt.com/ [4] https://lkml.org/lkml/2023/1/24/379