| Message ID | 20240126-x13s-touchscreen-v2-0-5374ccc9e10d@quicinc.com |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sc8280xp-x13s: Enable touchscreen | expand |
On Fri, Jan 26, 2024 at 08:41:38AM -0800, Bjorn Andersson wrote: > Some I2C HID devices has a reset pin and requires that some specified > time elapses after this reset pin is deasserted, before communication > with the device is attempted. > > The Linux implementation is looking for these in the "reset-gpios" and > "post-reset-deassert-delay-ms" properties already, so use these property > names. > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- > Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml > index 138caad96a29..f07ff4cb3d26 100644 > --- a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml > +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml > @@ -50,6 +50,12 @@ properties: > description: Time required by the device after enabling its regulators > or powering it on, before it is ready for communication. > > + post-reset-deassert-delay-ms: > + description: Time required by the device after reset has been deasserted, > + before it is ready for communication. You forgot to remove the now obsolete comment from the HID driver that I mentioned. > + > + reset-gpios: true > + > touchscreen-inverted-x: true > > touchscreen-inverted-y: true Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
This documents and defines the necessary properties for the I2C HID-based touchscreen found in some SKUs of the Lenovo Thinkpad X13s to work. Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- Changes in v2: - Dropped output-high from &ts0_default, to avoid bouncing the reset line unnecessarily - Link to v1: https://lore.kernel.org/r/20240125-x13s-touchscreen-v1-0-ab8c882def9c@quicinc.com --- Bjorn Andersson (2): dt-bindings: HID: i2c-hid: Document reset-related properties arm64: dts: qcom: sc8280xp-x13s: Fix/enable touchscreen Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 7 +++++-- 2 files changed, 11 insertions(+), 2 deletions(-) --- base-commit: 8bf1262c53f50fa91fe15d01e5ef5629db55313c change-id: 20240125-x13s-touchscreen-48012ff3c24e Best regards,