mbox series

[v2,0/5] HID: playstation: DS4: LED bugfix, third-party gamepad support

Message ID 20240207163647.15792-1-max@enpas.org
Headers show
Series HID: playstation: DS4: LED bugfix, third-party gamepad support | expand

Message

Max Staudt Feb. 7, 2024, 4:36 p.m. UTC
Dear hid-playstation maintainers,

Here is v2 of my patch series, with the discussed changes.


Differences since v1:
 - Dropped patch for 7545:0104 (SZ-MYPOWER controllers)
 - Dropped patch for DS4 clones without a MAC address on USB
 - Changed hid_err() to hid_warn() where things are no longer fatal
 - Simplified goto as return in minimal report parsing


I've included the patch to simplify the PID/VID mapping to controller
types, since the previous discussion made it sound useful for future
support of second-party controllers. Please feel free to drop it if you
don't think it's relevant now.


Thanks for your feedback!

Max


Patches in this series:
  [PATCH v2 1/5] HID: playstation: DS4: Fix LED blinking
  [PATCH v2 2/5] HID: playstation: DS4: Don't fail on FW/HW version
  [PATCH v2 3/5] HID: playstation: DS4: Don't fail on calibration data
  [PATCH v2 4/5] HID: playstation: DS4: Parse minimal report 0x01
  [PATCH v2 5/5] HID: playstation: Simplify device type ID

Comments

Jiri Kosina Feb. 27, 2024, 4:40 p.m. UTC | #1
On Thu, 8 Feb 2024, Max Staudt wrote:

> Dear hid-playstation maintainers,
> 
> Here is v2 of my patch series, with the discussed changes.
> 
> 
> Differences since v1:
>  - Dropped patch for 7545:0104 (SZ-MYPOWER controllers)
>  - Dropped patch for DS4 clones without a MAC address on USB
>  - Changed hid_err() to hid_warn() where things are no longer fatal
>  - Simplified goto as return in minimal report parsing
> 
> 
> I've included the patch to simplify the PID/VID mapping to controller
> types, since the previous discussion made it sound useful for future
> support of second-party controllers. Please feel free to drop it if you
> don't think it's relevant now.
> 
> 
> Thanks for your feedback!
> 
> Max
> 
> 
> Patches in this series:
>   [PATCH v2 1/5] HID: playstation: DS4: Fix LED blinking
>   [PATCH v2 2/5] HID: playstation: DS4: Don't fail on FW/HW version
>   [PATCH v2 3/5] HID: playstation: DS4: Don't fail on calibration data
>   [PATCH v2 4/5] HID: playstation: DS4: Parse minimal report 0x01
>   [PATCH v2 5/5] HID: playstation: Simplify device type ID

Roderick, any word on this series please?

Thanks,
Jiri Kosina April 3, 2024, 6:11 p.m. UTC | #2
On Tue, 27 Feb 2024, Jiri Kosina wrote:

> > Dear hid-playstation maintainers,
> > 
> > Here is v2 of my patch series, with the discussed changes.
> > 
> > 
> > Differences since v1:
> >  - Dropped patch for 7545:0104 (SZ-MYPOWER controllers)
> >  - Dropped patch for DS4 clones without a MAC address on USB
> >  - Changed hid_err() to hid_warn() where things are no longer fatal
> >  - Simplified goto as return in minimal report parsing
> > 
> > 
> > I've included the patch to simplify the PID/VID mapping to controller
> > types, since the previous discussion made it sound useful for future
> > support of second-party controllers. Please feel free to drop it if you
> > don't think it's relevant now.
> > 
> > 
> > Thanks for your feedback!
> > 
> > Max
> > 
> > 
> > Patches in this series:
> >   [PATCH v2 1/5] HID: playstation: DS4: Fix LED blinking
> >   [PATCH v2 2/5] HID: playstation: DS4: Don't fail on FW/HW version
> >   [PATCH v2 3/5] HID: playstation: DS4: Don't fail on calibration data
> >   [PATCH v2 4/5] HID: playstation: DS4: Parse minimal report 0x01
> >   [PATCH v2 5/5] HID: playstation: Simplify device type ID
> 
> Roderick, any word on this series please?

Roderick, please speak up now, or I'll queue this as-is for 6.10 in the 
coming few days. Thanks,
Roderick Colenbrander April 3, 2024, 7:24 p.m. UTC | #3
On Wed, Apr 3, 2024 at 11:11 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 27 Feb 2024, Jiri Kosina wrote:
>
> > > Dear hid-playstation maintainers,
> > >
> > > Here is v2 of my patch series, with the discussed changes.
> > >
> > >
> > > Differences since v1:
> > >  - Dropped patch for 7545:0104 (SZ-MYPOWER controllers)
> > >  - Dropped patch for DS4 clones without a MAC address on USB
> > >  - Changed hid_err() to hid_warn() where things are no longer fatal
> > >  - Simplified goto as return in minimal report parsing
> > >
> > >
> > > I've included the patch to simplify the PID/VID mapping to controller
> > > types, since the previous discussion made it sound useful for future
> > > support of second-party controllers. Please feel free to drop it if you
> > > don't think it's relevant now.
> > >
> > >
> > > Thanks for your feedback!
> > >
> > > Max
> > >
> > >
> > > Patches in this series:
> > >   [PATCH v2 1/5] HID: playstation: DS4: Fix LED blinking
> > >   [PATCH v2 2/5] HID: playstation: DS4: Don't fail on FW/HW version
> > >   [PATCH v2 3/5] HID: playstation: DS4: Don't fail on calibration data
> > >   [PATCH v2 4/5] HID: playstation: DS4: Parse minimal report 0x01
> > >   [PATCH v2 5/5] HID: playstation: Simplify device type ID
> >
> > Roderick, any word on this series please?
>
> Roderick, please speak up now, or I'll queue this as-is for 6.10 in the
> coming few days. Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

Hi Jiri,

Sorry for late reply, let's merge it. There are maybe 1-2 nitpicky
things I forgot to email about, but I can deal with those later if I
feel it is needed down the road.

Thanks,
Roderick
Jiri Kosina April 3, 2024, 7:54 p.m. UTC | #4
On Wed, 3 Apr 2024, Roderick Colenbrander wrote:

> > Roderick, please speak up now, or I'll queue this as-is for 6.10 in the
> > coming few days. Thanks,
> 
> Hi Jiri,
> 
> Sorry for late reply, let's merge it. There are maybe 1-2 nitpicky
> things I forgot to email about, but I can deal with those later if I
> feel it is needed down the road.

Welcome back! :-)

Now queued in hid.git#for-6.10/playstation. Thanks,
Max Staudt April 3, 2024, 11:39 p.m. UTC | #5
On 4/3/24 21:54, Jiri Kosina wrote:
> On Wed, 3 Apr 2024, Roderick Colenbrander wrote:
> 
>>> Roderick, please speak up now, or I'll queue this as-is for 6.10 in the
>>> coming few days. Thanks,
>>
>> Hi Jiri,
>>
>> Sorry for late reply, let's merge it. There are maybe 1-2 nitpicky
>> things I forgot to email about, but I can deal with those later if I
>> feel it is needed down the road.
> 
> Welcome back! :-)
> 
> Now queued in hid.git#for-6.10/playstation. Thanks,


Thank you both!


Max