diff mbox series

[RESEND,1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings

Message ID 20210204123902.18813-1-joe_hung@ilitek.com
State New
Headers show
Series [RESEND,1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings | expand

Commit Message

Joe Hung Feb. 4, 2021, 12:39 p.m. UTC
Add binding documentation for ILITEK touch devices.

Signed-off-by: Joe Hung <joe_hung@ilitek.com>
---
 .../input/touchscreen/ilitek_ts_i2c.txt       | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt

Comments

Joe Hung Feb. 17, 2021, 6:32 a.m. UTC | #1
Hi Rob,

Thank you for your review; agreed on all comments.
Should address your feedback in v2.

On Thu, Feb 04, 2021 at 08:39:01PM +0800, Joe Hung wrote:
> Add binding documentation for ILITEK touch devices.


Bindings are in DT schema format now. Please convert.

> 

> Signed-off-by: Joe Hung <joe_hung@ilitek.com>

> ---

>  .../input/touchscreen/ilitek_ts_i2c.txt       | 23 +++++++++++++++++++

>  1 file changed, 23 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt

> 

> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt

> new file mode 100644

> index 000000000000..eb90d3bd7ee7

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt

> @@ -0,0 +1,23 @@

> +Ilitek I2C 23XX/25XX/Lego Series Touch ICs

> +

> +Required properties:

> +- compatible		: Must be equal to one of following:

> +			  "ilitek,ili2520"

> +			  "ilitek,ili2510"

> +- reg			: I2C slave address for touch device.

> +- reset-gpios		: GPIO output high to reset pin of touch device.

> +- irq-gpios		: GPIO as active low input from touch irq pin.


Use 'interrupts' instead.

> +

> +Example:

> +	&i2c1 {

> +		/* ... */

> +

> +		touchscreen@41 {

> +			compatible = "ilitek,ili2520";

> +			reg = <0x41>;

> +			irq-gpios = <&gpio1 13 0>;

> +			reset-gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>;

> +		};

> +

> +		/* ... */

> +	};

> -- 

> 2.25.1

> 

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt
new file mode 100644
index 000000000000..eb90d3bd7ee7
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/ilitek_ts_i2c.txt
@@ -0,0 +1,23 @@ 
+Ilitek I2C 23XX/25XX/Lego Series Touch ICs
+
+Required properties:
+- compatible		: Must be equal to one of following:
+			  "ilitek,ili2520"
+			  "ilitek,ili2510"
+- reg			: I2C slave address for touch device.
+- reset-gpios		: GPIO output high to reset pin of touch device.
+- irq-gpios		: GPIO as active low input from touch irq pin.
+
+Example:
+	&i2c1 {
+		/* ... */
+
+		touchscreen@41 {
+			compatible = "ilitek,ili2520";
+			reg = <0x41>;
+			irq-gpios = <&gpio1 13 0>;
+			reset-gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>;
+		};
+
+		/* ... */
+	};