| Message ID | 20210326143458.508959-24-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 07b34ddd759b7b1580eee6fd754dec824a280f0d |
| Headers | show |
| Series | Rid W=1 warnings from HID | expand |
On Fri, 26 Mar 2021 14:34:55 +0000 Lee Jones <lee.jones@linaro.org> wrote: > Commit b0f847e16c1ea ("HID: hid-sensor-hub: Force logical minimum to 1 > for power and report state") removed the last used quirk handled by > this driver. > > Fixes the following W=1 kernel build warning(s): > > drivers/hid/hid-sensor-hub.c:39: warning: Function parameter or member 'quirks' not described in 'sensor_hub_data' > > Cc: Jiri Kosina <jikos@kernel.org> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Cc: linux-input@vger.kernel.org > Cc: linux-iio@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/hid/hid-sensor-hub.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index 3dd7d32467378..36b6852f75dd5 100644 > --- a/drivers/hid/hid-sensor-hub.c > +++ b/drivers/hid/hid-sensor-hub.c > @@ -34,7 +34,6 @@ struct sensor_hub_data { > spinlock_t dyn_callback_lock; > struct mfd_cell *hid_sensor_hub_client_devs; > int hid_sensor_client_cnt; > - unsigned long quirks; > int ref_cnt; > }; > > @@ -615,7 +614,6 @@ static int sensor_hub_probe(struct hid_device *hdev, > } > > hid_set_drvdata(hdev, sd); > - sd->quirks = id->driver_data; > > spin_lock_init(&sd->lock); > spin_lock_init(&sd->dyn_callback_lock);
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index 3dd7d32467378..36b6852f75dd5 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c @@ -34,7 +34,6 @@ struct sensor_hub_data { spinlock_t dyn_callback_lock; struct mfd_cell *hid_sensor_hub_client_devs; int hid_sensor_client_cnt; - unsigned long quirks; int ref_cnt; }; @@ -615,7 +614,6 @@ static int sensor_hub_probe(struct hid_device *hdev, } hid_set_drvdata(hdev, sd); - sd->quirks = id->driver_data; spin_lock_init(&sd->lock); spin_lock_init(&sd->dyn_callback_lock);
Commit b0f847e16c1ea ("HID: hid-sensor-hub: Force logical minimum to 1 for power and report state") removed the last used quirk handled by this driver. Fixes the following W=1 kernel build warning(s): drivers/hid/hid-sensor-hub.c:39: warning: Function parameter or member 'quirks' not described in 'sensor_hub_data' Cc: Jiri Kosina <jikos@kernel.org> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: linux-input@vger.kernel.org Cc: linux-iio@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/hid/hid-sensor-hub.c | 2 -- 1 file changed, 2 deletions(-) -- 2.27.0