mbox series

[v4,0/5] kselftest: Extend vDSO tests

Message ID 20201026114945.48532-1-vincenzo.frascino@arm.com
Headers show
Series kselftest: Extend vDSO tests | expand

Message

Vincenzo Frascino Oct. 26, 2020, 11:49 a.m. UTC
This series extends the kselftests for the vDSO library making sure: that
they compile correctly on non x86 platforms, that they can be cross
compiled and introducing new tests that verify the correctness of the
library.

The so extended vDSO kselftests have been verified on all the platforms
supported by the unified vDSO library [1].

The only new patch that this series introduces is the first one, patch 2 and
patch 3 have already been reviewed in past as part of other series [2] [3].

[1] https://lore.kernel.org/lkml/20190621095252.32307-1-vincenzo.frascino@arm.com
[2] https://lore.kernel.org/lkml/20190621095252.32307-26-vincenzo.frascino@arm.com
[3] https://lore.kernel.org/lkml/20190523112116.19233-4-vincenzo.frascino@arm.com

It is possible to build the series using the command below:

make -C tools/testing/selftests/ ARCH=<arch> TARGETS=vDSO CC=<compiler>

A version of the series rebased on 5.10-rc1 to simplify the testing can be found
at [4].

[4] https://git.gitlab.arm.com/linux-arm/linux-vf.git vdso/v4.tests

Changes:
--------
v4:
  - Rebased on 5.10-rc1.
v3:
  - Added correctness test for clock_gettime64.
  - Rebased on 5.7-rc4.
v2:
  - Addressed review comments from Andy.
  - Rebased on 5.7-rc3.

Cc: Shuah Khan <shuah@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

Vincenzo Frascino (5):
  kselftest: Enable vDSO test on non x86 platforms
  kselftest: Extend vDSO selftest
  kselftest: Extend vDSO selftest to clock_getres
  kselftest: Move test_vdso to the vDSO test suite
  kselftest: Extend vdso correctness test to clock_gettime64

 tools/testing/selftests/Makefile              |   1 +
 tools/testing/selftests/vDSO/Makefile         |  16 +-
 tools/testing/selftests/vDSO/vdso_config.h    |  92 +++++++
 tools/testing/selftests/vDSO/vdso_test_abi.c  | 244 ++++++++++++++++++
 .../selftests/vDSO/vdso_test_clock_getres.c   | 124 +++++++++
 .../vdso_test_correctness.c}                  | 115 ++++++++-
 tools/testing/selftests/x86/Makefile          |   2 +-
 7 files changed, 586 insertions(+), 8 deletions(-)
 create mode 100644 tools/testing/selftests/vDSO/vdso_config.h
 create mode 100644 tools/testing/selftests/vDSO/vdso_test_abi.c
 create mode 100644 tools/testing/selftests/vDSO/vdso_test_clock_getres.c
 rename tools/testing/selftests/{x86/test_vdso.c => vDSO/vdso_test_correctness.c} (73%)

Comments

Thomas Gleixner Oct. 26, 2020, 11:01 p.m. UTC | #1
On Mon, Oct 26 2020 at 11:49, Vincenzo Frascino wrote:
> This series extends the kselftests for the vDSO library making sure: that
> they compile correctly on non x86 platforms, that they can be cross
> compiled and introducing new tests that verify the correctness of the
> library.
>
> The so extended vDSO kselftests have been verified on all the platforms
> supported by the unified vDSO library [1].
>
> The only new patch that this series introduces is the first one, patch 2 and
> patch 3 have already been reviewed in past as part of other series [2] [3].
>
> [1] https://lore.kernel.org/lkml/20190621095252.32307-1-vincenzo.frascino@arm.com
> [2] https://lore.kernel.org/lkml/20190621095252.32307-26-vincenzo.frascino@arm.com
> [3] https://lore.kernel.org/lkml/20190523112116.19233-4-vincenzo.frascino@arm.com
>
> It is possible to build the series using the command below:
>
> make -C tools/testing/selftests/ ARCH=<arch> TARGETS=vDSO CC=<compiler>
>
> A version of the series rebased on 5.10-rc1 to simplify the testing can be found
> at [4].
>
> [4] https://git.gitlab.arm.com/linux-arm/linux-vf.git vdso/v4.tests

Assuming Shuah will pick them up:

  Acked-by: Thomas Gleixner <tglx@linutronix.de>

Thanks,

        tglx
Shuah Khan Oct. 27, 2020, 12:50 a.m. UTC | #2
On 10/26/20 5:01 PM, Thomas Gleixner wrote:
> On Mon, Oct 26 2020 at 11:49, Vincenzo Frascino wrote:
>> This series extends the kselftests for the vDSO library making sure: that
>> they compile correctly on non x86 platforms, that they can be cross
>> compiled and introducing new tests that verify the correctness of the
>> library.
>>
>> The so extended vDSO kselftests have been verified on all the platforms
>> supported by the unified vDSO library [1].
>>
>> The only new patch that this series introduces is the first one, patch 2 and
>> patch 3 have already been reviewed in past as part of other series [2] [3].
>>
>> [1] https://lore.kernel.org/lkml/20190621095252.32307-1-vincenzo.frascino@arm.com
>> [2] https://lore.kernel.org/lkml/20190621095252.32307-26-vincenzo.frascino@arm.com
>> [3] https://lore.kernel.org/lkml/20190523112116.19233-4-vincenzo.frascino@arm.com
>>
>> It is possible to build the series using the command below:
>>
>> make -C tools/testing/selftests/ ARCH=<arch> TARGETS=vDSO CC=<compiler>
>>
>> A version of the series rebased on 5.10-rc1 to simplify the testing can be found
>> at [4].
>>
>> [4] https://git.gitlab.arm.com/linux-arm/linux-vf.git vdso/v4.tests
> 
> Assuming Shuah will pick them up:
> 
>    Acked-by: Thomas Gleixner <tglx@linutronix.de>
> 


Thanks. I will pick these up.

thanks,
-- Shuah
Shuah Khan Oct. 28, 2020, 3:20 p.m. UTC | #3
On 10/26/20 6:50 PM, Shuah Khan wrote:
> On 10/26/20 5:01 PM, Thomas Gleixner wrote:

>> On Mon, Oct 26 2020 at 11:49, Vincenzo Frascino wrote:

>>> This series extends the kselftests for the vDSO library making sure: 

>>> that

>>> they compile correctly on non x86 platforms, that they can be cross

>>> compiled and introducing new tests that verify the correctness of the

>>> library.

>>>

>>> The so extended vDSO kselftests have been verified on all the platforms

>>> supported by the unified vDSO library [1].

>>>

>>> The only new patch that this series introduces is the first one, 

>>> patch 2 and

>>> patch 3 have already been reviewed in past as part of other series 

>>> [2] [3].

>>>

>>> [1] 

>>> https://lore.kernel.org/lkml/20190621095252.32307-1-vincenzo.frascino@arm.com 

>>>

>>> [2] 

>>> https://lore.kernel.org/lkml/20190621095252.32307-26-vincenzo.frascino@arm.com 

>>>

>>> [3] 

>>> https://lore.kernel.org/lkml/20190523112116.19233-4-vincenzo.frascino@arm.com 

>>>

>>>

>>> It is possible to build the series using the command below:

>>>

>>> make -C tools/testing/selftests/ ARCH=<arch> TARGETS=vDSO CC=<compiler>

>>>

>>> A version of the series rebased on 5.10-rc1 to simplify the testing 

>>> can be found

>>> at [4].

>>>

>>> [4] https://git.gitlab.arm.com/linux-arm/linux-vf.git vdso/v4.tests

>>

>> Assuming Shuah will pick them up:

>>

>>    Acked-by: Thomas Gleixner <tglx@linutronix.de>

>>

> 

> 

> Thanks. I will pick these up.



Applied to linux-kselftest next

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next

thanks,
-- Shuah