mbox series

[v3,0/2] kunit: fail tests on UBSAN errors

Message ID 20210209221443.78812-1-dlatypov@google.com
Headers show
Series kunit: fail tests on UBSAN errors | expand

Message

Daniel Latypov Feb. 9, 2021, 10:14 p.m. UTC
v1 by Uriel is here: [1].
Since it's been a while, I've dropped the Reviewed-By's.

It depended on commit 83c4e7a0363b ("KUnit: KASAN Integration") which
hadn't been merged yet, so that caused some kerfuffle with applying them
previously and the series was reverted.

This revives the series but makes the kunit_fail_current_test() function
take a format string and logs the file and line number of the failing
code, addressing Alan Maguire's comments on the previous version.

As a result, the patch that makes UBSAN errors was tweaked slightly to
include an error message.

v2 -> v3:
  Fix kunit_fail_current_test() so it works w/ CONFIG_KUNIT=m
  s/_/__ on the helper func to match others in test.c

[1] https://lore.kernel.org/linux-kselftest/20200806174326.3577537-1-urielguajardojr@gmail.com/

Uriel Guajardo (2):
  kunit: support failure from dynamic analysis tools
  kunit: ubsan integration

 include/kunit/test-bug.h | 30 ++++++++++++++++++++++++++++++
 lib/kunit/test.c         | 37 +++++++++++++++++++++++++++++++++----
 lib/ubsan.c              |  3 +++
 3 files changed, 66 insertions(+), 4 deletions(-)
 create mode 100644 include/kunit/test-bug.h


base-commit: 1e0d27fce010b0a4a9e595506b6ede75934c31be

Comments

Alan Maguire Feb. 10, 2021, 10:34 a.m. UTC | #1
On Tue, 9 Feb 2021, Daniel Latypov wrote:

> v1 by Uriel is here: [1].

> Since it's been a while, I've dropped the Reviewed-By's.

> 

> It depended on commit 83c4e7a0363b ("KUnit: KASAN Integration") which

> hadn't been merged yet, so that caused some kerfuffle with applying them

> previously and the series was reverted.

> 

> This revives the series but makes the kunit_fail_current_test() function

> take a format string and logs the file and line number of the failing

> code, addressing Alan Maguire's comments on the previous version.

> 

> As a result, the patch that makes UBSAN errors was tweaked slightly to

> include an error message.

> 

> v2 -> v3:

>   Fix kunit_fail_current_test() so it works w/ CONFIG_KUNIT=m

>   s/_/__ on the helper func to match others in test.c

> 

> [1] https://lore.kernel.org/linux-kselftest/20200806174326.3577537-1-urielguajardojr@gmail.com/

>


For the series:

Reviewed-by: Alan Maguire <alan.maguire@oracle.com>


Thanks!