mbox series

[v3,0/7] selftests/resctrl: Rework benchmark command handling

Message ID 20230823131556.27617-1-ilpo.jarvinen@linux.intel.com
Headers show
Series selftests/resctrl: Rework benchmark command handling | expand

Message

Ilpo Järvinen Aug. 23, 2023, 1:15 p.m. UTC 
The benchmark command handling (-b) in resctrl selftests is overly
complicated code. This series turns the benchmark command immutable to
preserve it for all selftests and improves benchmark command related
error handling.

This series also ends up removing the strcpy() calls which were pointed
out earlier.

v3:
- Removed DEFAULT_SPAN_STR for real and the duplicated copy of defines
  that made to v2 likely due to my incorrect conflict resolutions

v2:
- Added argument length check into patch 1/7
- Updated also -b line in help message.
- Document -b argument related "algorithm"
- Use asprintf() to convert defined constant int to string
- Improved changelog texts
- Added \n to ksft_exit_fail_msg() call messages.
- Print DEFAULT_SPAN with %u instead of %zu to avoid need to cast it

Ilpo Järvinen (7):
  selftests/resctrl: Ensure the benchmark commands fits to its array
  selftests/resctrl: Correct benchmark command help
  selftests/resctrl: Remove bw_report and bm_type from main()
  selftests/resctrl: Simplify span lifetime
  selftests/resctrl: Make benchmark command const and build it with
    pointers
  selftests/resctrl: Remove ben_count variable
  selftests/resctrl: Cleanup benchmark argument parsing

 tools/testing/selftests/resctrl/cache.c       |   5 +-
 tools/testing/selftests/resctrl/cat_test.c    |  13 +-
 tools/testing/selftests/resctrl/cmt_test.c    |  34 +++--
 tools/testing/selftests/resctrl/mba_test.c    |   4 +-
 tools/testing/selftests/resctrl/mbm_test.c    |   7 +-
 tools/testing/selftests/resctrl/resctrl.h     |  17 ++-
 .../testing/selftests/resctrl/resctrl_tests.c | 120 +++++++++---------
 tools/testing/selftests/resctrl/resctrl_val.c |  10 +-
 8 files changed, 120 insertions(+), 90 deletions(-)

Comments

Shaopeng Tan (Fujitsu) Aug. 25, 2023, 8:36 a.m. UTC | #1 
Hello Ilpo,

I reviewed and tested this patch series, it looks fine.

<Reviewed-by:tan.shaopeng@jp.fujitsu.com>
<Tested-by:tan.shaopeng@jp.fujitsu.com>

Best regards,
Shaopeng TAN