From patchwork Fri Feb 19 13:33:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 385429 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1C3C433DB for ; Fri, 19 Feb 2021 13:33:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8C7464E38 for ; Fri, 19 Feb 2021 13:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbhBSNdw (ORCPT ); Fri, 19 Feb 2021 08:33:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbhBSNdv (ORCPT ); Fri, 19 Feb 2021 08:33:51 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 698CCC061574 for ; Fri, 19 Feb 2021 05:33:11 -0800 (PST) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD5u9-0007P5-88; Fri, 19 Feb 2021 14:33:09 +0100 Received: from ukl by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lD5u8-0001aI-P2; Fri, 19 Feb 2021 14:33:08 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Pavel Machek , Greg Kroah-Hartman Cc: kernel@pengutronix.de, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH v2 0/2] Fixes for the tty ledtrigger Date: Fri, 19 Feb 2021 14:33:05 +0100 Message-Id: <20210219133307.4840-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-leds@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hello, this drops the unused label that the kernel test robot found. Thanks for catching that. I also added Pavel's Ack. Best regards Uwe Uwe Kleine-König (2): leds: trigger: Fix error path to not unlock the unlocked mutex leds: trigger/tty: Use led_set_brightness_sync() from workqueue drivers/leds/trigger/ledtrig-tty.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) Range-diff against v1: 1: 7fc10ce8eb8b ! 1: ed39ad41cd91 leds: trigger: Fix error path to not unlock the unlocked mutex @@ Commit message Reported-by: Pavel Machek Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger") + Acked-by: Pavel Machek Signed-off-by: Uwe Kleine-König ## drivers/leds/trigger/ledtrig-tty.c ## @@ drivers/leds/trigger/ledtrig-tty.c: static ssize_t ttyname_store(struct device * } else { ttyname = NULL; } +@@ drivers/leds/trigger/ledtrig-tty.c: static ssize_t ttyname_store(struct device *dev, + + trigger_data->ttyname = ttyname; + +-out_unlock: + mutex_unlock(&trigger_data->mutex); + + if (ttyname && !running) 2: fe3d28f4a786 ! 2: a812318f4cfc leds: trigger/tty: Use led_set_brightness_sync() from workqueue @@ Commit message Reported-by: Pavel Machek Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger") + Acked-by: Pavel Machek Signed-off-by: Uwe Kleine-König ## drivers/leds/trigger/ledtrig-tty.c ##