From patchwork Thu Apr 11 16:10:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: George Stark X-Patchwork-Id: 788491 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49BFD153510; Thu, 11 Apr 2024 16:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.18.73.165 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712851846; cv=none; b=gLM8uLz0cFGa6CGUnaElbTqeBzQnd6mSRVY74eJ1auY8S6WG9Ip4n10IcHS4boirPGKUM9SIFt5zqMOUppkwa0BVBQwTqSaWfBpDXJOiOl8JUUOsXqIMhKpmXd6G/+4iITkfTNh0EQMzsu1Jz3jFG2FDVrKkEkCF9F5IdlL+yRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712851846; c=relaxed/simple; bh=gcr3u6AJ9gPeWsDcrmN1X9U3qGx2pvGRfcvorANaDls=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Sr6yClX5O74MkBxRJGp04dtRBaFvUwtmoZy9oFSS0BZlipbu7Xv5jqhzR23swNpugRZJi1VmCbnYWsuNrC0w+1He4x7M+1AqDM4y5ft2NXAUd4QW1+4fIAoRGtKvMFRrywdmv+WwOfWRVMzhHOjjq2pawnxYEy3X65quEmN+8cc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=salutedevices.com; spf=pass smtp.mailfrom=salutedevices.com; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b=db8XTiEa; arc=none smtp.client-ip=37.18.73.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=salutedevices.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=salutedevices.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b="db8XTiEa" Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id E0F29100086; Thu, 11 Apr 2024 19:10:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru E0F29100086 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1712851839; bh=/zjPrGZYI308SD39RKD2gBN2H8Ja4pUg4pSXYHMVm3c=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=db8XTiEaYcaOt6B5TxZmkG+Ex1cRh2wQW1LZavHL53ZuB0dD+01hyJXn1nSexWQ1+ /xSsDmhh+dWsRYTHUtL2Qb2tVYhqpz37JKDZZ8BEQveU1Hsfpk1yzMJpinlDMF+a3z XsXOHJSpLbbW3ZM9maMKGGm3yU+goUWXRgjYW0JTKaExecqwD7/i8Wb/E6pVWDX1xy RDB/V9dTYqTL5WklVtcqzxdbht1ZkhzzIpxm1jFkvgG8g+ahiublh74vHtX1U9h4nW wF2VhxW/gLVEncwIJBcL2N06ySeiomYtwUZ51XroGlDwsrG86d9hR2eFwm57aRL8o4 OJiZ2/jklAF/g== Received: from smtp.sberdevices.ru (p-i-exch-sc-m02.sberdevices.ru [172.16.192.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Thu, 11 Apr 2024 19:10:39 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 11 Apr 2024 19:10:39 +0300 From: George Stark To: , , , , , , , , , , , , , , CC: , , , George Stark Subject: [PATCH v8 0/8] devm_led_classdev_register() usage problem Date: Thu, 11 Apr 2024 19:10:24 +0300 Message-ID: <20240411161032.609544-1-gnstark@salutedevices.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 184677 [Apr 11 2024] X-KSMG-AntiSpam-Version: 6.1.0.4 X-KSMG-AntiSpam-Envelope-From: gnstark@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 16 0.3.16 6e64c33514fcbd07e515710c86ba61de7f56194e, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, smtp.sberdevices.ru:7.1.1,5.0.1; lore.kernel.org:7.1.1; 100.64.160.123:7.1.2; d41d8cd98f00b204e9800998ecf8427e.com:7.1.1; salutedevices.com:7.1.1; 127.0.0.199:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2024/04/11 07:46:00 X-KSMG-LinksScanning: Clean, bases: 2024/04/11 07:47:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/04/11 11:38:00 #24745823 X-KSMG-AntiVirus-Status: Clean, skipped This patch series fixes the problem of devm_led_classdev_register misusing. The basic problem is described in [1]. Shortly when devm_led_classdev_register() is used then led_classdev_unregister() called after driver's remove() callback. led_classdev_unregister() calls driver's brightness_set callback and that callback may use resources which were destroyed already in driver's remove(). After discussion with maintainers [2] [3] we decided: 1) don't touch led subsystem core code and don't remove led_set_brightness() from it but fix drivers 2) don't use devm_led_classdev_unregister So the solution is to use devm wrappers for all resources driver's brightness_set() depends on. And introduce dedicated devm wrapper for mutex as it's often used resource. [1] https://lore.kernel.org/lkml/8704539b-ed3b-44e6-aa82-586e2f895e2b@salutedevices.com/T/ [2] https://lore.kernel.org/lkml/8704539b-ed3b-44e6-aa82-586e2f895e2b@salutedevices.com/T/#mc132b9b350fa51931b4fcfe14705d9f06e91421f [3] https://lore.kernel.org/lkml/8704539b-ed3b-44e6-aa82-586e2f895e2b@salutedevices.com/T/#mdbf572a85c33f869a553caf986b6228bb65c8383 Changelog: v1->v2: revise patch series completely v2->v3: locking: add define if mutex_destroy() is not an empty function new patch, discussed here [8] devm-helpers: introduce devm_mutex_init previous version [4] - revise code based on mutex_destroy define - update commit message - update devm_mutex_init()'s description leds: aw2013: unlock mutex before destroying it previous version [5] - make this patch first in the series - add tags Fixes and RvB by Andy leds: aw2013: use devm API to cleanup module's resources previous version [6] - make aw2013_chip_disable_action()'s body one line - don't shadow devm_mutex_init() return code leds: aw200xx: use devm API to cleanup module's resources previous version [7] - make aw200xx_*_action()'s bodies one line - don't shadow devm_mutex_init() return code leds: lm3532: use devm API to cleanup module's resources leds: nic78bx: use devm API to cleanup module's resources leds: mlxreg: use devm_mutex_init for mutex initialization leds: an30259a: use devm_mutext_init for mutext initialization leds: powernv: add LED_RETAIN_AT_SHUTDOWN flag for leds - those patches were planned but not sent in the series #2 due to mail server problem on my side. I revised them according to the comments. v3->v4: locking: introduce devm_mutex_init new patch - move devm_mutex_init implementation completely from devm-helpers.h to mutex.h locking: add define if mutex_destroy() is not an empty function drop the patch [9] devm-helpers: introduce devm_mutex_init drop the patch [10] leds: aw2013: use devm API to cleanup module's resources - add tag Tested-by: Nikita Travkin v4->v5: leds: aw2013: unlock mutex before destroying it merged separately and removed from the series locking/mutex: move mutex_destroy() definition lower introduce optional refactoring patch locking/mutex: introduce devm_mutex_init leave only one devm_mutex_init definition add tag Signed-off-by: Christophe Leroy leds* patches remove #include due to devm_mutex_init() in mutex.h now v5->v6: locking/mutex: move mutex_destroy() definition lower [11] drop the patch due to devm_mutex_init block is big enough to be declared standalone. locking/mutex: introduce devm_mutex_init redesign devm_mutex_init function to macro to keep lockdep feature working use typeof to redeclare mutex var in macro body (thanks to checkpatch) previous version [12] v6->v7: locking/mutex: introduce devm_mutex_init fix comment at __devm_mutex_init move #include upper commit message: change devm_mutex_init -> devm_mutex_init(), add point in the end fix and move up tag Suggested-by: Christophe Leroy add tags (in the order received): Reviewed-by: Christophe Leroy Reviewed-by: Andy Shevchenko Reviewed-by: Marek Behún Acked-by: Waiman Long leds: powernv: use LED_RETAIN_AT_SHUTDOWN flag for leds remove the patch from this series to send it separately leds: mlxreg: use devm_mutex_init() for mutex initialization leds: an30259a: use devm_mutex_init() for mutex initialization commit message: change devm_mutex_init -> devm_mutex_init() add tag Reviewed-by: Andy Shevchenko leds: aw2013: use devm API to cleanup module's resources leds: aw200xx: use devm API to cleanup module's resources leds: lp3952: use devm API to cleanup module's resources leds: lm3532: use devm API to cleanup module's resources leds: nic78bx: use devm API to cleanup module's resources add tag Reviewed-by: Andy Shevchenko v7->v8: locking/mutex: introduce devm_mutex_init() add EXPORT_SYMBOL_GPL(__devm_mutex_init) to mutex-debug.c next changes were asked by Andy in [13] leds: lp3952: use devm API to cleanup module's resources drop type casting in gpio_set_low_action() leds: lm3532: use devm API to cleanup module's resources drop type casting in gpio_set_low_action() leds: nic78bx: use devm API to cleanup module's resources drop type casting in lock_led_reg_action() [4] https://lore.kernel.org/lkml/20231204180603.470421-1-gnstark@salutedevices.com/T/#mf500af0eda2a9ffc95594607dbe4cb64f2e3c9a8 [5] https://lore.kernel.org/lkml/20231204180603.470421-1-gnstark@salutedevices.com/T/#mc92df4fb4f7d4187fb01cc1144acfa5fb5230dd2 [6] https://lore.kernel.org/lkml/20231204180603.470421-1-gnstark@salutedevices.com/T/#m300df89710c43cc2ab598baa16c68dd0a0d7d681 [7] https://lore.kernel.org/lkml/20231204180603.470421-1-gnstark@salutedevices.com/T/#m8e5c65e0c6b137c91fa00bb9320ad581164d1d0b [8] https://lore.kernel.org/lkml/377e4437-7051-4d88-ae68-1460bcd692e1@redhat.com/T/#m5f84a4a2f387d49678783e652b9e658e02c27450 [9] https://lore.kernel.org/lkml/20231213223020.2713164-1-gnstark@salutedevices.com/T/#m19ad1fc04c560012c1e27418e3156d0c9306dd84 [10] https://lore.kernel.org/lkml/20231213223020.2713164-1-gnstark@salutedevices.com/T/#m63126025f5d1bdcef69bcad50f2e58274d42e2d [11] https://lore.kernel.org/lkml/20240307024034.1548605-2-gnstark@salutedevices.com/ [12] https://lore.kernel.org/lkml/20240307024034.1548605-3-gnstark@salutedevices.com/ [13] https://lore.kernel.org/lkml/CAHp75VeNijg6sXyW_frwD4siJ-LWBLBfVCmMDug8jYAVVg9Bmw@mail.gmail.com/ George Stark (8): locking/mutex: introduce devm_mutex_init() leds: aw2013: use devm API to cleanup module's resources leds: aw200xx: use devm API to cleanup module's resources leds: lp3952: use devm API to cleanup module's resources leds: lm3532: use devm API to cleanup module's resources leds: nic78bx: use devm API to cleanup module's resources leds: mlxreg: use devm_mutex_init() for mutex initialization leds: an30259a: use devm_mutex_init() for mutex initialization drivers/leds/leds-an30259a.c | 14 ++++---------- drivers/leds/leds-aw200xx.c | 32 +++++++++++++++++++++----------- drivers/leds/leds-aw2013.c | 25 +++++++++++++------------ drivers/leds/leds-lm3532.c | 29 +++++++++++++++++------------ drivers/leds/leds-lp3952.c | 21 +++++++++++---------- drivers/leds/leds-mlxreg.c | 14 +++++--------- drivers/leds/leds-nic78bx.c | 23 +++++++++++++---------- include/linux/mutex.h | 27 +++++++++++++++++++++++++++ kernel/locking/mutex-debug.c | 12 ++++++++++++ 9 files changed, 123 insertions(+), 74 deletions(-) --- 2.25.1