From patchwork Tue Oct 8 20:47:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 175560 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp6206420ill; Tue, 8 Oct 2019 13:48:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxf2yYtkg9G63EtF3WAOSEvESqfzijmQtBqJ2dYKWE9x9nGu+2O0MLkeNxeUJNQRM8C9/m4 X-Received: by 2002:a50:fa98:: with SMTP id w24mr36277701edr.47.1570567711547; Tue, 08 Oct 2019 13:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570567711; cv=none; d=google.com; s=arc-20160816; b=ZsaNg3uMACCRINN+DdIEWPOg5ktdcFA/EYCHkTt8bzEDFS6rTH7XY1PjNJ/BhvbuYi KXq0tPbqwcuLe+16II0Wh6m5e82J3O3/X5cdhqAu+vb6FXNyKPnDMm+yx0qJaEChB1lT p84hqD0kjBP3XkO/bajoNCgvBbN4BdXBE2DiW7P3F+6g9AKsWPyRaisHkY05QlRPPXPx Lz2+k+9NxabQcnxKlWHay0W+efnQl4e/tk0E3r4/hCSqIL8LpxzltVCwL9i5xzgAAmaB b4yc2PIAKjHM3OJH/YQTvzUwiu3wmrIJHnkLVFuH8D66l9pTFCO4ydJnNr7u8FaQwQ3P ESzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Z4PZA7STOJQqwmrnX0Trv7XrUhkqugQl6U0wq3z09nk=; b=JmfXwYHRkoEI37nx/s9E6RTK3IZvmF8j+/DgKuhLm2S8ctRcL3TMWAtfFbMs0C4/DE i7zoUcXTxlWvMxeuKZlCgmWTI24wLiLKdhhyuyHpBUQYbOiLU44ApEgpmwU0bcL+WbbY C3DCcp1VQMCA9piNMHkXG5hcmWm2CBf5XtKkkvHTQdKnRqLVyxPryx5I5ruLGJBInrgm SrutOqGbR2k/9oA/mCMbSGjD28nrRNBAZe/atC5uYFObw4SDb2aMYTYpa3H9kaM9nfUV geQl7smtIAf8UqDVjIuD3Syh8TeKUX1vpy6X2rmzocwtl1oR8RATvtRUaha0CzgG3oPZ 41HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=pbPK9HYV; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s27si115462edm.226.2019.10.08.13.48.31; Tue, 08 Oct 2019 13:48:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=pbPK9HYV; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731175AbfJHUs1 (ORCPT + 1 other); Tue, 8 Oct 2019 16:48:27 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:45052 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731135AbfJHUs0 (ORCPT ); Tue, 8 Oct 2019 16:48:26 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x98KmMuw092708; Tue, 8 Oct 2019 15:48:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1570567702; bh=Z4PZA7STOJQqwmrnX0Trv7XrUhkqugQl6U0wq3z09nk=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=pbPK9HYVhsRW+ivkPANEXcP99CLpykzuerIIoS4FJ7p2yi3fO7a4NcV9B6NWSyhdP kenZXCPnl1GyrNLKmuQ5RQXniZLpMep7vf3AK/DclEtamSoI+8mt60XdMe54ehZJnm rCFFxS0jw8aBQ600xmT8xrCarp5mzI8u6YpmYiYs= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x98KmM1O062222 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Oct 2019 15:48:22 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 8 Oct 2019 15:48:19 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Oct 2019 15:48:22 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x98KmMqq095766; Tue, 8 Oct 2019 15:48:22 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v11 15/16] leds: lp55xx: Fix checkpatch file permissions issues Date: Tue, 8 Oct 2019 15:47:59 -0500 Message-ID: <20191008204800.19870-16-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191008204800.19870-1-dmurphy@ti.com> References: <20191008204800.19870-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Fix the checkpatch warnings for the use of the file permission macros. In converting the file permissions to the DEVICE_ATTR_XX macros the call back function names needed to be updated within the code. This means that the lp55xx_ needed to be dropped in the name to keep in harmony with the ABI documentation. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c index 85629f836082..fc5224108c64 100644 --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -78,7 +78,7 @@ static int lp55xx_post_init_device(struct lp55xx_chip *chip) return cfg->post_init_device(chip); } -static ssize_t lp55xx_show_current(struct device *dev, +static ssize_t led_current_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -87,7 +87,7 @@ static ssize_t lp55xx_show_current(struct device *dev, return scnprintf(buf, PAGE_SIZE, "%d\n", led->led_current); } -static ssize_t lp55xx_store_current(struct device *dev, +static ssize_t led_current_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -111,7 +111,7 @@ static ssize_t lp55xx_store_current(struct device *dev, return len; } -static ssize_t lp55xx_show_max_current(struct device *dev, +static ssize_t max_current_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -120,9 +120,8 @@ static ssize_t lp55xx_show_max_current(struct device *dev, return scnprintf(buf, PAGE_SIZE, "%d\n", led->max_current); } -static DEVICE_ATTR(led_current, S_IRUGO | S_IWUSR, lp55xx_show_current, - lp55xx_store_current); -static DEVICE_ATTR(max_current, S_IRUGO , lp55xx_show_max_current, NULL); +static DEVICE_ATTR_RW(led_current); +static DEVICE_ATTR_RO(max_current); static struct attribute *lp55xx_led_attrs[] = { &dev_attr_led_current.attr, @@ -282,7 +281,7 @@ static int lp55xx_request_firmware(struct lp55xx_chip *chip) GFP_KERNEL, chip, lp55xx_firmware_loaded); } -static ssize_t lp55xx_show_engine_select(struct device *dev, +static ssize_t select_engine_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -292,7 +291,7 @@ static ssize_t lp55xx_show_engine_select(struct device *dev, return sprintf(buf, "%d\n", chip->engine_idx); } -static ssize_t lp55xx_store_engine_select(struct device *dev, +static ssize_t select_engine_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -334,7 +333,7 @@ static inline void lp55xx_run_engine(struct lp55xx_chip *chip, bool start) chip->cfg->run_engine(chip, start); } -static ssize_t lp55xx_store_engine_run(struct device *dev, +static ssize_t run_engine_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -359,9 +358,8 @@ static ssize_t lp55xx_store_engine_run(struct device *dev, return len; } -static DEVICE_ATTR(select_engine, S_IRUGO | S_IWUSR, - lp55xx_show_engine_select, lp55xx_store_engine_select); -static DEVICE_ATTR(run_engine, S_IWUSR, NULL, lp55xx_store_engine_run); +static DEVICE_ATTR_RW(select_engine); +static DEVICE_ATTR_WO(run_engine); static struct attribute *lp55xx_engine_attributes[] = { &dev_attr_select_engine.attr,