mbox series

[v2,net-next,0/6] Brcm ASP 2.0 Ethernet controller

Message ID 1682535272-32249-1-git-send-email-justinpopo6@gmail.com
Headers show
Series Brcm ASP 2.0 Ethernet controller | expand

Message

Justin Chen April 26, 2023, 6:54 p.m. UTC 
v2
	- Updates to yaml dt documentation
	- Replace a couple functions with helper functions
	- Minor formatting fixes
	- Fix a few WoL issues

Add support for the Broadcom ASP 2.0 Ethernet controller which is first
introduced with 72165.

Add support for 74165 10/100 integrated Ethernet PHY which also uses
the ASP 2.0 Ethernet controller.

Florian Fainelli (2):
  dt-bindings: net: Brcm ASP 2.0 Ethernet controller
  net: phy: bcm7xxx: Add EPHY entry for 74165

Justin Chen (4):
  dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0
  net: bcmasp: Add support for ASP2.0 Ethernet controller
  net: phy: mdio-bcm-unimac: Add asp v2.0 support
  MAINTAINERS: ASP 2.0 Ethernet driver maintainers

 .../devicetree/bindings/net/brcm,asp-v2.0.yaml     |  145 ++
 .../devicetree/bindings/net/brcm,unimac-mdio.yaml  |    2 +
 MAINTAINERS                                        |    9 +
 drivers/net/ethernet/broadcom/Kconfig              |   11 +
 drivers/net/ethernet/broadcom/Makefile             |    1 +
 drivers/net/ethernet/broadcom/asp2/Makefile        |    2 +
 drivers/net/ethernet/broadcom/asp2/bcmasp.c        | 1476 ++++++++++++++++++++
 drivers/net/ethernet/broadcom/asp2/bcmasp.h        |  636 +++++++++
 .../net/ethernet/broadcom/asp2/bcmasp_ethtool.c    |  585 ++++++++
 drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c   | 1435 +++++++++++++++++++
 .../net/ethernet/broadcom/asp2/bcmasp_intf_defs.h  |  238 ++++
 drivers/net/mdio/mdio-bcm-unimac.c                 |    2 +
 drivers/net/phy/bcm7xxx.c                          |    1 +
 include/linux/brcmphy.h                            |    1 +
 14 files changed, 4544 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
 create mode 100644 drivers/net/ethernet/broadcom/asp2/Makefile
 create mode 100644 drivers/net/ethernet/broadcom/asp2/bcmasp.c
 create mode 100644 drivers/net/ethernet/broadcom/asp2/bcmasp.h
 create mode 100644 drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c
 create mode 100644 drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
 create mode 100644 drivers/net/ethernet/broadcom/asp2/bcmasp_intf_defs.h

Comments

Florian Fainelli April 27, 2023, 5:05 p.m. UTC | #1 
On 4/27/23 10:03, Rob Herring wrote:
> On Wed, Apr 26, 2023 at 11:54:27AM -0700, Justin Chen wrote:
>> The ASP 2.0 Ethernet controller uses a brcm unimac.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> index 0be426ee1e44..6684810fcbf0 100644
>> --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> @@ -22,6 +22,8 @@ properties:
>>         - brcm,genet-mdio-v3
>>         - brcm,genet-mdio-v4
>>         - brcm,genet-mdio-v5
>> +      - brcm,asp-v2.0-mdio
>> +      - brcm,asp-v2.1-mdio
> 
> How many SoCs does each of these correspond to? SoC specific compatibles
> are preferred to version numbers (because few vendors are disciplined
> at versioning and also not changing versions with every Soc).

So far there is a 1:1 mapping between the number of versions and the 
number of SoCs, and the older SoC uses v2.0, while the newer one uses v2.1.