| Message ID | 20210616215211.4002992-1-heiko@sntech.de |
|---|---|
| Headers | show |
| Series | rkisp1 support for px30 | expand |
Hi, On 17.06.21 00:52, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com> > > Some variants have one irq signaling all of MI, MIPI and ISP events > while some rkisp1 variants use separate irqs for each. > > Adapt the binding to handle both cases. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com> > --- > .../devicetree/bindings/media/rockchip-isp1.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > index 2f8f0625d22e..80709a01c6fd 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml > @@ -21,7 +21,14 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > + > + interrupt-names: > + items: > + - const: isp > + - const: mi > + - const: mipi Since you use those names in the driver they should probably be 'required' you should do something like: if: properties: compatible: contains: const: the-new-px30-compat.. then: required: - interrupt-names would also be nice to add your new bindings in the example in the yaml Thanks, Dafna > > clocks: > minItems: 3 >
This series adds support for the slightly different v12 variant of the ISP used for example in the px30 soc. changes in v4: - clean up multi-irq case (Dafna) Now each variant can have a list of interrupts and their respective handlers, with or without interrupt-names changes in v3: - add necessary binding additions - fix pclk naming in binding - move v12 clk_ctrl register bits to v12 addition patch - fix rebase artefact with hst_enable changes in v2 (from rfc): - split out phy patch into a separate series - drop dts patches for now - split v12 addition and v10 prefixes into separate patches to enable easier review (Dafna) - remove {stats,params}_config structs, we can just use the correct constant (Dafna) - adapt to styling comments from Dafna and Helen - add patch to remove the unused irq variable in struct rkisp Heiko Stuebner (10): media: rockchip: rkisp1: remove unused irq variable dt-bindings: media: rkisp1: fix pclk clock-name dt-bindings: media: rkisp1: document different irq possibilities media: rockchip: rkisp1: allow separate interrupts media: rockchip: rkisp1: make some isp-param functions variable media: rockchip: rkisp1: make some isp-stats functions variable media: rockchip: rkisp1: add prefixes for v10 specific parts media: rockchip: rkisp1: add support for v12 isp variants dt-bindings: media: rkisp1: document px30 isp compatible media: rockchip: rkisp1: add support for px30 isp version .../bindings/media/rockchip-isp1.yaml | 15 +- .../platform/rockchip/rkisp1/rkisp1-capture.c | 9 +- .../platform/rockchip/rkisp1/rkisp1-common.h | 44 +- .../platform/rockchip/rkisp1/rkisp1-dev.c | 71 ++- .../platform/rockchip/rkisp1/rkisp1-isp.c | 29 +- .../platform/rockchip/rkisp1/rkisp1-params.c | 557 ++++++++++++++---- .../platform/rockchip/rkisp1/rkisp1-regs.h | 406 ++++++++----- .../platform/rockchip/rkisp1/rkisp1-stats.c | 107 +++- 8 files changed, 959 insertions(+), 279 deletions(-)