| Message ID | 20220812143055.12938-1-olivier.masse@nxp.com |
|---|---|
| Headers | show |
| Series | tee: Add tee_shm_register_fd | expand |
Hi Olivier, On Fri, Aug 12, 2022 at 4:31 PM Olivier Masse <olivier.masse@nxp.com> wrote: > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > shared memory from a dmabuf file descriptor. > This new ioctl will allow the Linux Kernel to register a buffer > to be used by the Secure Data Path OPTEE OS feature. > > Please find more information here: > https://static.linaro.org/connect/san19/presentations/san19-107.pdf > > Patch tested on Hikey 6220. What's new in this V2? Thanks, Jens > > Etienne Carriere (1): > tee: new ioctl to a register tee_shm from a dmabuf file descriptor > > drivers/tee/tee_core.c | 38 +++++++++++++++ > drivers/tee/tee_shm.c | 99 +++++++++++++++++++++++++++++++++++++++- > include/linux/tee_drv.h | 11 +++++ > include/uapi/linux/tee.h | 29 ++++++++++++ > 4 files changed, 175 insertions(+), 2 deletions(-) > > -- > 2.25.0 >
Hi Jens, On mar., 2022-08-16 at 10:17 +0200, Jens Wiklander wrote: > Caution: EXT Email > > Hi Olivier, > > On Fri, Aug 12, 2022 at 4:31 PM Olivier Masse <olivier.masse@nxp.com> > wrote: > > > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > > shared memory from a dmabuf file descriptor. > > This new ioctl will allow the Linux Kernel to register a buffer > > to be used by the Secure Data Path OPTEE OS feature. > > > > Please find more information here: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstatic.linaro.org%2Fconnect%2Fsan19%2Fpresentations%2Fsan19-107.pdf&data=05%7C01%7Colivier.masse%40nxp.com%7C20ddb873be8f4cd89b5408da7f5fda26%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637962346897373445%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=cMbuihC0Hat4DEVORzcGhzwjO%2FxclAW43AIcvR8yReE%3D&reserved=0 > > > > Patch tested on Hikey 6220. > > What's new in this V2? Just updated the cover letter and minor change to fix a build error with gcc-11 for x86 architecture: >> ./usr/include/linux/tee.h:136:13: error: expected declaration specifiers or '...' before numeric constant 136 | } __aligned(8); | ^ Best regards, Olivier > > Thanks, > Jens > > > > > Etienne Carriere (1): > > tee: new ioctl to a register tee_shm from a dmabuf file > > descriptor > > > > drivers/tee/tee_core.c | 38 +++++++++++++++ > > drivers/tee/tee_shm.c | 99 > > +++++++++++++++++++++++++++++++++++++++- > > include/linux/tee_drv.h | 11 +++++ > > include/uapi/linux/tee.h | 29 ++++++++++++ > > 4 files changed, 175 insertions(+), 2 deletions(-) > > > > -- > > 2.25.0 > >
Hi Olivier, On Fri, 12 Aug 2022 at 20:01, Olivier Masse <olivier.masse@nxp.com> wrote: > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > shared memory from a dmabuf file descriptor. > This new ioctl will allow the Linux Kernel to register a buffer > to be used by the Secure Data Path OPTEE OS feature. > > Please find more information here: > https://static.linaro.org/connect/san19/presentations/san19-107.pdf > > Patch tested on Hikey 6220. > AFAIU, for the OP-TEE SDP feature to work you need to have a DMA-BUF heap driver for allocating secure buffers through exposed chardev: "/dev/dma_heap/sdp". Have you tested it with some out-of-tree driver as I can't find it upstream? Also, do you plan to push that upstream as well? BTW, please add a changelog while sending newer patch-set versions. -Sumit > Etienne Carriere (1): > tee: new ioctl to a register tee_shm from a dmabuf file descriptor > > drivers/tee/tee_core.c | 38 +++++++++++++++ > drivers/tee/tee_shm.c | 99 +++++++++++++++++++++++++++++++++++++++- > include/linux/tee_drv.h | 11 +++++ > include/uapi/linux/tee.h | 29 ++++++++++++ > 4 files changed, 175 insertions(+), 2 deletions(-) > > -- > 2.25.0 >
Hi Sumit On ven., 2022-08-19 at 13:54 +0530, Sumit Garg wrote: > Caution: EXT Email > > Hi Olivier, > > On Fri, 12 Aug 2022 at 20:01, Olivier Masse <olivier.masse@nxp.com> > wrote: > > > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > > shared memory from a dmabuf file descriptor. > > This new ioctl will allow the Linux Kernel to register a buffer > > to be used by the Secure Data Path OPTEE OS feature. > > > > Please find more information here: > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstatic.linaro.org%2Fconnect%2Fsan19%2Fpresentations%2Fsan19-107.pdf&data=05%7C01%7Colivier.masse%40nxp.com%7C05071ff1c28044ab740908da81bc44e2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637964942860947359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nYLb2iMoJExdKEg4CL4eW5%2FQ%2Bqqj4Iw1TxFsd1UqWW0%3D&reserved=0 > > > > Patch tested on Hikey 6220. > > > > AFAIU, for the OP-TEE SDP feature to work you need to have a DMA-BUF > heap driver for allocating secure buffers through exposed chardev: > "/dev/dma_heap/sdp". Have you tested it with some out-of-tree driver > as I can't find it upstream? Also, do you plan to push that upstream > as well? It has been tested with linaro,secure-heap reserved dma heap memory which is also in review for upstream. > > BTW, please add a changelog while sending newer patch-set versions. > > -Sumit > > > Etienne Carriere (1): > > tee: new ioctl to a register tee_shm from a dmabuf file > > descriptor > > > > drivers/tee/tee_core.c | 38 +++++++++++++++ > > drivers/tee/tee_shm.c | 99 > > +++++++++++++++++++++++++++++++++++++++- > > include/linux/tee_drv.h | 11 +++++ > > include/uapi/linux/tee.h | 29 ++++++++++++ > > 4 files changed, 175 insertions(+), 2 deletions(-) > > > > -- > > 2.25.0 > >
Hi Daniel, On Wed, 7 Sept 2022 at 01:29, Daniel Vetter <daniel@ffwll.ch> wrote: > > On Fri, Aug 19, 2022 at 01:54:31PM +0530, Sumit Garg wrote: > > Hi Olivier, > > > > On Fri, 12 Aug 2022 at 20:01, Olivier Masse <olivier.masse@nxp.com> wrote: > > > > > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > > > shared memory from a dmabuf file descriptor. > > > This new ioctl will allow the Linux Kernel to register a buffer > > > to be used by the Secure Data Path OPTEE OS feature. > > > > > > Please find more information here: > > > https://static.linaro.org/connect/san19/presentations/san19-107.pdf > > > > > > Patch tested on Hikey 6220. > > > > > > > AFAIU, for the OP-TEE SDP feature to work you need to have a DMA-BUF > > heap driver for allocating secure buffers through exposed chardev: > > "/dev/dma_heap/sdp". Have you tested it with some out-of-tree driver > > as I can't find it upstream? Also, do you plan to push that upstream > > as well? > > > > BTW, please add a changelog while sending newer patch-set versions. > > Also after the huge discussion last year dma-buf are agreed to be under > the "you need an open source userspace for any new uapi using them" rule > that all gpu drivers are under. > > Does this exist here? There is already an open source userspace test application using it here [1] [2] demonstrating its use-case. I think that should be sufficient. [1] https://github.com/OP-TEE/optee_test/blob/master/host/xtest/sdp_basic.c [2] https://github.com/OP-TEE/optee_test/blob/master/host/xtest/sdp_basic.h -Sumit > -Daniel > > > > > -Sumit > > > > > Etienne Carriere (1): > > > tee: new ioctl to a register tee_shm from a dmabuf file descriptor > > > > > > drivers/tee/tee_core.c | 38 +++++++++++++++ > > > drivers/tee/tee_shm.c | 99 +++++++++++++++++++++++++++++++++++++++- > > > include/linux/tee_drv.h | 11 +++++ > > > include/uapi/linux/tee.h | 29 ++++++++++++ > > > 4 files changed, 175 insertions(+), 2 deletions(-) > > > > > > -- > > > 2.25.0 > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
On Thu, 8 Sept 2022 at 14:48, Olivier Masse <olivier.masse@nxp.com> wrote: > > Hi Sumit > > On ven., 2022-08-19 at 13:54 +0530, Sumit Garg wrote: > > Caution: EXT Email > > > > Hi Olivier, > > > > On Fri, 12 Aug 2022 at 20:01, Olivier Masse <olivier.masse@nxp.com> > > wrote: > > > > > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > > > shared memory from a dmabuf file descriptor. > > > This new ioctl will allow the Linux Kernel to register a buffer > > > to be used by the Secure Data Path OPTEE OS feature. > > > > > > Please find more information here: > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstatic.linaro.org%2Fconnect%2Fsan19%2Fpresentations%2Fsan19-107.pdf&data=05%7C01%7Colivier.masse%40nxp.com%7C05071ff1c28044ab740908da81bc44e2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637964942860947359%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nYLb2iMoJExdKEg4CL4eW5%2FQ%2Bqqj4Iw1TxFsd1UqWW0%3D&reserved=0 > > > > > > Patch tested on Hikey 6220. > > > > > > > AFAIU, for the OP-TEE SDP feature to work you need to have a DMA-BUF > > heap driver for allocating secure buffers through exposed chardev: > > "/dev/dma_heap/sdp". Have you tested it with some out-of-tree driver > > as I can't find it upstream? Also, do you plan to push that upstream > > as well? > > It has been tested with linaro,secure-heap reserved dma heap memory > which is also in review for upstream. Can you provide the corresponding reference? Also, do keep OP-TEE ML in CC if you send any new iteration for that patch. -Sumit > > > > > BTW, please add a changelog while sending newer patch-set versions. > > > > -Sumit > > > > > Etienne Carriere (1): > > > tee: new ioctl to a register tee_shm from a dmabuf file > > > descriptor > > > > > > drivers/tee/tee_core.c | 38 +++++++++++++++ > > > drivers/tee/tee_shm.c | 99 > > > +++++++++++++++++++++++++++++++++++++++- > > > include/linux/tee_drv.h | 11 +++++ > > > include/uapi/linux/tee.h | 29 ++++++++++++ > > > 4 files changed, 175 insertions(+), 2 deletions(-) > > > > > > -- > > > 2.25.0 > > >