mbox series

[for,6.1,0/4] vivid crash fixes

Message ID 20221017144628.489271-1-hverkuil-cisco@xs4all.nl
Headers show
Series vivid crash fixes | expand

Message

Hans Verkuil Oct. 17, 2022, 2:46 p.m. UTC 
This series fixes a number of vivid crashes, usually due to insufficient
checking of userspace values. 

While the v4l2-dv-timings.c patch is not vivid specific, it is only
vivid that can crash if bad values are passed. For actual hardware
drivers bad values will just mean that the receiver is not able to
lock to the video signal.

The videodev2.h patch is there to avoid using interlaced blanking
values if the 'interlaced' flag isn't set, it's mostly for userspace
to avoid applications that use this define to return wrong values.

Regards,

        Hans

Hans Verkuil (4):
  vivid: s_fbuf: add more sanity checks
  vivid: dev->bitmap_cap wasn't freed in all cases
  v4l2-dv-timings: add sanity checks for blanking values
  videodev2.h: V4L2_DV_BT_BLANKING_HEIGHT should check 'interlaced'

 drivers/media/test-drivers/vivid/vivid-core.c | 22 +++++++++++++++
 drivers/media/test-drivers/vivid/vivid-core.h |  2 ++
 .../media/test-drivers/vivid/vivid-vid-cap.c  | 27 ++++++++++++++-----
 drivers/media/v4l2-core/v4l2-dv-timings.c     | 14 ++++++++++
 include/uapi/linux/videodev2.h                |  3 ++-
 5 files changed, 61 insertions(+), 7 deletions(-)