| Message ID | 20240327231710.53188-1-git@luigi311.com |
|---|---|
| Headers | show |
| Series | v2: imx258 improvement series | expand |
On 28/03/2024 00:16, git@luigi311.com wrote: > From: Luigi311 <git@luigi311.com> > > Resend due to email message limits being exceeded. > > v2 changes: Please mark your patches correctly. Use b4 or -v2 for format-patch. Best regards, Krzysztof
On Wednesday, March 27, 2024 11:16:46 PM UTC git@luigi311.com wrote:
> From: Luigi311 <git@luigi311.com>
The Linux kernel does not allow anonymous (or pseudonymous) contributions. You
should use your real first and last name.
See section 1.5 in "A guide to the Kernel Development Process":
https://www.kernel.org/doc/html/v6.8/process/1.Intro.html#licensing
On 3/29/24 21:51, Dang Huynh wrote: > On Wednesday, March 27, 2024 11:16:46 PM UTC git@luigi311.com wrote: >> From: Luigi311 <git@luigi311.com> > > The Linux kernel does not allow anonymous (or pseudonymous) contributions. You > should use your real first and last name. > > See section 1.5 in "A guide to the Kernel Development Process": > https://www.kernel.org/doc/html/v6.8/process/1.Intro.html#licensing > > Ok I've changed my sign off to my real first and last name for the next revision
From: Luigi311 <git@luigi311.com> Resend due to email message limits being exceeded. v2 changes: - Add use macros patch - Add support for powerdown gpio patch - Add support for reset gpio patch - Dropped Add support for long exposure modes patch - Implemented feedback from Jacopo Mondi - media: i2c: imx258: Add regulator control - media: i2c: imx258: Add support for 24MHz clock - media: i2c: imx258: Add support for running on 2 CSI data lanes - media: i2c: imx258: Add get_selection for pixel array information - media: i2c: imx258: Issue reset before starting streaming - media: i2c: imx258: Set pixel_rate range to the same as the value - dt-bindings: media: imx258: Add alternate compatible strings - media: i2c: imx258: Change register settings for variants of the sensor - media: i2c: imx258: Make HFLIP and VFLIP controls writable This adds a few more patches and drops one. The long exposure mode patch was dropped due to the bug that Jacopo found. The powerdown and reset gpio patches were added as that fixes support for the Pinephone Pro, without them the sensor doesnt initialize correctly. Tested on a Pinephone Pro by forcing 24 mhz clock and was able to access all 3 resolutions. The two lower resolutions had some artifacts but that is expected as more changes are required to fix them for the Pinephone Pro specifically, kept all registers the same as Dave's original patch since that works on dedicated imx258 hardware and the artifacts are PPP specific so it shouldnt be a regression. v1 This is a set of patches for imx258 that allow it to work with alternate clock frequencies, over either 2 or 4 lanes, and generally adding flexibility to the driver. Tested with an IMX258 module from Soho Enterprises that has a 24MHz oscillator. Both 2 and 4 lane configurations work with correct link frequencies and pixel rates. Jacopo has tested on a PinePhone Pro which has an ~19.2MHz clock fed from the SoC, He confirms that the two lower resolution modes work, but not the full res mode. Comparing to the BSP it looks like they have some weird clock configuration in the 4208x3120 mode (nominally 1224Mb/s/lane instead of 1267). As it has never previously worked directly with the mainline driver this isn't a regression but may indicate that there is a need for support of additional link frequencies in the future. The last patch that makes HFLIP and VFLIP configurable may be contentious as I've retained the default configuration of inverted from the original driver. I know this was discussed recently, but I can't recall the final outcome. I am relying on someone from Intel testing this out, as correcting the cropping and supporting flips has changed the Bayer order. Seeing as this is all above board in V4L2 terms I really hope that the layers above it behave themselves. Cheers Dave Dave Stevenson (20): media: i2c: imx258: Remove unused defines media: i2c: imx258: Make image geometry meet sensor requirements media: i2c: imx258: Disable digital cropping on binned modes media: i2c: imx258: Remove redundant I2C writes. media: i2c: imx258: Add regulator control media: i2c: imx258: Make V4L2_CID_VBLANK configurable. media: i2c: imx258: Split out common registers from the mode based ones media: i2c: imx258: Add support for 24MHz clock media: i2c: imx258: Add support for running on 2 CSI data lanes media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure media: i2c: imx258: Add get_selection for pixel array information media: i2c: imx258: Allow configuration of clock lane behaviour media: i2c: imx258: Correct max FRM_LENGTH_LINES value media: i2c: imx258: Issue reset before starting streaming media: i2c: imx258: Set pixel_rate range to the same as the value media: i2c: imx258: Support faster pixel rate on binned modes dt-bindings: media: imx258: Rename to include vendor prefix dt-bindings: media: imx258: Add alternate compatible strings media: i2c: imx258: Change register settings for variants of the sensor media: i2c: imx258: Make HFLIP and VFLIP controls writable Luigi311 (3): drivers: media: i2c: imx258: Use macros drivers: media: i2c: imx258: Add support for powerdown gpio drivers: media: i2c: imx258: Add support for reset gpio .../i2c/{imx258.yaml => sony,imx258.yaml} | 12 +- MAINTAINERS | 2 +- drivers/media/i2c/imx258.c | 1147 +++++++++++------ 3 files changed, 744 insertions(+), 417 deletions(-) rename Documentation/devicetree/bindings/media/i2c/{imx258.yaml => sony,imx258.yaml} (88%)