| Message ID | 20240501-fix-ipu6-v2-0-a5629a37a0fb@chromium.org |
|---|---|
| Headers | show |
| Series | media: Fix compilations with !ACPI !PM and !OF | expand |
Hi Ricardo, On Wed, May 01, 2024 at 01:08:08PM +0000, Ricardo Ribalda wrote: > The current media-stating has some errors when configurations are > missing. Fix that. > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > Changes in v2: > - Remove missing __maybe_unused (Thanks Hidenori) > - Include https://patchwork.linuxtv.org/project/linux-media/patch/20240430213633.23767-2-laurent.pinchart@ideasonboard.com/ > - Link to v1: https://lore.kernel.org/r/20240430-fix-ipu6-v1-0-9b31fbbce6e4@chromium.org Thanks for these! I'll submit the PR for these probably today, with another IPU6 fix.
Em Wed, 01 May 2024 13:08:09 +0000 Ricardo Ribalda <ribalda@chromium.org> escreveu: > The driver can only match the device vide the DT table, so the table > should always be used, of_match_ptr does not make sense here. > > Fixes: > drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=] Be careful here: Fixes: <patch> is a tag used by stable people to identify if a patch needs to be backported. Using a Fixes: may cause such scripts to break. (it caused a problem on my apply patch script, as it does reorder fixes tag). No need to resend it, as I can fix it when applying, but next time please use something like: It fixes this warning: drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=] (or some other similar word that won't be using a defined meta tag with a different meaning). Regards, Mauro > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c > index bd2bbb53070e..c590e26fe2cf 100644 > --- a/drivers/media/platform/broadcom/bcm2835-unicam.c > +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c > @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver = { > .driver = { > .name = UNICAM_MODULE_NAME, > .pm = pm_ptr(&unicam_pm_ops), > - .of_match_table = of_match_ptr(unicam_of_match), > + .of_match_table = unicam_of_match, > }, > }; > >
The current media-stating has some errors when configurations are missing. Fix that. Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- Changes in v2: - Remove missing __maybe_unused (Thanks Hidenori) - Include https://patchwork.linuxtv.org/project/linux-media/patch/20240430213633.23767-2-laurent.pinchart@ideasonboard.com/ - Link to v1: https://lore.kernel.org/r/20240430-fix-ipu6-v1-0-9b31fbbce6e4@chromium.org --- Laurent Pinchart (1): media: bcm2835-unicam: Include v4l2-subdev.h Ricardo Ribalda (4): media: bcm2835-unicam: Fix build with !PM media: intel/ipu6: Switch to RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS media: intel/ipu6: Fix direct dependency Kconfig error media: intel/ipu6: Fix build with !ACPI drivers/media/pci/intel/Kconfig | 3 +- drivers/media/pci/intel/ipu-bridge.c | 66 +++++++++++++++++------- drivers/media/pci/intel/ipu6/ipu6.c | 4 +- drivers/media/platform/broadcom/bcm2835-unicam.c | 3 +- 4 files changed, 53 insertions(+), 23 deletions(-) --- base-commit: a1c6d22421501fc1016b99ac8570a1030714c70f change-id: 20240430-fix-ipu6-84d4d5515452 Best regards,