| Message ID | 20250403-uvc-orientation-v1-0-1a0cc595a62d@chromium.org |
|---|---|
| Headers | show |
| Series | media: uvcvideo: Add support for V4L2_CID_CAMERA_SENSOR_ORIENTATION | expand |
Hi Rob On Fri, 4 Apr 2025 at 21:36, Rob Herring <robh@kernel.org> wrote: > > On Thu, Apr 03, 2025 at 07:16:16PM +0000, Ricardo Ribalda wrote: > > For some devices, such as cameras, the OS needs to know where they are > > mounted. > > Do you have a usecase that's not a camera? I personally do not have other use cases, but I suspect that it could be useful for more people. The original proposal was more generic and "inspired" in _PLD: https://lore.kernel.org/linux-devicetree/20241212-usb-orientation-v1-1-0b69adf05f37@chromium.org/ You suggested using the camera's orientation. > > > > > ACPI has a property for this purpose, which is parsed by > > acpi_get_physical_device_location(): > > https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/06_Device_Configuration/Device_Configuration.html#pld-physical-location-of-device > > > > In DT we have similar property for video-interface-devices called > > orientation: > > Documentation/devicetree/bindings/media/video-interface-devices.yaml > > > > Add a new property orientation for usb-devices that matches the already > > existing orientation property of video-interface-devices. > > > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > > --- > > Documentation/devicetree/bindings/usb/usb-device.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/usb-device.yaml b/Documentation/devicetree/bindings/usb/usb-device.yaml > > index da890ee60ce6e71a11910c565b6f805470782e4f..bbcda28ec7d5695307efa797f57180044afda77f 100644 > > --- a/Documentation/devicetree/bindings/usb/usb-device.yaml > > +++ b/Documentation/devicetree/bindings/usb/usb-device.yaml > > This is a binding for *all* USB devices. This property should only be > added for devices where it makes sense. Can you provide some examples of how I can do this? > > > @@ -42,6 +42,10 @@ properties: > > port to which this device is attached. The range is 1-255. > > maxItems: 1 > > > > + orientation: > > + description: If present, specifies the orientation of the usb device. > > + $ref: /schemas/media/video-interface-devices.yaml#/properties/orientation > > Reference the schema from the top level and drop > '/properties/orientation'. > > What about 'rotation'? Seems like you'd want that too. At this moment I do not have a usecase for that. But sure, once I need it I will add it the same way. In the last thread I proposed Sakari to use: + image-sensor: + description: Video interface properties associated to USB cameras, + typically UVC compliant. + allOf: + - $ref: /schemas/media/video-interface-devices.yaml# + But he preferred to add orientation instead. Either ways work for me. > > > + > > "#address-cells": > > description: should be 1 for hub nodes with device nodes, > > should be 2 for device nodes with interface nodes. > > @@ -101,6 +105,7 @@ examples: > > device@2 { > > compatible = "usb123,4567"; > > reg = <2>; > > + orientation = <0>; > > }; > > > > device@3 { > > > > -- > > 2.49.0.504.g3bcea36a83-goog > >
The ACPI has ways to annotate the location of a USB device. Wire that annotation to a v4l2 control. To support all possible devices, add a way to annotate USB devices on DT as well. The original binding discussion happened here: https://lore.kernel.org/linux-devicetree/20241212-usb-orientation-v1-1-0b69adf05f37@chromium.org/ This set includes a couple of patches that are "under review" but conflict. Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- Ricardo Ribalda (8): media: uvcvideo: Fix deferred probing error media: uvcvideo: Use dev_err_probe for devm_gpiod_get_optional media: v4l: fwnode: Support acpi devices for v4l2_fwnode_device_parse media: ipu-bridge: Use v4l2_fwnode_device_parse helper dt-bindings: usb: usb-device: Add orientation media: uvcvideo: Factor out gpio functions to its own file media: uvcvideo: Add support for V4L2_CID_CAMERA_ORIENTATION media: uvcvideo: Do not create MC entities for virtual entities .../devicetree/bindings/usb/usb-device.yaml | 5 + drivers/media/pci/intel/ipu-bridge.c | 32 +---- drivers/media/usb/uvc/Makefile | 3 +- drivers/media/usb/uvc/uvc_ctrl.c | 21 +++ drivers/media/usb/uvc/uvc_driver.c | 159 +++++---------------- drivers/media/usb/uvc/uvc_entity.c | 11 ++ drivers/media/usb/uvc/uvc_fwnode.c | 73 ++++++++++ drivers/media/usb/uvc/uvc_gpio.c | 123 ++++++++++++++++ drivers/media/usb/uvc/uvcvideo.h | 21 +++ drivers/media/v4l2-core/v4l2-fwnode.c | 58 +++++++- include/linux/usb/uvc.h | 3 + 11 files changed, 349 insertions(+), 160 deletions(-) --- base-commit: 4e82c87058f45e79eeaa4d5bcc3b38dd3dce7209 change-id: 20250403-uvc-orientation-5f7f19da5adb Best regards,