From patchwork Mon Mar 4 20:29:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159608 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4180607jad; Mon, 4 Mar 2019 12:29:35 -0800 (PST) X-Google-Smtp-Source: APXvYqwODz0iYPPj6QqN+qzVXu1ao03EdbggWYUBHuKo06/6P4wbesJMd+a0tGDhliTwc8dzgvkN X-Received: by 2002:a63:1c42:: with SMTP id c2mr20090559pgm.265.1551731375480; Mon, 04 Mar 2019 12:29:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551731375; cv=none; d=google.com; s=arc-20160816; b=tDJwHe5CVAIr5d3YaYMRXkKAr33cxUe84geSg6yQ4YZRU86ScY3GaD2QnDoZs4J052 oK6mae4XyRdu5tvIPoA4rHriDuH04aPJ/Bdwo5QHXykzLvXC2uQpJtuv9QERnr1Vi9TW 8u86/8dqjYZGthKznf/1Vk04YvvdqF7SCM6gL18yOeJKl/Z3J9mQ+5CZmFSoIBYgUiI/ 5iNyZqAiMTgfwB4ak49WKU2o6hS9lIl7SLB0C2K0I5EAGgclZinP5jtiO0ac+ZNcUbxt dkixUA5aBnw9PEieDPMubOWaB1HRJU57MQntxPilMrRg8bXf6qHuOuhp9qwOyCph6pfL gULQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ufLCzqjoNB3IIggv6uYfDqhbGbgqnMixrM00vOpq3sg=; b=uBQ1faWZIdDbPprCvpyvluKoW9lNLyH1BtzrePZjTkEg+XuzXtAVmQrNab81CSre35 nJ9pLL4SnYytD/2bHhtrOZyirH9ibVmiJkL+CyK2M2UXEunykW45s3qBqBVHWhG7peGe t04jvybMi8y+NcN9feQ+iCHTH2gLqNSeHkLB+STZRe/NuVO2Z8d3P+6mLGM5q2soGiMT q/3grhxt4rMmGBolp2URhTsQMpAH0fx9hsrbEiWZIOVfSFUd1B8cdCW+O8YCn4QsVM8G XxjrRsuKAyDVYaZynR7MPYCFOtxDiSs7oLGlBISsKOmAXI2pmb+jrGryZnTECQcYS5yP PpsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5si5903252pgk.401.2019.03.04.12.29.35; Mon, 04 Mar 2019 12:29:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726425AbfCDU3e (ORCPT + 3 others); Mon, 4 Mar 2019 15:29:34 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:33047 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbfCDU3e (ORCPT ); Mon, 4 Mar 2019 15:29:34 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1MfL5v-1hTeGI1x75-00gsto; Mon, 04 Mar 2019 21:29:21 +0100 From: Arnd Bergmann To: Sakari Ailus , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Arnd Bergmann , Yong Zhi , Tomasz Figa , Tian Shu Qiu , Bingbu Cao , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: staging/intel-ipu3: mark PM function as __maybe_unused Date: Mon, 4 Mar 2019 21:29:10 +0100 Message-Id: <20190304202920.1845797-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:Oduro/Z8h4f5zL2ki3+FwzaOFf6y8ct9rHJB4s1ikIYed/yz0Sx KyNx1kehdv+RMNHC2Chnl7puMV5q0Z325d9kP+itNV5O7uUYh/px+s6UBM1YpQL83cTNAbN MbcOM+uVYMwkgKveOfkeJ/CwBUY/rRM4BeXqVR3cEQGgCD6ZIW6UNcINFcUnVMnzme/LU0E WO3VPEO9iT4cv7ksFDNIg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:it6ue09fJrc=:xsYpVCAeJEPrGT9Ih0EeyT KGREskLgibWH0MrImXPTPEb8ayfoMN/Ekj5+mk54XxFXJoZUeseub/g3bMNjazi3Q407JqrSM RHfSlRCZby9Xni073jL4vWCQvMbbb51kso6Tp5VUfv3sjUlcc6UDQ2n6avNmzAvYA75eNoqnB Gq9hic5EpjPk7yMwH5GBYAhfvXsqWMcHCVQAT4xBTIZYnOULgyfThX66ETOyN39ZBnuFuTsdt h65vR+DD+DEXjMOy7P3XrGp7CVoQGtOWUoa9ezym+xZzebjstHkPpe7xxyVjO9WBckunq6w6B AQY3dzFRc8mN0KLhO+XAeMxvzIVyLluGXyODgmFqxWFLgPDMpvQljtD1caERTKkWlwE6vREMJ 5eZAfxeWeInEfbIfcS1Od/U00BZTTBHsUqUe8Z4R+KpHFMcn3tlKjpQYTXbzCbaKeUgiLIro7 +SXTTHtzYCHNblZhwUtt9Yuri23kSMiBoB5bGuutlKeES/gfhj0yKIb8wfEwpsPUv2Q6tmGmk ZZ6d9hgkqD5BNq/QZwbuOOQtW2AQTcRbeM6xsthkLm4U3BMB3XEzRAqYs5ZA2hZRmKBG41D/s UQwN1K0C/qplcRVeRrFZ7x7vR2oFdNaMdq3T2MwkENOLANwfL5tS0vtFX+pjHH9sILz/vPYT5 bUInKgmC1dA2r5mTIWZYM68JYPLoR12Zql6v40NQ0+mAsW5ppiOz3r6yWudQg5s4mNhxC89bc If3oaMpdEzL75UNQO76T1L6W63qP5OJHWvaDfA== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The imgu_rpm_dummy_cb() looks like an API misuse that is explained in the comment above it. Aside from that, it also causes a warning when power management support is disabled: drivers/staging/media/ipu3/ipu3.c:794:12: error: 'imgu_rpm_dummy_cb' defined but not used [-Werror=unused-function] The warning is at least easy to fix by marking the function as __maybe_unused. Fixes: 7fc7af649ca7 ("media: staging/intel-ipu3: Add imgu top level pci device driver") Signed-off-by: Arnd Bergmann --- drivers/staging/media/ipu3/ipu3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c index d575ac78c8f0..d00d26264c37 100644 --- a/drivers/staging/media/ipu3/ipu3.c +++ b/drivers/staging/media/ipu3/ipu3.c @@ -791,7 +791,7 @@ static int __maybe_unused imgu_resume(struct device *dev) * PCI rpm framework checks the existence of driver rpm callbacks. * Place a dummy callback here to avoid rpm going into error state. */ -static int imgu_rpm_dummy_cb(struct device *dev) +static __maybe_unused int imgu_rpm_dummy_cb(struct device *dev) { return 0; }