From patchwork Thu Dec 3 23:17:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 336966 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp701960ilb; Thu, 3 Dec 2020 15:19:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjXCieGnvenZMop5DQbHyfz8krwMoMpHn4z9jrJ6+XosDh1BOsSxNKxT/p1y0d9PvfzirN X-Received: by 2002:a05:6402:456:: with SMTP id p22mr5034179edw.26.1607037548829; Thu, 03 Dec 2020 15:19:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607037548; cv=none; d=google.com; s=arc-20160816; b=d9TA7wb2UjZGgQ/oeYtNd7+advF11SAbalSsFH9ZW0PhpDvzELS+CKMViy0ESNCr9Q McLdQTH848JwbKlmioZnTC98orJ1ARGTDeSGdLlisjr2DjcXvyeY8NQbGs858NjSOukU Op+EWtE2wos3viaJmL909dFLTHqk64jr9vdX1wjV7e4Qv1sLjGKZmrrls0UkeI572iyA hqBdbcdMXEGBG4HVjF4MwvsKRZvtVkHJ4YBg7qli0dTUinhFGbDXJCQvawQiAcPw4jVE uPaNWIZ7duOaO/UTQvzgF/nxA5PdzmefE509P+P8oq0H9HQu1gOFkyvDkSnq1ewsC+Hk Ws4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FX5TcaXGlz+7QKBQcZWDXcvJU3uatHMT6L3uDxXoA28=; b=MMuoip5mxSmo/4qY7soWEgLrf+XS6RP7qeDNaMcY0Pt35agFHjZQkgm5zz8IO9nd30 h+sSXVPyMSfJKlvHbf2dsH198qA+3jiVYCG+o0G63oz+VXUV2RHoAnGbzATN0s/CnnAP ijI/2AGFA+40CR3T+eaLuvf4s5IFvAtxi499ER8rGkQruS9dXPwDdx+KUqYo6EerVNRH J5dCSFJrJBdy5G/Ebb2dsQEPv2C0PTiYYooG1TOg3h5C93PWpr4f4IrU51p9XQ4U6M4b rxADzikmgNbn4Te3ElyISL7hQYE2meNu8kJGH703zMtitsqK1nubCEc9b2HHTdh0RVuQ H5Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x13si273914ejo.619.2020.12.03.15.19.08; Thu, 03 Dec 2020 15:19:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730128AbgLCXR7 (ORCPT + 4 others); Thu, 3 Dec 2020 18:17:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:36730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729801AbgLCXR7 (ORCPT ); Thu, 3 Dec 2020 18:17:59 -0500 From: Arnd Bergmann Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Sean Young , Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: rc: select CONFIG_BITREVERSE where needed Date: Fri, 4 Dec 2020 00:17:03 +0100 Message-Id: <20201203231714.1484408-1-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann A number of remote control drivers require the bitreverse helper, and run into a link error when it is disabled: arm-linux-gnueabi-ld: drivers/media/rc/img-ir/img-ir-nec.o: in function `img_ir_nec_scancode': img-ir-nec.c:(.text+0x10c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld: drivers/media/rc/img-ir/img-ir-nec.o: in function `img_ir_nec_filter': img-ir-nec.c:(.text+0x2dc): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld: drivers/media/usb/cx231xx/cx231xx-input.o: in function `get_key_isdbt': cx231xx-input.c:(.text+0x38c): undefined reference to `byte_rev_table' arm-linux-gnueabi-ld: drivers/media/usb/em28xx/em28xx-input.o: in function `em28xx_get_key_em_haup': em28xx-input.c:(.text+0x1704): undefined reference to `byte_rev_table' Signed-off-by: Arnd Bergmann --- drivers/media/rc/Kconfig | 2 ++ drivers/media/rc/img-ir/Kconfig | 1 + drivers/media/usb/cx231xx/Kconfig | 1 + drivers/media/usb/em28xx/Kconfig | 1 + 4 files changed, 5 insertions(+) -- 2.27.0 Acked-by: Sean Young diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig index 2c0ee2e5b446..8a4b4040be45 100644 --- a/drivers/media/rc/Kconfig +++ b/drivers/media/rc/Kconfig @@ -92,6 +92,7 @@ config IR_SONY_DECODER config IR_SANYO_DECODER tristate "Enable IR raw decoder for the Sanyo protocol" depends on RC_CORE + select BITREVERSE help Enable this option if you have an infrared remote control which @@ -101,6 +102,7 @@ config IR_SANYO_DECODER config IR_SHARP_DECODER tristate "Enable IR raw decoder for the Sharp protocol" depends on RC_CORE + select BITREVERSE help Enable this option if you have an infrared remote control which diff --git a/drivers/media/rc/img-ir/Kconfig b/drivers/media/rc/img-ir/Kconfig index 5c0508f2719f..a80cfcd87a95 100644 --- a/drivers/media/rc/img-ir/Kconfig +++ b/drivers/media/rc/img-ir/Kconfig @@ -30,6 +30,7 @@ config IR_IMG_HW config IR_IMG_NEC bool "NEC protocol support" depends on IR_IMG_HW + select BITREVERSE help Say Y here to enable support for the NEC, extended NEC, and 32-bit NEC protocols in the ImgTec infrared decoder block. diff --git a/drivers/media/usb/cx231xx/Kconfig b/drivers/media/usb/cx231xx/Kconfig index 2fe2b2d335ba..b80661b8375f 100644 --- a/drivers/media/usb/cx231xx/Kconfig +++ b/drivers/media/usb/cx231xx/Kconfig @@ -18,6 +18,7 @@ config VIDEO_CX231XX_RC bool "Conexant cx231xx Remote Controller additional support" depends on RC_CORE=y || RC_CORE=VIDEO_CX231XX depends on VIDEO_CX231XX + select BITREVERSE default y help cx231xx hardware has a builtin RX/TX support. However, a few diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig index f2031a933e54..8a24731b373a 100644 --- a/drivers/media/usb/em28xx/Kconfig +++ b/drivers/media/usb/em28xx/Kconfig @@ -77,5 +77,6 @@ config VIDEO_EM28XX_RC depends on VIDEO_EM28XX depends on !(RC_CORE=m && VIDEO_EM28XX=y) default VIDEO_EM28XX + select BITREVERSE help Enables Remote Controller support on em28xx driver.