From patchwork Thu Jun 3 07:02:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 453219 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp28102jao; Thu, 3 Jun 2021 00:02:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygtfUjM4ShbzpxSMyC4kFDu7hR1a+XIxOjkTlXgXd+eiT5Q64kHRrkehKANs736MIcVHLo X-Received: by 2002:aa7:dd98:: with SMTP id g24mr23742386edv.88.1622703768503; Thu, 03 Jun 2021 00:02:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622703768; cv=none; d=google.com; s=arc-20160816; b=uLtKMbXdQEKznR6UulDTZxOzYfq7bfPHvkamxQsf9DZy45BpOmeUPOElyShKGOUNh8 5xoW7F9vMX6R5jnV4tJcQ17GladjjMZFgMmomeBLnZUkhvbVgO3/O+V7yTJ9B1WG7cov X1cWk/D3C0ClRPXKaFmXjF7SRITHK8WM7vbVgrAvs/8EU+hRmDan+MEry5OROUL1g55M pStxh96iOchVokjFLu6H6uMK9MxU3aY1x2HNqTcMuqZFufT0esFYm9O6bA+qImwruRi+ FEEn/cmMSLDhRDIGBkVyUfB9d4jzY0DXyeWLGefMM/Nm58u2Jsb6uHZ7h/Nzzw3lLExh BJ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6Agf3pi9ShctqEqh+xuNLJehIMBiksb2KxO2bjDh9iI=; b=ycsBT3BxoXCE8crWhGueMeduggz7RL1DkEhf3Q3CSw17seygCUr4CZ766Sryu/P0AE fr2LzHBGH2ZKLgyHI0jSFiWuZPpT9wePOWgX/fsVDlDEoNAUpZKya7uHLGODsV/8grlE +WzJYh7PvIt2u8VS/r/ueqEuKPhbLR07miVWzB0bnYM0280HmlBNUSOEaTYanhdkJ7uR A5Vm3POBhivabjHkqFc16/GxV87rF/eUnuK62vwTJzT7S49Nc5ntIowj5us8IzJliN+l 1a5CUJvFgKizrO+PXxOPbcoWXfMYjOKz+OKw8iLGE05jvAALCXrTyrFHAaVtWqCXFjKS 6a+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si1657307ejc.105.2021.06.03.00.02.48; Thu, 03 Jun 2021 00:02:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbhFCHEW (ORCPT + 4 others); Thu, 3 Jun 2021 03:04:22 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:3397 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhFCHEW (ORCPT ); Thu, 3 Jun 2021 03:04:22 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4FwcF72cGZz5xKV; Thu, 3 Jun 2021 14:58:51 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 15:02:36 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 15:02:36 +0800 From: Zhen Lei To: Sean Young , Mauro Carvalho Chehab , linux-media CC: Zhen Lei Subject: [PATCH 1/1] media: imon: use DEVICE_ATTR_RW() helper macro Date: Thu, 3 Jun 2021 15:02:30 +0800 Message-ID: <20210603070230.11332-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Use DEVICE_ATTR_RW() helper macro instead of DEVICE_ATTR(), which is simpler and more readable. Due to the names of the read and write functions of the sysfs attribute is normalized, there is a natural association. Signed-off-by: Zhen Lei --- drivers/media/rc/imon.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) -- 2.26.0.106.g9fadedd diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c index a7962ca2ac8e3da..2ca4e86c7b9f1d7 100644 --- a/drivers/media/rc/imon.c +++ b/drivers/media/rc/imon.c @@ -780,7 +780,7 @@ static int send_set_imon_clock(struct imon_context *ictx, /* * These are the sysfs functions to handle the association on the iMON 2.4G LT. */ -static ssize_t show_associate_remote(struct device *d, +static ssize_t associate_remote_show(struct device *d, struct device_attribute *attr, char *buf) { @@ -800,7 +800,7 @@ static ssize_t show_associate_remote(struct device *d, return strlen(buf); } -static ssize_t store_associate_remote(struct device *d, +static ssize_t associate_remote_store(struct device *d, struct device_attribute *attr, const char *buf, size_t count) { @@ -822,7 +822,7 @@ static ssize_t store_associate_remote(struct device *d, /* * sysfs functions to control internal imon clock */ -static ssize_t show_imon_clock(struct device *d, +static ssize_t imon_clock_show(struct device *d, struct device_attribute *attr, char *buf) { struct imon_context *ictx = dev_get_drvdata(d); @@ -848,7 +848,7 @@ static ssize_t show_imon_clock(struct device *d, return len; } -static ssize_t store_imon_clock(struct device *d, +static ssize_t imon_clock_store(struct device *d, struct device_attribute *attr, const char *buf, size_t count) { @@ -895,11 +895,8 @@ static ssize_t store_imon_clock(struct device *d, } -static DEVICE_ATTR(imon_clock, S_IWUSR | S_IRUGO, show_imon_clock, - store_imon_clock); - -static DEVICE_ATTR(associate_remote, S_IWUSR | S_IRUGO, show_associate_remote, - store_associate_remote); +static DEVICE_ATTR_RW(imon_clock); +static DEVICE_ATTR_RW(associate_remote); static struct attribute *imon_display_sysfs_entries[] = { &dev_attr_imon_clock.attr,