| Message ID | 20230403154800.215924-7-paul@crapouillou.net |
|---|---|
| State | Accepted |
| Commit | 3afb27d15f8ddaa5ce5781d18bb249c683d29260 |
| Headers | show |
| Series | iio: new DMABUF based API, v3 | expand |
On Mon, 3 Apr 2023 17:47:55 +0200 Paul Cercueil <paul@crapouillou.net> wrote: > Use the iio_dma_buffer_write() and iio_dma_buffer_space_available() > functions provided by the buffer-dma core, to enable write support in > the buffer-dmaengine code. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> > --- > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > index 592d2aa9044c..866c8b84bb24 100644 > --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c > +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > @@ -123,12 +123,14 @@ static void iio_dmaengine_buffer_release(struct iio_buffer *buf) > > static const struct iio_buffer_access_funcs iio_dmaengine_buffer_ops = { > .read = iio_dma_buffer_read, > + .write = iio_dma_buffer_write, > .set_bytes_per_datum = iio_dma_buffer_set_bytes_per_datum, > .set_length = iio_dma_buffer_set_length, > .request_update = iio_dma_buffer_request_update, > .enable = iio_dma_buffer_enable, > .disable = iio_dma_buffer_disable, > .data_available = iio_dma_buffer_data_available, > + .space_available = iio_dma_buffer_space_available, Follow through from earlier patch. I would prefer it to be obvious hers that the two callbacks above are identical. Easiest way to expose that detail is to set the callbacks to the same function, but then it perhaps needs a rename so it isn't specific to one of the other. Jonathan > .release = iio_dmaengine_buffer_release, > > .modes = INDIO_BUFFER_HARDWARE,
diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c index 592d2aa9044c..866c8b84bb24 100644 --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c @@ -123,12 +123,14 @@ static void iio_dmaengine_buffer_release(struct iio_buffer *buf) static const struct iio_buffer_access_funcs iio_dmaengine_buffer_ops = { .read = iio_dma_buffer_read, + .write = iio_dma_buffer_write, .set_bytes_per_datum = iio_dma_buffer_set_bytes_per_datum, .set_length = iio_dma_buffer_set_length, .request_update = iio_dma_buffer_request_update, .enable = iio_dma_buffer_enable, .disable = iio_dma_buffer_disable, .data_available = iio_dma_buffer_data_available, + .space_available = iio_dma_buffer_space_available, .release = iio_dmaengine_buffer_release, .modes = INDIO_BUFFER_HARDWARE,