From patchwork Wed Jul 5 06:49:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minjie Du X-Patchwork-Id: 699447 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451FAC001DD for ; Wed, 5 Jul 2023 06:50:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231594AbjGEGur (ORCPT ); Wed, 5 Jul 2023 02:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbjGEGu2 (ORCPT ); Wed, 5 Jul 2023 02:50:28 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2112.outbound.protection.outlook.com [40.107.255.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4885F19A8; Tue, 4 Jul 2023 23:49:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nCNPrWJ40aYDOJMD9npyNN0AZ6vzAq9BtRe0ws+7pcSVrqLuLvcRYLgLFDMipQF6TfGDMg6WPHLwraM9SDnpsYCpLgQu5djOxWvrJ5E0GmjPUd/VulTgPgQl1o/EFCFXdN57iqp7jwz6WJ3TzcYXqvfhD0zwdOq/v3s/Eg4VCHm8o5Og/nBKmmf7YD8p5stDHxhAWLpgLpjx+DOnv2hRnGPNNew8bvoaUqv+Nm7CfkGVumjdqZyzIC9W90FYIT+nNyYKyPjQeQCtgD5V1Bg61Ut12Y/cHDmOEUhlO41L8p0W8KaTsuQ5RhjxbDARKaRmohBxLnKgJVWu8UK3oRe1NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sXDH/6DTTLo+zICPLM6Nl+bZVNQETElZNZDf8Bxr/Dw=; b=gODN2CbTRhB710sTjGrEnPfjTZeXfeeA0hO/FicRbbFcrRE4rDz2wzyRjK6fpwDczHBgddJD8Db5h3rgHYH5/zMiTbkNZGAflQbYkiJ10R87mMGf849NtxJmRn/TAuMGX4jbuxEhi4kdzQHL7yPK2N/iYgkkPTJaCzngVw4MnFLyYjgYVmLGjXKcttVe3xIU1DFJwpHzm8jBfVGqhWSvmQajMZC3dyzCsLa9rsHaevtEycdpL5VhZhtGZEfPPlHJ4R21UhDBAeQX0Z41i3dL7r5IRgi586yPIFvqD7sPGqNkvnVzxC2rI0fO2o3ldBda/9DVqDB6yuVIKXNHGHhJnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sXDH/6DTTLo+zICPLM6Nl+bZVNQETElZNZDf8Bxr/Dw=; b=oW11tY4c5teWA0DKK835G+jRTHcVGydJipibsXwLdMMi/zu+cGd3b4Gkmc4S41yBnG7FmzDLSj2j+hIMoMQnxSTw+oOYeoSnfU3/RFMxgChNPB1LlLiR/rFUdIRwZWpATDO4Vi4m1uU6mE0i/KtrdED3105xHgAMtwjafpstVjCWP6gBNj84jVgBpeRjsXxlDWabvnEZjwQ8lrj3UbaDd2q5dLD01PuJpd5Wo78ubkM97ATp7zTT5BsQhUqnyZA9IYWo0ku03YSJ/raliAbX6+Eg6rL/EP1MGp1nZ+kplLSEPWUqqafbgWRBbo2C2VTJE10DyBCOwuy0KCTzyWAw4g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB4140.apcprd06.prod.outlook.com (2603:1096:4:f1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 5 Jul 2023 06:49:32 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.016; Wed, 5 Jul 2023 06:49:32 +0000 From: Minjie Du To: hverkuil@xs4all.nl, Mauro Carvalho Chehab , Stephen Rothwell , Minjie Du , linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-kernel@vger.kernel.org (open list) Cc: opensource.kernel@vivo.com Subject: [PATCH v2] drivers: saa7164: remove duplicate assignments Date: Wed, 5 Jul 2023 14:49:22 +0800 Message-Id: <20230705064922.10165-1-duminjie@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: TYCPR01CA0004.jpnprd01.prod.outlook.com (2603:1096:405::16) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB4140:EE_ X-MS-Office365-Filtering-Correlation-Id: 7bde4747-ba8e-4b48-0f30-08db7d23fceb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P+3XbwQAPe8BDdFzMqGjsx6/ID/EWmC5f+9xMyuigyAUkRmQCrcuuwTEZ6xRY4aNOOINIp3yqcZhA1CmNyl7QzfVwBM3B6jONYsohT/9apV+KyF0pHezk5lg0ngGt5tLeSj0gW7P0LGJdExn6YX1KC7bu+todAzQiYbUzUAty2yOGN1pFS52Mw4qSydSKzqwhUlYjw3x8VMDOgCuwpFrI+PJM83efDEBan3Pd6O3vYXobNiOiVIam1ZeHIzyoEQ7c/CMdDppynB/Y/SULJqLt3bElFj+xXJ5n7j3JWM1lC377f9uWHrUiiHKA4PP6b60GYTpp1cs0ecuLUUQ3oU6f/5i/BsTXmo0BPZQVyB4HtNs5zl0ZSkhsecn/a5JDQaNt/Eh3c7nLgeU8s6jvcJEDFciQ9GKD8Q7+feBmfizDMwJDL2X1cc30qs+IF4IpNRzgmwWhLIjhdgqkqOgetlayD35DhA6aoGe+2NzEsX1AyMxzto767lBsmL9dK0ksniFLM43Vxw9ufUfLRyDz1PiRe0u8FJhszfHIzPIKkiRg2IP+PNF1BgGJ+IYX3k3Q+7xeL0qxGlhpjo0qlcmmbNsjG3KkQK0LNruNEFI4yG5e1LqoJAc4MxwADXnCaBbXnp5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199021)(41300700001)(8936002)(8676002)(110136005)(36756003)(6486002)(4744005)(316002)(5660300002)(2906002)(66476007)(4326008)(66556008)(52116002)(6666004)(478600001)(6512007)(38100700002)(107886003)(38350700002)(186003)(86362001)(66946007)(2616005)(83380400001)(6506007)(1076003)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qpjr65LW1rnFAdw6dQzbhM1/WDWT8QVkz99NBXPwzEqHSsZvf5UZEvHBoyD5PJlml9aqJF5Jr1yLNwctRhCq42rudkgW7pRxx1zTCPI3QSYTCNgcKQHVYLWQHJo3wK0b6iE0sFYt3DM8sF4VWAbJWKplHUxet6ZfZSvsdJ2QsUK0RPs20RS/AEnK/FRX9kBDjLfoQ6zRj7zdRdG/fLXfCHgHFbdOH/3hmI7NthDBIQ3vUlp4SefnotHf+0IL8QlZJSdAVrbXng8N2UN66l+TSH0ti2IvZrMP8AfZ7JtN/haOsQ97MK3Qv+GdLkdQuT2yAWlA3Q+DS1JI0wn2ysVmfbvKuhE2dzCb5JcDtWdybyABhs3U/jtqvFVKolBGEw2eChforlCoUL1VmCKWMDc9NSr2XEFy/B0ZhHJ3oeuI1wLKEuME4scbI4mZr5qoxTMS3BqnGnsANf6oogZv+zIvGEuj0QLUbFbpABYFnAajj3QL/FreT8klByR7yfjQ7q0s1sMVytZjeDhARZ24OuhEiGeLPPYM+PouCwRjEQVo9s54dIIrA/aZu/9YMf52s5w4ZsZXZgaamEdFzrlSV9/hrd+989mmz3UIQRhZnqZN8CYhRB7stPIOSbYic91al2O9Kl1xcI1WWiQVLdHpTY/TMdFicb8Hle77DkNAWEjzb7zi1nIrjjDPSj9qiZXjkI71eA5ddL5rmjCkndSFdbw1K+fA3KiJ7Ro/oMO09O0Qj/012aMG8AKOYD/KnfLqZkli6x3V6x2TLYX4QPKaB9bjRm2Wl4H5mINel21FI4Vd4e6gxlTv8YbzvfRKscKMW0Ra/kI1FB7xkiG3FHmJGJLlFl6yhai49w4FOW/NnBHbTL7URXjnMTOCdoOjGisFjEOmc3D/Zj5g9SVZ11sREhnR/GJRhOUpuQ14frKErwc14/R0IVYwZMj8jP679tN5wh0fIr7Cn8Ka/bQOf4qIgZF0jHY5sjwuyQBr9bMYbKHIv13DT3LxDQ3gHUr9uURCENUf0QOhZ/L+Vpb5gmmqwOdf0289v1Ny8Cbg44lYxLu8Aif+YvOl5TEcqTmbVrNJdC1xO3hKRXgXRtSNg7XKOtpzj5oBjzGufdA7O00NhjoxPMZPpVyTb3CL5QoqWnf2csO27d1BEr5ZxJ3vapHm4SMXZJe22WoI+j0ut+dUWtVVuHzT6jElE9MrsXQ2iu8/mNf9874H9v31rDvltbfNfqZBVHteh7F+BZDaGGrSBMN+mO6xr1joI6W0RhAz3TTMo7P/6OPO5s+SZw9+o5r9muSKaZsVcBR807TN9eZMLU0y7h5pwgzsakDWkzI7AIYC72EDfDcw+/ifHwAEQspSDodKCQRmT6OXzTz1zOdhoS/loYQ/FjSUpidHybcWzs5SZcH32OiMWoqRL+vD482wppAeLYd266V91ZLDYTZzToYUIQCjajX/9cOFusY2BX67aLUb4cCPUtySQU/Z44WQtx8SafnO0TPEPlZwylKgc8o2VkN1krx68dG/iodqqMm40d3DERZU1M/feAvaWpgNHbUesAlFuxnyBszW/Pttzsw1MJb5aLLza/O1DhHs+JWh586R X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bde4747-ba8e-4b48-0f30-08db7d23fceb X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 06:49:32.5946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yCfEBaZRR7yJOOK+6xp+ELSRtn8D70zhVin0CGPJftrhKGMFEZkitu4YyQZC7LRosED/ELBEr6WbVWhNtpcVyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4140 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org make second_timeout avoid double assignment. Thank you for your reply. Signed-off-by: Minjie Du --- drivers/media/pci/saa7164/saa7164-fw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/saa7164/saa7164-fw.c b/drivers/media/pci/saa7164/saa7164-fw.c index 363689484..cc9f384f7 100644 --- a/drivers/media/pci/saa7164/saa7164-fw.c +++ b/drivers/media/pci/saa7164/saa7164-fw.c @@ -271,7 +271,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev) dprintk(DBGLVL_FW, "%s() Loader 1 has loaded.\n", __func__); first_timeout = SAA_DEVICE_TIMEOUT; - second_timeout = 60 * SAA_DEVICE_TIMEOUT; second_timeout = 100; err_flags = saa7164_readl(SAA_SECONDSTAGEERROR_FLAGS);