| Message ID | 20231204132323.22811-9-benjamin.gaignard@collabora.com |
|---|---|
| State | New |
| Headers | show
Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="DQGdEJLn" Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED6A9191; Mon, 4 Dec 2023 05:23:52 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1AFAC66071CC; Mon, 4 Dec 2023 13:23:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696231; bh=6AlqOx+FFImcfZDLMEeEUovXA4Sft7cnaCjngZduvsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQGdEJLnbAtvICwkzkiwILiCu5IFwCGI3sKELOnaQ4qA6uN+I1q949usc+7kddK47 1T1h+qb9y7tP7O6BmnN0dyLk7S3GuIlq0TUdEhECJt6//xOlguCvaPsCk1/urrQFuR A99ucfpNWRhBfrlpWCNn7I5kMJPhas7NFwhwsNDNXTyWFGcSnK5yCsCPB7r7CTwIjw YahM0Wd0SKKbJ5Z8RPCSvfej+gFaQMyS4JiQ+wy4p72PPBDUwCy5fcg1TzA/jjstM2 8yf1cVzOjIFQyWvlUv9KRj+Tx9paigAZMVKsM8YhFY9kAVp+4hTyzakBXHulctGw43 ROG7G9CFiDylg== From: Benjamin Gaignard <benjamin.gaignard@collabora.com> To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard <benjamin.gaignard@collabora.com>, Eugen Hristev <eugen.hristev@collabora.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev> Subject: [PATCH v2 08/36] media: atmel: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:55 +0100 Message-Id: <20231204132323.22811-9-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: <linux-media.vger.kernel.org> List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
| Series |
Clean up min_buffers_needed misusages
|
expand
|
diff --git a/drivers/staging/media/deprecated/atmel/atmel-isc-base.c b/drivers/staging/media/deprecated/atmel/atmel-isc-base.c index 468568b5bb7a..c18f3ba5ae1a 100644 --- a/drivers/staging/media/deprecated/atmel/atmel-isc-base.c +++ b/drivers/staging/media/deprecated/atmel/atmel-isc-base.c @@ -1871,7 +1871,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier) q->mem_ops = &vb2_dma_contig_memops; q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->lock = &isc->lock; - q->min_buffers_needed = 1; q->dev = isc->dev; ret = vb2_queue_init(q);
This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> CC: Eugen Hristev <eugen.hristev@collabora.com> CC: Nicolas Ferre <nicolas.ferre@microchip.com> CC: Alexandre Belloni <alexandre.belloni@bootlin.com> CC: Claudiu Beznea <claudiu.beznea@tuxon.dev> --- drivers/staging/media/deprecated/atmel/atmel-isc-base.c | 1 - 1 file changed, 1 deletion(-)