| Message ID | 20240405141411.1807189-14-panikiel@google.com |
|---|---|
| State | Accepted |
| Commit | e44749a05d0f57fc7a6e8c6a85df5825859bf216 |
| Headers | show |
| Series | Switch subdev dv timing callbacks to pad ops | expand |
Hi Paweł, Thanks for your work. On 2024-04-05 14:14:08 +0000, Paweł Anikiel wrote: > Use the pad variant for all (s|g|query)_dv_timings subdev calls, which > includes a pad argument. > > Signed-off-by: Paweł Anikiel <panikiel@google.com> Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c > index 073f70c6ac68..bb4b07bed28d 100644 > --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c > @@ -730,7 +730,8 @@ static int rvin_s_dv_timings(struct file *file, void *priv_fh, > struct v4l2_subdev *sd = vin_to_source(vin); > int ret; > > - ret = v4l2_subdev_call(sd, video, s_dv_timings, timings); > + ret = v4l2_subdev_call(sd, pad, s_dv_timings, > + vin->parallel.sink_pad, timings); > if (ret) > return ret; > > @@ -744,7 +745,8 @@ static int rvin_g_dv_timings(struct file *file, void *priv_fh, > struct rvin_dev *vin = video_drvdata(file); > struct v4l2_subdev *sd = vin_to_source(vin); > > - return v4l2_subdev_call(sd, video, g_dv_timings, timings); > + return v4l2_subdev_call(sd, pad, g_dv_timings, > + vin->parallel.sink_pad, timings); > } > > static int rvin_query_dv_timings(struct file *file, void *priv_fh, > @@ -753,7 +755,8 @@ static int rvin_query_dv_timings(struct file *file, void *priv_fh, > struct rvin_dev *vin = video_drvdata(file); > struct v4l2_subdev *sd = vin_to_source(vin); > > - return v4l2_subdev_call(sd, video, query_dv_timings, timings); > + return v4l2_subdev_call(sd, pad, query_dv_timings, > + vin->parallel.sink_pad, timings); > } > > static int rvin_dv_timings_cap(struct file *file, void *priv_fh, > -- > 2.44.0.478.gd926399ef9-goog >
diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c index 073f70c6ac68..bb4b07bed28d 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c @@ -730,7 +730,8 @@ static int rvin_s_dv_timings(struct file *file, void *priv_fh, struct v4l2_subdev *sd = vin_to_source(vin); int ret; - ret = v4l2_subdev_call(sd, video, s_dv_timings, timings); + ret = v4l2_subdev_call(sd, pad, s_dv_timings, + vin->parallel.sink_pad, timings); if (ret) return ret; @@ -744,7 +745,8 @@ static int rvin_g_dv_timings(struct file *file, void *priv_fh, struct rvin_dev *vin = video_drvdata(file); struct v4l2_subdev *sd = vin_to_source(vin); - return v4l2_subdev_call(sd, video, g_dv_timings, timings); + return v4l2_subdev_call(sd, pad, g_dv_timings, + vin->parallel.sink_pad, timings); } static int rvin_query_dv_timings(struct file *file, void *priv_fh, @@ -753,7 +755,8 @@ static int rvin_query_dv_timings(struct file *file, void *priv_fh, struct rvin_dev *vin = video_drvdata(file); struct v4l2_subdev *sd = vin_to_source(vin); - return v4l2_subdev_call(sd, video, query_dv_timings, timings); + return v4l2_subdev_call(sd, pad, query_dv_timings, + vin->parallel.sink_pad, timings); } static int rvin_dv_timings_cap(struct file *file, void *priv_fh,
Use the pad variant for all (s|g|query)_dv_timings subdev calls, which includes a pad argument. Signed-off-by: Paweł Anikiel <panikiel@google.com> --- drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)